From e04188c85aae1c89edcc641ae010120804123e38 Mon Sep 17 00:00:00 2001 From: Kevin Brown Date: Wed, 14 Jan 2015 20:59:54 -0500 Subject: [PATCH] Added backwards compatibility for `initSelection` Now if the old `initSelection` method is used, a warning will be triggered in the console informing the user that it has now been changed to `DataAdapter.current`, and they should create a custom data adapter instead. We will still only call `initSelection` once, and then default back to the old data adapter for calls after that. This allows for mostly transparent support between versions. This adds tests to ensure that `initSelection` operates the same as it previously did, but now patches the `current` method of the default data adapter. --- dist/js/select2.amd.full.js | 34 +++++++ dist/js/select2.amd.js | 34 +++++++ dist/js/select2.full.js | 34 +++++++ dist/js/select2.full.min.js | 4 +- dist/js/select2.js | 34 +++++++ dist/js/select2.min.js | 2 +- src/js/select2/defaults.js | 34 +++++++ tests/options/deprecated-tests.js | 158 ++++++++++++++++++++++++++++++ tests/options/deprecated.html | 18 ++++ 9 files changed, 349 insertions(+), 3 deletions(-) create mode 100644 tests/options/deprecated-tests.js create mode 100644 tests/options/deprecated.html diff --git a/dist/js/select2.amd.full.js b/dist/js/select2.amd.full.js index 36d51091..ca877e57 100644 --- a/dist/js/select2.amd.full.js +++ b/dist/js/select2.amd.full.js @@ -3528,6 +3528,40 @@ define('select2/defaults',[ Tokenizer ); } + + if (options.initSelection != null) { + if (console && console.warn) { + console.warn( + 'Select2: The `initSelection` option has been deprecated in favor' + + ' of a custom data adapter that overrides the `current` method. ' + + 'This method is now called multiple times instead of a single ' + + 'time when the instance is initialized.' + ); + } + + var oldCurrent = options.dataAdapter.prototype.current; + var newCurrent = function (callback) { + var self = this; + + if (this._isInitialized) { + oldCurrent.call(this, callback); + + return; + } + + options.initSelection.call(null, this.$element, function (data) { + self._isInitialized = true; + + if (!$.isArray(data)) { + data = [data]; + } + + callback(data); + }); + }; + + options.dataAdapter.prototype.current = newCurrent; + } } if (options.resultsAdapter == null) { diff --git a/dist/js/select2.amd.js b/dist/js/select2.amd.js index 5225a91e..5fa6638f 100644 --- a/dist/js/select2.amd.js +++ b/dist/js/select2.amd.js @@ -3528,6 +3528,40 @@ define('select2/defaults',[ Tokenizer ); } + + if (options.initSelection != null) { + if (console && console.warn) { + console.warn( + 'Select2: The `initSelection` option has been deprecated in favor' + + ' of a custom data adapter that overrides the `current` method. ' + + 'This method is now called multiple times instead of a single ' + + 'time when the instance is initialized.' + ); + } + + var oldCurrent = options.dataAdapter.prototype.current; + var newCurrent = function (callback) { + var self = this; + + if (this._isInitialized) { + oldCurrent.call(this, callback); + + return; + } + + options.initSelection.call(null, this.$element, function (data) { + self._isInitialized = true; + + if (!$.isArray(data)) { + data = [data]; + } + + callback(data); + }); + }; + + options.dataAdapter.prototype.current = newCurrent; + } } if (options.resultsAdapter == null) { diff --git a/dist/js/select2.full.js b/dist/js/select2.full.js index af876a0e..a8f648eb 100644 --- a/dist/js/select2.full.js +++ b/dist/js/select2.full.js @@ -13063,6 +13063,40 @@ define('select2/defaults',[ Tokenizer ); } + + if (options.initSelection != null) { + if (console && console.warn) { + console.warn( + 'Select2: The `initSelection` option has been deprecated in favor' + + ' of a custom data adapter that overrides the `current` method. ' + + 'This method is now called multiple times instead of a single ' + + 'time when the instance is initialized.' + ); + } + + var oldCurrent = options.dataAdapter.prototype.current; + var newCurrent = function (callback) { + var self = this; + + if (this._isInitialized) { + oldCurrent.call(this, callback); + + return; + } + + options.initSelection.call(null, this.$element, function (data) { + self._isInitialized = true; + + if (!$.isArray(data)) { + data = [data]; + } + + callback(data); + }); + }; + + options.dataAdapter.prototype.current = newCurrent; + } } if (options.resultsAdapter == null) { diff --git a/dist/js/select2.full.min.js b/dist/js/select2.full.min.js index 58e0420c..bb74e0d1 100644 --- a/dist/js/select2.full.min.js +++ b/dist/js/select2.full.min.js @@ -1,5 +1,5 @@ window.$=window.$||{},function(){$&&$.fn&&$.fn.select2&&$.fn.select2.amd&&(c=$.fn.select2.amd.define,b=$.fn.select2.amd.require);var a,b,c;!function(d){function e(a,b){return u.call(a,b)}function f(a,b){var c,d,e,f,g,h,i,j,k,l,m,n=b&&b.split("/"),o=s.map,p=o&&o["*"]||{};if(a&&"."===a.charAt(0))if(b){for(n=n.slice(0,n.length-1),a=a.split("/"),g=a.length-1,s.nodeIdCompat&&w.test(a[g])&&(a[g]=a[g].replace(w,"")),a=n.concat(a),k=0;k0&&(a.splice(k-1,2),k-=2)}a=a.join("/")}else 0===a.indexOf("./")&&(a=a.substring(2));if((n||p)&&o){for(c=a.split("/"),k=c.length;k>0;k-=1){if(d=c.slice(0,k).join("/"),n)for(l=n.length;l>0;l-=1)if(e=o[n.slice(0,l).join("/")],e&&(e=e[d])){f=e,h=k;break}if(f)break;!i&&p&&p[d]&&(i=p[d],j=k)}!f&&i&&(f=i,h=j),f&&(c.splice(0,h,f),a=c.join("/"))}return a}function g(a,b){return function(){return n.apply(d,v.call(arguments,0).concat([a,b]))}}function h(a){return function(b){return f(b,a)}}function i(a){return function(b){q[a]=b}}function j(a){if(e(r,a)){var b=r[a];delete r[a],t[a]=!0,m.apply(d,b)}if(!e(q,a)&&!e(t,a))throw new Error("No "+a);return q[a]}function k(a){var b,c=a?a.indexOf("!"):-1;return c>-1&&(b=a.substring(0,c),a=a.substring(c+1,a.length)),[b,a]}function l(a){return function(){return s&&s.config&&s.config[a]||{}}}var m,n,o,p,q={},r={},s={},t={},u=Object.prototype.hasOwnProperty,v=[].slice,w=/\.js$/;o=function(a,b){var c,d=k(a),e=d[0];return a=d[1],e&&(e=f(e,b),c=j(e)),e?a=c&&c.normalize?c.normalize(a,h(b)):f(a,b):(a=f(a,b),d=k(a),e=d[0],a=d[1],e&&(c=j(e))),{f:e?e+"!"+a:a,n:a,pr:e,p:c}},p={require:function(a){return g(a)},exports:function(a){var b=q[a];return"undefined"!=typeof b?b:q[a]={}},module:function(a){return{id:a,uri:"",exports:q[a],config:l(a)}}},m=function(a,b,c,f){var h,k,l,m,n,s,u=[],v=typeof c;if(f=f||a,"undefined"===v||"function"===v){for(b=!b.length&&c.length?["require","exports","module"]:b,n=0;n0&&b-1 in a}function e(a,b,c){if(bb.isFunction(b))return bb.grep(a,function(a,d){return!!b.call(a,d,a)!==c});if(b.nodeType)return bb.grep(a,function(a){return a===b!==c});if("string"==typeof b){if(ib.test(b))return bb.filter(b,a,c);b=bb.filter(b,a)}return bb.grep(a,function(a){return V.call(b,a)>=0!==c})}function f(a,b){for(;(a=a[b])&&1!==a.nodeType;);return a}function g(a){var b=pb[a]={};return bb.each(a.match(ob)||[],function(a,c){b[c]=!0}),b}function h(){_.removeEventListener("DOMContentLoaded",h,!1),a.removeEventListener("load",h,!1),bb.ready()}function i(){Object.defineProperty(this.cache={},0,{get:function(){return{}}}),this.expando=bb.expando+Math.random()}function j(a,b,c){var d;if(void 0===c&&1===a.nodeType)if(d="data-"+b.replace(vb,"-$1").toLowerCase(),c=a.getAttribute(d),"string"==typeof c){try{c="true"===c?!0:"false"===c?!1:"null"===c?null:+c+""===c?+c:ub.test(c)?bb.parseJSON(c):c}catch(e){}tb.set(a,b,c)}else c=void 0;return c}function k(){return!0}function l(){return!1}function m(){try{return _.activeElement}catch(a){}}function n(a,b){return bb.nodeName(a,"table")&&bb.nodeName(11!==b.nodeType?b:b.firstChild,"tr")?a.getElementsByTagName("tbody")[0]||a.appendChild(a.ownerDocument.createElement("tbody")):a}function o(a){return a.type=(null!==a.getAttribute("type"))+"/"+a.type,a}function p(a){var b=Lb.exec(a.type);return b?a.type=b[1]:a.removeAttribute("type"),a}function q(a,b){for(var c=0,d=a.length;d>c;c++)sb.set(a[c],"globalEval",!b||sb.get(b[c],"globalEval"))}function r(a,b){var c,d,e,f,g,h,i,j;if(1===b.nodeType){if(sb.hasData(a)&&(f=sb.access(a),g=sb.set(b,f),j=f.events)){delete g.handle,g.events={};for(e in j)for(c=0,d=j[e].length;d>c;c++)bb.event.add(b,e,j[e][c])}tb.hasData(a)&&(h=tb.access(a),i=bb.extend({},h),tb.set(b,i))}}function s(a,b){var c=a.getElementsByTagName?a.getElementsByTagName(b||"*"):a.querySelectorAll?a.querySelectorAll(b||"*"):[];return void 0===b||b&&bb.nodeName(a,b)?bb.merge([a],c):c}function t(a,b){var c=b.nodeName.toLowerCase();"input"===c&&zb.test(a.type)?b.checked=a.checked:("input"===c||"textarea"===c)&&(b.defaultValue=a.defaultValue)}function u(b,c){var d=bb(c.createElement(b)).appendTo(c.body),e=a.getDefaultComputedStyle?a.getDefaultComputedStyle(d[0]).display:bb.css(d[0],"display");return d.detach(),e}function v(a){var b=_,c=Pb[a];return c||(c=u(a,b),"none"!==c&&c||(Ob=(Ob||bb("