Fix hiding search

When the dropdown is in the dropdown that is attached to the body,
the call to `show` causes `display: inline` to be set directly on
the search container. This causes rendering issues, so this change
uses a class instead of calling `show` and `hide` directly.

This is most likely a jQuery bug of some form, as it only happens
when using the dropdown that is attached to the body.

dist/css/select2.css

@@ -76,6 +76,8 @@
   .select2-search--dropdown .select2-search__field {
     padding: 4px;
     width: 100%; }
+  .select2-search--dropdown .select2-search--hide {
+    display: none; }
 
 .select2-container--default .select2-selection--single {
   background-color: #fff;

dist/js/select2.amd.full.js

@@ -1131,10 +1131,6 @@ define('select2/selection/search',[
     this.$search.css('width', width);
   };
 
-  Search.prototype.showSearch = function (_, params) {
-    return true;
-  };
-
   return Search;
 });
 
@@ -2658,9 +2654,9 @@ define('select2/dropdown/search',[
         var showSearch = self.showSearch(params);
 
         if (showSearch) {
-          self.$searchContainer.show();
+          self.$searchContainer.removeClass('select2-search--hide');
         } else {
-          self.$searchContainer.hide();
+          self.$searchContainer.addClass('select2-search--hide');
         }
       }
     });

dist/js/select2.amd.js

@@ -1131,10 +1131,6 @@ define('select2/selection/search',[
     this.$search.css('width', width);
   };
 
-  Search.prototype.showSearch = function (_, params) {
-    return true;
-  };
-
   return Search;
 });
 
@@ -2658,9 +2654,9 @@ define('select2/dropdown/search',[
         var showSearch = self.showSearch(params);
 
         if (showSearch) {
-          self.$searchContainer.show();
+          self.$searchContainer.removeClass('select2-search--hide');
         } else {
-          self.$searchContainer.hide();
+          self.$searchContainer.addClass('select2-search--hide');
         }
       }
     });

dist/js/select2.full.js

@@ -10666,10 +10666,6 @@ define('select2/selection/search',[
     this.$search.css('width', width);
   };
 
-  Search.prototype.showSearch = function (_, params) {
-    return true;
-  };
-
   return Search;
 });
 
@@ -12193,9 +12189,9 @@ define('select2/dropdown/search',[
         var showSearch = self.showSearch(params);
 
         if (showSearch) {
-          self.$searchContainer.show();
+          self.$searchContainer.removeClass('select2-search--hide');
         } else {
-          self.$searchContainer.hide();
+          self.$searchContainer.addClass('select2-search--hide');
         }
       }
     });

dist/js/select2.js

@@ -1559,10 +1559,6 @@ define('select2/selection/search',[
     this.$search.css('width', width);
   };
 
-  Search.prototype.showSearch = function (_, params) {
-    return true;
-  };
-
   return Search;
 });
 
@@ -3086,9 +3082,9 @@ define('select2/dropdown/search',[
         var showSearch = self.showSearch(params);
 
         if (showSearch) {
-          self.$searchContainer.show();
+          self.$searchContainer.removeClass('select2-search--hide');
         } else {
-          self.$searchContainer.hide();
+          self.$searchContainer.addClass('select2-search--hide');
         }
       }
     });

src/js/select2/dropdown/search.js

@@ -53,9 +53,9 @@ define([
         var showSearch = self.showSearch(params);
 
         if (showSearch) {
-          self.$searchContainer.show();
+          self.$searchContainer.removeClass('select2-search--hide');
         } else {
-          self.$searchContainer.hide();
+          self.$searchContainer.addClass('select2-search--hide');
         }
       }
     });

src/js/select2/selection/search.js

@@ -100,9 +100,5 @@ define([
     this.$search.css('width', width);
   };
 
-  Search.prototype.showSearch = function (_, params) {
-    return true;
-  };
-
   return Search;
 });

src/scss/_dropdown.scss

@@ -53,4 +53,8 @@
     padding: 4px;
     width: 100%;
   }
+
+  .select2-search--hide {
+    display: none;
+  }
 }