1
0
mirror of synced 2025-02-03 21:59:24 +03:00

Fix hiding search

When the dropdown is in the dropdown that is attached to the body,
the call to `show` causes `display: inline` to be set directly on
the search container. This causes rendering issues, so this change
uses a class instead of calling `show` and `hide` directly.

This is most likely a jQuery bug of some form, as it only happens
when using the dropdown that is attached to the body.
This commit is contained in:
Kevin Brown 2014-11-26 20:39:52 -05:00
parent 4cab421966
commit 7fc195f70d
11 changed files with 19 additions and 33 deletions

View File

@ -76,6 +76,8 @@
.select2-search--dropdown .select2-search__field {
padding: 4px;
width: 100%; }
.select2-search--dropdown .select2-search--hide {
display: none; }
.select2-container--default .select2-selection--single {
background-color: #fff;

File diff suppressed because one or more lines are too long

View File

@ -1131,10 +1131,6 @@ define('select2/selection/search',[
this.$search.css('width', width);
};
Search.prototype.showSearch = function (_, params) {
return true;
};
return Search;
});
@ -2658,9 +2654,9 @@ define('select2/dropdown/search',[
var showSearch = self.showSearch(params);
if (showSearch) {
self.$searchContainer.show();
self.$searchContainer.removeClass('select2-search--hide');
} else {
self.$searchContainer.hide();
self.$searchContainer.addClass('select2-search--hide');
}
}
});

View File

@ -1131,10 +1131,6 @@ define('select2/selection/search',[
this.$search.css('width', width);
};
Search.prototype.showSearch = function (_, params) {
return true;
};
return Search;
});
@ -2658,9 +2654,9 @@ define('select2/dropdown/search',[
var showSearch = self.showSearch(params);
if (showSearch) {
self.$searchContainer.show();
self.$searchContainer.removeClass('select2-search--hide');
} else {
self.$searchContainer.hide();
self.$searchContainer.addClass('select2-search--hide');
}
}
});

View File

@ -10666,10 +10666,6 @@ define('select2/selection/search',[
this.$search.css('width', width);
};
Search.prototype.showSearch = function (_, params) {
return true;
};
return Search;
});
@ -12193,9 +12189,9 @@ define('select2/dropdown/search',[
var showSearch = self.showSearch(params);
if (showSearch) {
self.$searchContainer.show();
self.$searchContainer.removeClass('select2-search--hide');
} else {
self.$searchContainer.hide();
self.$searchContainer.addClass('select2-search--hide');
}
}
});

File diff suppressed because one or more lines are too long

8
dist/js/select2.js vendored
View File

@ -1559,10 +1559,6 @@ define('select2/selection/search',[
this.$search.css('width', width);
};
Search.prototype.showSearch = function (_, params) {
return true;
};
return Search;
});
@ -3086,9 +3082,9 @@ define('select2/dropdown/search',[
var showSearch = self.showSearch(params);
if (showSearch) {
self.$searchContainer.show();
self.$searchContainer.removeClass('select2-search--hide');
} else {
self.$searchContainer.hide();
self.$searchContainer.addClass('select2-search--hide');
}
}
});

File diff suppressed because one or more lines are too long

View File

@ -53,9 +53,9 @@ define([
var showSearch = self.showSearch(params);
if (showSearch) {
self.$searchContainer.show();
self.$searchContainer.removeClass('select2-search--hide');
} else {
self.$searchContainer.hide();
self.$searchContainer.addClass('select2-search--hide');
}
}
});

View File

@ -100,9 +100,5 @@ define([
this.$search.css('width', width);
};
Search.prototype.showSearch = function (_, params) {
return true;
};
return Search;
});

View File

@ -53,4 +53,8 @@
padding: 4px;
width: 100%;
}
.select2-search--hide {
display: none;
}
}