From 5d2fdd75b51d5810e5c4c00c783bd6e8e03b9d0f Mon Sep 17 00:00:00 2001 From: Kevin Brown Date: Tue, 4 Jun 2019 22:43:52 -0400 Subject: [PATCH] Update grunt-contrib-qunit to latest version (#5530) We needed to define the `qunit` module in the unit tests because there was a change in grunt-contrib-qunit 0.6.0 that breaks when you define an AMD loader. It expects that the AMD loader is also used to load QUnit, instead of just being used to support the tests, so if you don't define the qunit module it will just hang and do nothing. Luckily we have the helpers file to help us out here, since it allows us to globally define this module. --- package.json | 2 +- tests/helpers.js | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index e226ff2e..231473b5 100644 --- a/package.json +++ b/package.json @@ -53,7 +53,7 @@ "grunt-contrib-concat": "^1.0.1", "grunt-contrib-connect": "^2.0.0", "grunt-contrib-jshint": "^1.1.0", - "grunt-contrib-qunit": "^0.5.2", + "grunt-contrib-qunit": "^1.3.0", "grunt-contrib-requirejs": "^1.0.0", "grunt-contrib-uglify": "~4.0.1", "grunt-contrib-watch": "~1.1.0", diff --git a/tests/helpers.js b/tests/helpers.js index e0c9fa22..9409c8b6 100644 --- a/tests/helpers.js +++ b/tests/helpers.js @@ -44,3 +44,7 @@ QUnit.testStart(function(testDetails){ } }); }); + +define('qunit', function () { + return QUnit; +}) \ No newline at end of file