diff --git a/VERSION b/VERSION index 2aa5131..7921bd0 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -3.4.7 +3.4.8 diff --git a/retailcrm/lib/RetailcrmOrderBuilder.php b/retailcrm/lib/RetailcrmOrderBuilder.php index 44013a5..ce51cf6 100644 --- a/retailcrm/lib/RetailcrmOrderBuilder.php +++ b/retailcrm/lib/RetailcrmOrderBuilder.php @@ -876,7 +876,6 @@ class RetailcrmOrderBuilder * @param Order|\OrderCore $order PrestaShop Order * @param Customer|\CustomerCore|null $customer PrestaShop Customer * @param Cart|\CartCore|null $orderCart Cart for provided order. Optional - * @param bool $isStatusExport Use status for export * @param bool $preferCustomerAddress Use customer address even if delivery address is * provided * @param bool $dataFromCart Prefer data from cart @@ -893,7 +892,6 @@ class RetailcrmOrderBuilder $order, $customer = null, $orderCart = null, - $isStatusExport = false, // todo always false -> remove unused parameter $preferCustomerAddress = false, $dataFromCart = false, $contactPersonId = '', @@ -901,7 +899,6 @@ class RetailcrmOrderBuilder $customerId = '', $site = '' ) { - $statusExport = Configuration::get(RetailCRM::STATUS_EXPORT); $delivery = json_decode(Configuration::get(RetailCRM::DELIVERY), true); $payment = json_decode(Configuration::get(RetailCRM::PAYMENT), true); $status = json_decode(Configuration::get(RetailCRM::STATUS), true); @@ -914,19 +911,9 @@ class RetailcrmOrderBuilder $paymentType = $order->payment; } - if (0 == $order->current_state) { // todo refactor - $order_status = $statusExport; - - if (!$isStatusExport) { - $order_status = - array_key_exists($order->current_state, $status) - ? $status[$order->current_state] : 'new'; - } - } else { - $order_status = array_key_exists($order->current_state, $status) - ? $status[$order->current_state] - : $statusExport; - } + $order_status = array_key_exists($order->current_state, $status) + ? $status[$order->current_state] + : null; $cart = $orderCart; diff --git a/retailcrm/retailcrm.php b/retailcrm/retailcrm.php index e7b1ef0..d9bc99e 100644 --- a/retailcrm/retailcrm.php +++ b/retailcrm/retailcrm.php @@ -48,7 +48,7 @@ require_once dirname(__FILE__) . '/bootstrap.php'; class RetailCRM extends Module { - const VERSION = '3.4.7'; + const VERSION = '3.4.8'; const API_URL = 'RETAILCRM_ADDRESS'; const API_KEY = 'RETAILCRM_API_TOKEN'; @@ -58,7 +58,6 @@ class RetailCRM extends Module const PAYMENT = 'RETAILCRM_API_PAYMENT'; const DELIVERY_DEFAULT = 'RETAILCRM_API_DELIVERY_DEFAULT'; const PAYMENT_DEFAULT = 'RETAILCRM_API_PAYMENT_DEFAULT'; - const STATUS_EXPORT = 'RETAILCRM_STATUS_EXPORT'; const CLIENT_ID = 'RETAILCRM_CLIENT_ID'; const COLLECTOR_ACTIVE = 'RETAILCRM_DAEMON_COLLECTOR_ACTIVE'; const COLLECTOR_KEY = 'RETAILCRM_DAEMON_COLLECTOR_KEY'; @@ -317,7 +316,6 @@ class RetailCRM extends Module && Configuration::deleteByName(static::PAYMENT) && Configuration::deleteByName(static::DELIVERY_DEFAULT) && Configuration::deleteByName(static::PAYMENT_DEFAULT) - && Configuration::deleteByName(static::STATUS_EXPORT) && Configuration::deleteByName(static::CLIENT_ID) && Configuration::deleteByName(static::COLLECTOR_ACTIVE) && Configuration::deleteByName(static::COLLECTOR_KEY) diff --git a/retailcrm/upgrade/upgrade-3.4.8.php b/retailcrm/upgrade/upgrade-3.4.8.php new file mode 100644 index 0000000..b902d35 --- /dev/null +++ b/retailcrm/upgrade/upgrade-3.4.8.php @@ -0,0 +1,61 @@ + + * @copyright 2021 DIGITAL RETAIL TECHNOLOGIES SL + * @license https://opensource.org/licenses/MIT The MIT License + * + * Don't forget to prefix your containers with your own identifier + * to avoid any conflicts with others containers. + */ + +if (!defined('_PS_VERSION_')) { + exit; +} + +/** + * Upgrade module to version 3.4.8 + * + * @param \RetailCRM $module + * + * @return bool + */ +function upgrade_module_3_4_8($module) +{ + if ('retailcrm' != $module->name) { + return false; + } + + if (Configuration::hasKey('RETAILCRM_STATUS_EXPORT')) { + return Configuration::deleteByName('RETAILCRM_STATUS_EXPORT'); + } + + return true; +}