RetailCRM-Mirror/prestashop-module
1
0
Fork 0
mirror of https://github.com/retailcrm/prestashop-module.git synced 2025-03-01 19:03:14 +03:00
Code Issues Projects Releases Wiki Activity

Do not remove tabs when deactivating module in Multistore

Browse Source
This commit is contained in:
max-baranikov 2022-09-12 21:22:53 +03:00 committed by GitHub
parent 32fd10247b
commit b3e8525c8e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 56 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
retailcrm/controllers/admin/RetailcrmModuleDisablingAware.php Normal file
View File

@ -0,0 +1,41 @@
<?php
/**
* MIT License
*
* Copyright (c) 2021 DIGITAL RETAIL TECHNOLOGIES SL
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
* SOFTWARE.
*
* DISCLAIMER
*
* Do not edit or add to this file if you wish to upgrade PrestaShop to newer
* versions in the future. If you wish to customize PrestaShop for your
* needs please refer to http://www.prestashop.com for more information.
*
* @author DIGITAL RETAIL TECHNOLOGIES SL <mail@simlachat.com>
* @copyright 2021 DIGITAL RETAIL TECHNOLOGIES SL
* @license https://opensource.org/licenses/MIT The MIT License
*
* Don't forget to prefix your containers with your own identifier
* to avoid any conflicts with others containers.
*/
interface RetailcrmModuleDisablingAware
{
}

2
retailcrm/controllers/admin/RetailcrmSettingsLinkController.php
View File

@ -38,7 +38,7 @@
require_once dirname(__FILE__) . '/../../bootstrap.php';
class RetailcrmSettingsLinkController extends RetailcrmAdminAbstractController
class RetailcrmSettingsLinkController extends RetailcrmAdminAbstractController implements RetailcrmModuleDisablingAware
{
public static function getParentId()
{

19
retailcrm/retailcrm.php
View File

@ -240,12 +240,12 @@ class RetailCRM extends Module
* @throws PrestaShopDatabaseException
* @throws PrestaShopException
*/
public function uninstallTab()
public function uninstallTab($forceAll = true)
{
/** @var RetailcrmAdminAbstractController $controller */
foreach (self::ADMIN_CONTROLLERS as $controller) {
$tabId = $controller::getId();
if (!$tabId) {
if (!$tabId || (!$forceAll && !is_subclass_of($controller, RetailcrmModuleDisablingAware::class))) {
continue;
}
@ -354,9 +354,18 @@ class RetailCRM extends Module
public function disable($force_all = false)
{
return parent::disable($force_all)
&& $this->uninstallTab()
;
if (!parent::disable($force_all)) {
return false;
}
$sql = 'SELECT COUNT(`id_shop`) FROM `' . _DB_PREFIX_ . 'module_shop`
WHERE `id_module` = ' . (int) $this->id;
if ('0' === Db::getInstance($sql)->getValue($sql)) {
return $this->uninstallTab(false);
}
return true;
}
public function installDB()