From b23ab4492cc2025fe4ad0182cde7cdf835f5103a Mon Sep 17 00:00:00 2001 From: Neur0toxine Date: Mon, 15 Feb 2021 12:08:41 +0300 Subject: [PATCH] static code analysis (#2) --- .github/workflows/ci.yml | 12 +++ .golangci.yml | 188 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 200 insertions(+) create mode 100644 .golangci.yml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d10dd2c..8a4beee 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -12,6 +12,18 @@ env: GO111MODULE: on jobs: + golangci: + name: lint + if: ${{ github.event_name == 'pull_request' }} + runs-on: ubuntu-latest + steps: + - name: Check out code into the Go module directory + uses: actions/checkout@v2 + - name: Lint code with golangci-lint + uses: golangci/golangci-lint-action@v2 + with: + version: v1.36 + only-new-issues: true tests: name: Tests runs-on: ubuntu-latest diff --git a/.golangci.yml b/.golangci.yml new file mode 100644 index 0000000..9397fd4 --- /dev/null +++ b/.golangci.yml @@ -0,0 +1,188 @@ +run: + skip-dirs-use-default: true + allow-parallel-runners: true + +output: + format: colored-line-number + sort-results: true + +linters: + disable-all: true + enable: + - deadcode + - errcheck + - gosimple + - govet + - ineffassign + - staticcheck + - structcheck + - unused + - unparam + - varcheck + - bodyclose + - dogsled + - dupl + - errorlint + - exhaustive + - exportloopref + - funlen + - gocognit + - goconst + - gocritic + - gocyclo + - godot + - goimports + - golint + - gomnd + - gosec + - ifshort + - interfacer + - lll + - makezero + - maligned + - misspell + - nestif + - prealloc + - predeclared + - scopelint + - sqlclosecheck + - unconvert + - whitespace + +linters-settings: + govet: + check-shadowing: false + disable-all: true + enable: + - assign + - atomic + - bools + - buildtag + - copylocks + - httpresponse + - loopclosure + - lostcancel + - printf + - shift + - stdmethods + - structtag + - tests + - unmarshal + - unreachable + - unsafeptr + - unused + settings: + printf: + funcs: + - (*log.Logger).Fatal + - (*log.Logger).Fatalf + - (*log.Logger).Fatalln + - (*log.Logger).Panic + - (*log.Logger).Panicf + - (*log.Logger).Panicln + - (*log.Logger).Print + - (*log.Logger).Printf + - (*log.Logger).Println + - (*testing.common).Error + - (*testing.common).Errorf + - (*testing.common).Fatal + - (*testing.common).Fatalf + - (*testing.common).Log + - (*testing.common).Logf + - (*testing.common).Skip + - (*testing.common).Skipf + - (testing.TB).Error + - (testing.TB).Errorf + - (testing.TB).Fatal + - (testing.TB).Fatalf + - (testing.TB).Log + - (testing.TB).Logf + - (testing.TB).Skip + - (testing.TB).Skipf + - fmt.Errorf + - fmt.Fprint + - fmt.Fprintf + - fmt.Fprintln + - fmt.Print + - fmt.Printf + - fmt.Println + - fmt.Sprint + - fmt.Sprintf + - fmt.Sprintln + - log.Fatal + - log.Fatalf + - log.Fatalln + - log.Panic + - log.Panicf + - log.Panicln + - log.Print + - log.Printf + - log.Println + - runtime/trace.Logf + unused: + check-exported: false + unparam: + check-exported: false + dogsled: + max-blank-identifiers: 3 + dupl: + threshold: 200 + errorlint: + errorf: true + exhaustive: + check-generated: false + default-signifies-exhaustive: false + funlen: + lines: 60 + statements: 40 + gocognit: + min-complexity: 25 + gocyclo: + min-complexity: 25 + goimports: + local-prefixes: github.com/retailcrm/messenger + lll: + line-length: 120 + maligned: + suggest-new: true + misspell: + locale: US + nestif: + min-complexity: 4 + whitespace: + multi-if: false + multi-func: false + +issues: + exclude-rules: + - path: _test\.go + linters: + - gomnd + - lll + - bodyclose + - errcheck + - sqlclosecheck + - misspell + - ineffassign + - whitespace + - makezero + - maligned + - ifshort + - errcheck + - funlen + - goconst + - gocognit + - gocyclo + - godot + exclude-use-default: true + exclude-case-sensitive: false + max-issues-per-linter: 0 + max-same-issues: 0 + fix: true + +severity: + default-severity: error + case-sensitive: false + +service: + golangci-lint-version: 1.36.x