1
0
mirror of synced 2025-02-16 13:33:13 +03:00

Merge pull request #65 from jBugman/response

Correct HTTP responses and semantic codes
This commit is contained in:
Harrison Shoebridge 2019-07-31 10:20:06 +10:00 committed by GitHub
commit af0f4aab62
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -280,25 +280,32 @@ func (m *Messenger) handle(w http.ResponseWriter, r *http.Request) {
err := json.Unmarshal(body, &rec)
if err != nil {
fmt.Println("could not decode response:", err)
fmt.Fprintln(w, `{status: 'not ok'}`)
respond(w, http.StatusBadRequest)
return
}
if rec.Object != "page" {
fmt.Println("Object is not page, undefined behaviour. Got", rec.Object)
respond(w, http.StatusUnprocessableEntity)
return
}
if m.verify {
if err := m.checkIntegrity(r); err != nil {
fmt.Println("could not verify request:", err)
fmt.Fprintln(w, `{status: 'not ok'}`)
respond(w, http.StatusUnauthorized)
return
}
}
m.dispatch(rec)
fmt.Fprintln(w, `{status: 'ok'}`)
respond(w, http.StatusAccepted) // We do not return any meaningful response immediately so it should be 202
}
func respond(w http.ResponseWriter, code int) {
w.Header().Set("Content-Type", "application/json")
fmt.Fprintf(w, `{"code": %d, "status": "%s"}`, code, http.StatusText(code))
}
// checkIntegrity checks the integrity of the requests received