RetailCRM-Mirror/messenger
1
0
Fork 0
mirror of synced 2024-11-29 08:36:12 +03:00
Code Issues Projects Releases Wiki Activity

update linter and it's rules

Browse Source
This commit is contained in:
Ruslan Efanov 2022-12-30 10:14:28 +03:00
parent e378e55563
commit 99463a68f2
2 changed files with 36 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/ci.yml vendored
View File

@ -29,7 +29,7 @@ jobs:
- name: Lint code with golangci-lint - name: Lint code with golangci-lint
uses: golangci/golangci-lint-action@v3 uses: golangci/golangci-lint-action@v3
with: with:
version: v1.42.1 version: v1.50.1
only-new-issues: true only-new-issues: true
tests: tests:
name: Tests name: Tests

51
.golangci.yml
View File

@ -6,20 +6,33 @@ output:
format: colored-line-number format: colored-line-number
sort-results: true sort-results: true
# Linters below do not support go1.18 yet because of generics.
# See https://github.com/golangci/golangci-lint/issues/2649
# - bodyclose
# - sqlclosecheck
linters: linters:
disable-all: true disable-all: true
enable: enable:
- deadcode - paralleltest
- tparallel
- asciicheck
- asasalint
- varnamelen
- reassign
- nilnil
- nilerr
- nakedret
- goprintffuncname
- typecheck
- errchkjson
- errcheck - errcheck
- gosimple - gosimple
- govet - govet
- ineffassign - ineffassign
- staticcheck - staticcheck
- structcheck
- unused - unused
- unparam - unparam
- varcheck
- bodyclose
- dogsled - dogsled
- dupl - dupl
- errorlint - errorlint
@ -34,14 +47,13 @@ linters:
- goimports - goimports
- revive - revive
- gosec - gosec
- ifshort
- lll - lll
- makezero - makezero
- misspell - misspell
- nestif - nestif
- prealloc - prealloc
- predeclared - predeclared
- sqlclosecheck - exportloopref
- unconvert - unconvert
- whitespace - whitespace
@ -68,7 +80,6 @@ linters-settings:
- unmarshal - unmarshal
- unreachable - unreachable
- unsafeptr - unsafeptr
- unused
settings: settings:
printf: printf:
funcs: funcs:
@ -127,42 +138,48 @@ linters-settings:
threshold: 200 threshold: 200
errorlint: errorlint:
errorf: true errorf: true
asserts: false
comparison: false
exhaustive: exhaustive:
check-generated: false check-generated: false
default-signifies-exhaustive: false default-signifies-exhaustive: false
funlen: funlen:
lines: 60 lines: 90
statements: 40 statements: 40
gocognit: gocognit:
min-complexity: 25 min-complexity: 25
gocyclo: gocyclo:
min-complexity: 25 min-complexity: 25
goimports: goimports:
local-prefixes: github.com/retailcrm/mg-transport-core local-prefixes: github.com/retailcrm/messenger
lll: lll:
line-length: 120 line-length: 120
misspell: misspell:
locale: US locale: US
nestif: nestif:
min-complexity: 6 min-complexity: 4
whitespace: whitespace:
multi-if: false multi-if: false
multi-func: false multi-func: false
varnamelen:
max-distance: 10
ignore-map-index-ok: true
ignore-type-assert-ok: true
ignore-chan-recv-ok: true
ignore-decls:
- t *testing.T
- e error
- i int
issues: issues:
exclude-rules: exclude-rules:
- path: _test\.go - path: _test\.go
linters: linters:
- lll - lll
- errorlint
- bodyclose
- errcheck - errcheck
- sqlclosecheck
- misspell - misspell
- ineffassign - ineffassign
- whitespace - whitespace
- makezero - makezero
- ifshort
- errcheck - errcheck
- funlen - funlen
- goconst - goconst
@ -170,6 +187,8 @@ issues:
- gocyclo - gocyclo
- godot - godot
- unused - unused
- errchkjson
- varnamelen
- path: \.go - path: \.go
text: "Error return value of `io.WriteString` is not checked" text: "Error return value of `io.WriteString` is not checked"
exclude-use-default: true exclude-use-default: true
@ -183,4 +202,4 @@ severity:
case-sensitive: false case-sensitive: false
service: service:
golangci-lint-version: 1.36.x golangci-lint-version: 1.50.x