RetailCRM-Mirror/messenger
1
0
Fork 0
mirror of synced 2024-11-25 22:36:03 +03:00
Code Issues Projects Releases Wiki Activity

Correct HTTP responses and semantic codes

Browse Source
This commit is contained in:
Sergey Parshukov 2019-07-31 00:11:26 +03:00
parent b90fe59765
commit 7599daf34a
No known key found for this signature in database
GPG Key ID: 9D0FB8D5E702923A
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
messenger.go
View File

@ -280,25 +280,37 @@ func (m *Messenger) handle(w http.ResponseWriter, r *http.Request) {
err := json.Unmarshal(body, &rec) err := json.Unmarshal(body, &rec)
if err != nil { if err != nil {
fmt.Println("could not decode response:", err) fmt.Println("could not decode response:", err)
fmt.Fprintln(w, `{status: 'not ok'}`) respond(w, http.StatusBadRequest)
return return
} }
if rec.Object != "page" { if rec.Object != "page" {
fmt.Println("Object is not page, undefined behaviour. Got", rec.Object) fmt.Println("Object is not page, undefined behaviour. Got", rec.Object)
respond(w, http.StatusUnprocessableEntity)
return
} }
if m.verify { if m.verify {
if err := m.checkIntegrity(r); err != nil { if err := m.checkIntegrity(r); err != nil {
fmt.Println("could not verify request:", err) fmt.Println("could not verify request:", err)
fmt.Fprintln(w, `{status: 'not ok'}`) respond(w, http.StatusUnauthorized)
return return
} }
} }
m.dispatch(rec) m.dispatch(rec)
fmt.Fprintln(w, `{status: 'ok'}`) respond(w, http.StatusAccepted) // We do not return any meaningful response immediately so it should be 202
}
func respond(w http.ResponseWriter, code int) {
w.Header().Set("Content-Type", "application/json")
w.WriteHeader(code)
if code < 400 {
fmt.Fprintln(w, `{"status": "ok"}`)
} else {
fmt.Fprintln(w, `{"status": "not ok"}`)
}
} }
// checkIntegrity checks the integrity of the requests received // checkIntegrity checks the integrity of the requests received