From cbb13527b9d4775c25c6303c7fb588d8b2bea3b7 Mon Sep 17 00:00:00 2001 From: Tobias Nyholm Date: Wed, 23 Jan 2019 10:35:58 +0100 Subject: [PATCH] Minor cleanup and cs (#550) * Minor cleanup and cs * minor --- src/Model/Suppression/Bounce/Bounce.php | 1 - src/Model/Suppression/Bounce/IndexResponse.php | 1 - src/Model/Suppression/Complaint/Complaint.php | 1 - src/Model/Suppression/Complaint/IndexResponse.php | 1 - src/Model/Suppression/Unsubscribe/IndexResponse.php | 1 - src/Model/Suppression/Unsubscribe/Unsubscribe.php | 6 +----- src/Model/Tag/IndexResponse.php | 1 - src/Model/Tag/UpdateResponse.php | 3 ++- 8 files changed, 3 insertions(+), 12 deletions(-) diff --git a/src/Model/Suppression/Bounce/Bounce.php b/src/Model/Suppression/Bounce/Bounce.php index 35f4107..a89bbf2 100644 --- a/src/Model/Suppression/Bounce/Bounce.php +++ b/src/Model/Suppression/Bounce/Bounce.php @@ -28,7 +28,6 @@ class Bounce public static function create(array $data): self { $model = new self(); - $model->address = $data['address'] ?? null; $model->code = $data['code'] ?? null; $model->error = $data['error'] ?? null; diff --git a/src/Model/Suppression/Bounce/IndexResponse.php b/src/Model/Suppression/Bounce/IndexResponse.php index 5eb1db5..0cf22bd 100644 --- a/src/Model/Suppression/Bounce/IndexResponse.php +++ b/src/Model/Suppression/Bounce/IndexResponse.php @@ -38,7 +38,6 @@ final class IndexResponse implements ApiResponse, PagingProvider } $model = new self(); - $model->items = $bounces; $model->paging = $data['paging']; diff --git a/src/Model/Suppression/Complaint/Complaint.php b/src/Model/Suppression/Complaint/Complaint.php index 5e5d4f1..01a2fd4 100644 --- a/src/Model/Suppression/Complaint/Complaint.php +++ b/src/Model/Suppression/Complaint/Complaint.php @@ -26,7 +26,6 @@ class Complaint public static function create(array $data): self { $model = new self(); - $model->address = $data['address'] ?? null; $model->createdAt = isset($data['created_at']) ? new \DateTimeImmutable($data['created_at']) : null; diff --git a/src/Model/Suppression/Complaint/IndexResponse.php b/src/Model/Suppression/Complaint/IndexResponse.php index 9320b14..268ff21 100644 --- a/src/Model/Suppression/Complaint/IndexResponse.php +++ b/src/Model/Suppression/Complaint/IndexResponse.php @@ -38,7 +38,6 @@ final class IndexResponse implements ApiResponse, PagingProvider } $model = new self(); - $model->items = $complaints; $model->paging = $data['paging']; diff --git a/src/Model/Suppression/Unsubscribe/IndexResponse.php b/src/Model/Suppression/Unsubscribe/IndexResponse.php index 683bd5d..7c4403f 100644 --- a/src/Model/Suppression/Unsubscribe/IndexResponse.php +++ b/src/Model/Suppression/Unsubscribe/IndexResponse.php @@ -55,7 +55,6 @@ final class IndexResponse implements ApiResponse, PagingProvider } $model = new self(); - $model->items = $unsubscribes; $model->paging = $data['paging']; diff --git a/src/Model/Suppression/Unsubscribe/Unsubscribe.php b/src/Model/Suppression/Unsubscribe/Unsubscribe.php index 0cbc4e7..0db8e88 100644 --- a/src/Model/Suppression/Unsubscribe/Unsubscribe.php +++ b/src/Model/Suppression/Unsubscribe/Unsubscribe.php @@ -27,14 +27,10 @@ class Unsubscribe public static function create(array $data): self { $model = new self(); - + $model->tags = $data['tags'] ?? []; $model->address = $data['address'] ?? null; $model->createdAt = isset($data['created_at']) ? new \DateTimeImmutable($data['created_at']) : null; - if (isset($data['tags'])) { - $model->tags = $data['tags']; - } - return $model; } diff --git a/src/Model/Tag/IndexResponse.php b/src/Model/Tag/IndexResponse.php index 7eb47b6..31e75dd 100644 --- a/src/Model/Tag/IndexResponse.php +++ b/src/Model/Tag/IndexResponse.php @@ -39,7 +39,6 @@ final class IndexResponse implements ApiResponse, PagingProvider } $model = new self(); - $model->items = $items; $model->paging = $data['paging']; diff --git a/src/Model/Tag/UpdateResponse.php b/src/Model/Tag/UpdateResponse.php index 4a9447d..ba2cb77 100644 --- a/src/Model/Tag/UpdateResponse.php +++ b/src/Model/Tag/UpdateResponse.php @@ -27,8 +27,9 @@ final class UpdateResponse implements ApiResponse public static function create(array $data): self { $model = new self(); - $model->message = $data['message'] ?? ''; + + return $model; } public function getMessage(): string