diff --git a/src/Mailgun/Mailgun.php b/src/Mailgun/Mailgun.php index 12816b6..e183ec7 100644 --- a/src/Mailgun/Mailgun.php +++ b/src/Mailgun/Mailgun.php @@ -17,7 +17,7 @@ use Mailgun\Messages\MessageBuilder; */ class Mailgun{ - + protected $workingDomain; protected $restClient; @@ -43,12 +43,12 @@ class Mailgun{ fwrite($fileHandle, $postFiles); $result = $this->post("$workingDomain/messages.mime", $postData, array("message" => $tempFile)); - fclose($fileName); - unlink($fileName); + fclose($fileHandle); + unlink($tempFile); return $result; } else{ - throw new Exceptions\git (EXCEPTION_MISSING_REQUIRED_MIME_PARAMETERS); + throw new Exceptions\MissingRequiredMIMEParameters(EXCEPTION_MISSING_REQUIRED_MIME_PARAMETERS); } } diff --git a/tests/Mailgun/Tests/Messages/BatchMessageTest.php b/tests/Mailgun/Tests/Messages/BatchMessageTest.php index f8e9d5a..8e4e5ae 100644 --- a/tests/Mailgun/Tests/Messages/BatchMessageTest.php +++ b/tests/Mailgun/Tests/Messages/BatchMessageTest.php @@ -115,6 +115,35 @@ class BatchMessageTest extends \Mailgun\Tests\MailgunTestCase{ $this->assertEquals(array("1234"), $message->getMessageIds()); } + + public function testInvalidMissingRequiredMIMEParametersExceptionGetsFlungNoFrom() + { + $this->setExpectedException("\\Mailgun\\Messages\\Exceptions\\MissingRequiredMIMEParameters"); + + $message = $this->client->BatchMessage($this->sampleDomain); + $message->sendMessage([1,2,3]); + } + public function testInvalidMissingRequiredMIMEParametersExceptionGetsFlungNoTo() + { + $this->setExpectedException("\\Mailgun\\Messages\\Exceptions\\MissingRequiredMIMEParameters"); + + $message = $this->client->BatchMessage($this->sampleDomain); + $message->sendMessage(["from" => 1, 2,3]); + } + public function testInvalidMissingRequiredMIMEParametersExceptionGetsFlungNoSubject() + { + $this->setExpectedException("\\Mailgun\\Messages\\Exceptions\\MissingRequiredMIMEParameters"); + + $message = $this->client->BatchMessage($this->sampleDomain); + $message->sendMessage(["from" => 1, "to" => 2,3]); + } + public function testInvalidMissingRequiredMIMEParametersExceptionGetsFlungNoTextOrHtml() + { + $this->setExpectedException("\\Mailgun\\Messages\\Exceptions\\MissingRequiredMIMEParameters"); + + $message = $this->client->BatchMessage($this->sampleDomain); + $message->sendMessage(["from" => 1,"to" => 2,"subject" => 3]); + } } ?>