RetailCRM-Mirror/mailgun-php
1
0
Fork 0
mirror of https://github.com/retailcrm/mailgun-php.git synced 2024-11-25 14:26:04 +03:00
Code Issues Projects Releases Wiki Activity

Correct config file (#837)

Browse Source 
Test

Test

Test

Test

Test

Test

Test

Ignore errors

Ignore errors

Ignore errors

Webhook is still using ClientInterface type declaration #783
This commit is contained in:
Oleksandr Mykhailenko 2022-08-27 18:39:53 +03:00 committed by GitHub
parent 30fe24de74
commit 62bd235af7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 23 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
roave-bc-check.yaml Normal file
View File

@ -0,0 +1,4 @@
parameters:
ignoreErrors:
- '#Mailgun\\Api\\Webhook#'
- '#Mailgun\\Api\\Suppression#'

13
src/Api/HttpApi.php
View File

@ -11,7 +11,6 @@ declare(strict_types=1);
namespace Mailgun\Api;
use Http\Client\Common\PluginClient;
use Mailgun\Exception\HttpClientException;
use Mailgun\Exception\HttpServerException;
use Mailgun\Exception\UnknownErrorException;
@ -31,7 +30,7 @@ abstract class HttpApi
/**
* The HTTP client.
*
* @var ClientInterface|PluginClient
* @var ClientInterface
*/
protected $httpClient;
@ -45,13 +44,13 @@ abstract class HttpApi
*/
protected $requestBuilder;
/**
* @param ClientInterface $httpClient
* @param RequestBuilder $requestBuilder
* @param Hydrator $hydrator
*/
public function __construct($httpClient, RequestBuilder $requestBuilder, Hydrator $hydrator)
{
if (!is_a($httpClient, ClientInterface::class) &&
!is_a($httpClient, PluginClient::class)) {
throw new \RuntimeException('httpClient must be an instance of
Psr\Http\Client\ClientInterface or Http\Client\Common\PluginClient');
}
$this->httpClient = $httpClient;
$this->requestBuilder = $requestBuilder;
if (!$hydrator instanceof NoopHydrator) {

7
src/Api/Suppression.php
View File

@ -41,7 +41,12 @@ class Suppression
*/
private $hydrator;
public function __construct(ClientInterface $httpClient, RequestBuilder $requestBuilder, Hydrator $hydrator)
/**
* @param ClientInterface $httpClient
* @param RequestBuilder $requestBuilder
* @param Hydrator $hydrator
*/
public function __construct($httpClient, RequestBuilder $requestBuilder, Hydrator $hydrator)
{
$this->httpClient = $httpClient;
$this->requestBuilder = $requestBuilder;

8
src/Api/Webhook.php
View File

@ -34,7 +34,13 @@ class Webhook extends HttpApi
*/
private $apiKey;
public function __construct(ClientInterface $httpClient, RequestBuilder $requestBuilder, Hydrator $hydrator, string $apiKey)
/**
* @param ClientInterface $httpClient
* @param RequestBuilder $requestBuilder
* @param Hydrator $hydrator
* @param string $apiKey
*/
public function __construct($httpClient, RequestBuilder $requestBuilder, Hydrator $hydrator, string $apiKey)
{
parent::__construct($httpClient, $requestBuilder, $hydrator);
$this->apiKey = $apiKey;