RetailCRM-Mirror/mailgun-php
1
0
Fork 0
mirror of https://github.com/retailcrm/mailgun-php.git synced 2025-02-21 15:23:15 +03:00
Code Issues Projects Releases Wiki Activity

Fixed errors on member adding with nullable name

Browse Source
This commit is contained in:
Vasilii Zolotukhin 2019-09-18 16:15:07 +10:00 committed by David Garcia
parent e7c913a17b
commit 4a65f16f63
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/Api/MailingList/Member.php
View File

@ -99,12 +99,15 @@ class Member extends HttpApi
$params = [ $params = [
'address' => $address, 'address' => $address,
'name' => $name,
'vars' => \json_encode($vars), 'vars' => \json_encode($vars),
'subscribed' => $subscribed ? 'yes' : 'no', 'subscribed' => $subscribed ? 'yes' : 'no',
'upsert' => $upsert ? 'yes' : 'no', 'upsert' => $upsert ? 'yes' : 'no',
]; ];
if (null !== $name) {
$params['name'] = $name;
}
$response = $this->httpPost(sprintf('/v3/lists/%s/members', $list), $params); $response = $this->httpPost(sprintf('/v3/lists/%s/members', $list), $params);
return $this->hydrateResponse($response, CreateResponse::class); return $this->hydrateResponse($response, CreateResponse::class);
@ -200,9 +203,12 @@ class Member extends HttpApi
// We should assert that "vars"'s $value is a string. // We should assert that "vars"'s $value is a string.
// no break // no break
case 'address': case 'address':
case 'name':
Assert::stringNotEmpty($value); Assert::stringNotEmpty($value);
break;
case 'name':
Assert::nullOrStringNotEmpty($value);
break; break;
case 'subscribed': case 'subscribed':
Assert::oneOf($value, ['yes', 'no']); Assert::oneOf($value, ['yes', 'no']);
@ -211,6 +217,10 @@ class Member extends HttpApi
} }
} }
if (null === $parameters['name']) {
unset($parameters['name']);
}
$response = $this->httpPut(sprintf('/v3/lists/%s/members/%s', $list, $address), $parameters); $response = $this->httpPut(sprintf('/v3/lists/%s/members/%s', $list, $address), $parameters);
return $this->hydrateResponse($response, UpdateResponse::class); return $this->hydrateResponse($response, UpdateResponse::class);