RetailCRM-Mirror/mailgun-php
1
0
Fork 0
mirror of https://github.com/retailcrm/mailgun-php.git synced 2024-11-29 00:25:37 +03:00
Code Issues Projects Releases Wiki Activity

Revise domain creation assertions and add tests

Browse Source 
Based on feedback from @DavidGarciaCat.
This commit is contained in:
Nathan Perkins 2019-08-27 22:59:58 -06:00 committed by David Garcia
parent c9bbf8e45f
commit 2db0619d8a
2 changed files with 31 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Api/Domain.php
View File

@ -90,12 +90,11 @@ class Domain extends HttpApi
if (!empty($smtpPass)) { if (!empty($smtpPass)) {
Assert::stringNotEmpty($smtpPass); Assert::stringNotEmpty($smtpPass);
Assert::lengthBetween($smtpPass, 5, 32, 'SMTP password must be between 5 and 32 characters.');
$params['smtp_password'] = $smtpPass; $params['smtp_password'] = $smtpPass;
} }
if (null !== $spamAction) { if (!empty($spamAction)) {
// TODO(sean.johnson): Extended spam filter input validation. // TODO(sean.johnson): Extended spam filter input validation.
Assert::stringNotEmpty($spamAction); Assert::stringNotEmpty($spamAction);

30
tests/Api/DomainTest.php
View File

@ -85,6 +85,20 @@ JSON
} }
public function testCreateWithPassword() public function testCreateWithPassword()
{
$this->setRequestMethod('POST');
$this->setRequestUri('/v3/domains');
$this->setRequestBody([
'name' => 'example.com',
'smtp_password' => 'foo',
]);
$this->setHydrateClass(CreateResponse::class);
$api = $this->getApiInstance();
$api->create('example.com', 'foo');
}
public function testCreateWithPasswordSpamAction()
{ {
$this->setRequestMethod('POST'); $this->setRequestMethod('POST');
$this->setRequestUri('/v3/domains'); $this->setRequestUri('/v3/domains');
@ -95,6 +109,22 @@ JSON
]); ]);
$this->setHydrateClass(CreateResponse::class); $this->setHydrateClass(CreateResponse::class);
$api = $this->getApiInstance();
$api->create('example.com', 'foo', 'bar');
}
public function testCreateWithPasswordSpamActionWildcard()
{
$this->setRequestMethod('POST');
$this->setRequestUri('/v3/domains');
$this->setRequestBody([
'name' => 'example.com',
'smtp_password' => 'foo',
'spam_action' => 'bar',
'wildcard' => 'true',
]);
$this->setHydrateClass(CreateResponse::class);
$api = $this->getApiInstance(); $api = $this->getApiInstance();
$api->create('example.com', 'foo', 'bar', true); $api->create('example.com', 'foo', 'bar', true);
} }