PHPDoc typos fixed, minor performance changes

src/Mailgun/Connection/RestClient.php

@@ -197,22 +197,30 @@ class RestClient
      */
     public function responseHandler(ResponseInterface $responseObj)
     {
-        $httpResponseCode = $responseObj->getStatusCode();
+        $httpResponseCode = (int)$responseObj->getStatusCode();
-        if ($httpResponseCode === 200) {
+
-            $data = (string) $responseObj->getBody();
+        switch ($httpResponseCode) {
-            $jsonResponseData = json_decode($data, false);
+            case 200:
-            $result = new \stdClass();
+                $data = (string)$responseObj->getBody();
-            // return response data as json if possible, raw if not
+                $jsonResponseData = json_decode($data, false);
-            $result->http_response_body = $data && $jsonResponseData === null ? $data : $jsonResponseData;
+                $result = new \stdClass();
-        } elseif ($httpResponseCode == 400) {
+                // return response data as json if possible, raw if not
-            throw new MissingRequiredParameters(ExceptionMessages::EXCEPTION_MISSING_REQUIRED_PARAMETERS.$this->getResponseExceptionMessage($responseObj));
+                $result->http_response_body = $data && $jsonResponseData === null ? $data : $jsonResponseData;
-        } elseif ($httpResponseCode == 401) {
+                break;
-            throw new InvalidCredentials(ExceptionMessages::EXCEPTION_INVALID_CREDENTIALS);
+            case 400:
-        } elseif ($httpResponseCode == 404) {
+                throw new MissingRequiredParameters(ExceptionMessages::EXCEPTION_MISSING_REQUIRED_PARAMETERS . $this->getResponseExceptionMessage($responseObj));
-            throw new MissingEndpoint(ExceptionMessages::EXCEPTION_MISSING_ENDPOINT.$this->getResponseExceptionMessage($responseObj));
+                break;
-        } else {
+            case 401:
-            throw new GenericHTTPError(ExceptionMessages::EXCEPTION_GENERIC_HTTP_ERROR, $httpResponseCode, $responseObj->getBody());
+                throw new InvalidCredentials(ExceptionMessages::EXCEPTION_INVALID_CREDENTIALS);
+                break;
+            case 404:
+                throw new MissingEndpoint(ExceptionMessages::EXCEPTION_MISSING_ENDPOINT . $this->getResponseExceptionMessage($responseObj));
+                break;
+            default:
+                throw new GenericHTTPError(ExceptionMessages::EXCEPTION_GENERIC_HTTP_ERROR, $httpResponseCode, $responseObj->getBody());
+                break;
         }
+
         $result->http_response_code = $httpResponseCode;
 
         return $result;
@@ -230,6 +238,8 @@ class RestClient
         if (json_last_error() == JSON_ERROR_NONE && isset($response->message)) {
             return ' '.$response->message;
         }
+
+        return '';
     }
 
     /**
@@ -237,6 +247,8 @@ class RestClient
      *
      * @param string       $fieldName
      * @param string|array $filePath
+     *
+     * @return array
      */
     protected function prepareFile($fieldName, $filePath)
     {
@@ -293,11 +305,7 @@ class RestClient
      */
     private function generateEndpoint($apiEndpoint, $apiVersion, $ssl)
     {
-        if (!$ssl) {
+        return ($ssl ? 'https://' : 'http://') . $apiEndpoint . '/' . $apiVersion . '/';
-            return 'http://'.$apiEndpoint.'/'.$apiVersion.'/';
-        } else {
-            return 'https://'.$apiEndpoint.'/'.$apiVersion.'/';
-        }
     }
 
     /**

src/Mailgun/Mailgun.php

@@ -50,6 +50,8 @@ class Mailgun{
      * @param string $workingDomain
      * @param array $postData
      * @param array $postFiles
+     *
+     * @return \stdClass
      * @throws Exceptions\MissingRequiredMIMEParameters
      */
     public function sendMessage($workingDomain, $postData, $postFiles = array()){
@@ -86,7 +88,7 @@ class Mailgun{
      * @return bool
      */
     public function verifyWebhookSignature($postData = NULL) {
-        if(is_null($postData)) {
+        if($postData === null) {
             $postData = $_POST;
         }
         $hmac = hash_hmac('sha256', "{$postData["timestamp"]}{$postData["token"]}", $this->apiKey);

src/Mailgun/Messages/MessageBuilder.php

@@ -276,11 +276,13 @@ class MessageBuilder
     /**
      * @param string $inlineImagePath
      * @param string|null $inlineImageName
+     *
+     * @return bool|true
      * @throws InvalidParameter
      */
     public function addInlineImage($inlineImagePath, $inlineImageName = null)
     {
-        if (preg_match("/^@/", $inlineImagePath)) {
+        if (strpos($inlineImagePath, '@') === 0) {
             if (isset($this->files['inline'])) {
                 $inlineAttachment = array(
                     'filePath'   => $inlineImagePath,