RetailCRM-Mirror/mailgun-php
1
0
Fork 0
mirror of https://github.com/retailcrm/mailgun-php.git synced 2025-02-06 00:09:24 +03:00
Code Issues Projects Releases Wiki Activity

fix: Validate file name length (#463)

Browse Source 
* fix: Validate file name length

$message could contain a large email text that if sent to is_file it could break with this error:
` is_file(): File name is longer than the maximum allowed path `
This validation prevents using is_file if the $message is longer than the allowed path.

* style: Fix extra space

* Added a small test

* cs

* cs
This commit is contained in:
Matias Barletta 2019-01-05 08:44:50 -03:00 committed by Tobias Nyholm
parent 7b24312f6c
commit 07da83776a
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Mailgun/Api/Message.php
View File

@ -82,7 +82,7 @@ class Message extends HttpApi
$params['to'] = $recipients;
$postDataMultipart = $this->prepareMultipartParameters($params);
if (is_file($message)) {
if (strlen($message) < PHP_MAXPATHLEN && is_file($message)) {
$fileData = ['filePath' => $message];
} else {
$fileData = [

11
tests/Api/MessageTest.php
View File

@ -111,6 +111,17 @@ class MessageTest extends TestCase
$api->show('url', true);
}
public function testSendMimeWithLongMessage()
{
$api = $this->getApiMock();
$api->expects($this->once())
->method('httpPostRaw')
->willReturn(new Response());
$message = str_repeat('a', PHP_MAXPATHLEN).' and some more';
$api->sendMime('foo', ['mailbox@myapp.com'], $message, []);
}
/**
* {@inheritdoc}
*/