RetailCRM-Mirror/magento-module
1
0
Fork 0
mirror of synced 2024-11-24 14:06:07 +03:00
Code Issues Projects Releases Wiki Activity

Merge pull request #21 from iyzoer/master

Browse Source 
Fixes for marketplace
This commit is contained in:
Alex Lushpai 2019-01-24 16:11:07 +03:00 committed by GitHub
commit fd2524b207
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Model/Icml/Icml.php
View File

@ -19,8 +19,7 @@ class Icml
private $resourceModelProduct; private $resourceModelProduct;
private $searchCriteriaBuilder; private $searchCriteriaBuilder;
private $productRepository; private $productRepository;
private $dimensionFields = ['height', 'length', 'width'];
const DIMENSION_FIELDS = ['height', 'length', 'width'];
public function __construct( public function __construct(
\Magento\Store\Model\StoreManagerInterface $manager, \Magento\Store\Model\StoreManagerInterface $manager,
@ -444,7 +443,7 @@ class Icml
*/ */
private function checkDimension($attrCode) private function checkDimension($attrCode)
{ {
foreach (self::DIMENSION_FIELDS as $dimensionField) { foreach ($this->dimensionFields as $dimensionField) {
if (mb_strpos($attrCode, $dimensionField) !== false) { if (mb_strpos($attrCode, $dimensionField) !== false) {
return [$dimensionField => $attrCode]; return [$dimensionField => $attrCode];
} }

2
src/Test/Unit/Block/Frontend/DaemonCollectorTest.php
View File

@ -1,5 +1,7 @@
<?php <?php
namespace Retailcrm\Retailcrm\Test\Unit\Block\Frontend;
class DaemonCollectorTest extends \PHPUnit\Framework\TestCase class DaemonCollectorTest extends \PHPUnit\Framework\TestCase
{ {
private $unit; private $unit;