Vladimir Razuvaev
918bbff2bd
Merge branch 'master' into no-parsing
2018-01-13 17:20:00 +07:00
Vladimir Razuvaev
9944a689bf
Exclude nulls from serialized AST
2018-01-13 16:25:06 +07:00
Vladimir Razuvaev
8b17953fe5
Fixed bug preventing use of parser noLocation option for serialization / deserialization
2018-01-13 15:45:09 +07:00
Vladimir Razuvaev
7c3737609f
Doc-block fix
2018-01-01 22:12:51 +07:00
Adrien Crivelli
178b179db3
Drop support non pre-parsed PSR-7 request body
...
This revert #202 (commit 9d37f4c
) because trying to parse PSR-7 request
was a mistake. The whole point of PSR-7 is to allow for interoperability
and be able to use specialized libs for body parsing (amongst many other
things). Trying to parse ourselves would be opening a can of worm if/when
other content types have to be supported. It is more correct and future
safe to require that the body is parsed before being passed to GraphQL.
2017-12-21 15:01:57 +09:00
Jáchym Toušek
25e341e9d9
Allow objects with __toString in IDType
2017-12-12 08:56:03 +01:00
Vladimir Razuvaev
9c563d5c00
Merge pull request #199 from roippi/findbreakingchanges
...
port findBreakingChanges
2017-11-28 20:14:36 +07:00
Vladimir Razuvaev
0af2fe79f2
StandardServer: a bit more validation for parsed json PSR-7 request (related to #202 )
2017-11-28 12:28:54 +07:00
Adrien Crivelli
11c9429fab
Support non pre-parsed PSR-7 request body
...
Because PSR-7 specification only specify that `getParsedBody()` **may**
return the parsed body for `application/json`, we cannot assume that it
is always the case. So if the value returned parsed body is an empty array,
it means we should try to parse it ourselves (`null` would mean no body at
all according to spec).
With this modification we try to used given parsed body, but fallback on
trying to parse the body if necessary. This leave the door open to custom
implementation of parsing if needed, while making it easier to use out of
the box.
2017-11-26 19:57:32 +09:00
Ben Roberts
533b8b8b5f
testDetectsAdditionsToUnionType
2017-11-21 12:18:28 -05:00
Ben Roberts
c4ae03454a
testFindDangerousArgChanges
2017-11-21 11:50:11 -05:00
Ben Roberts
dbccf9b196
testDetectsRemovalOfInterfaces
2017-11-20 14:39:06 -05:00
Ben Roberts
0fd5abc833
testDetectsAdditionOfFieldArg
2017-11-20 13:48:21 -05:00
Ben Roberts
42d8ac07f9
testDetectsFieldArgumentTypeChange
2017-11-20 12:52:49 -05:00
Ben Roberts
4ea6cbe839
bugfix var ref
2017-11-17 17:35:33 -05:00
Ben Roberts
fc9c5e85aa
testDetectsRemovalOfFieldArgument
2017-11-17 17:18:26 -05:00
Ben Roberts
cac011246e
testDetectsValuesRemovedFromEnum
2017-11-17 16:24:04 -05:00
Ben Roberts
98ce1ccc69
testDetectsIfTypeWasRemovedFromUnion
2017-11-17 16:08:44 -05:00
Ben Roberts
dde2747918
testDetectsNonNullFieldAddedToInputType
2017-11-17 15:56:53 -05:00
Ben Roberts
cf4cccf4d6
testShouldDetectInputFieldChanges
2017-11-17 15:43:16 -05:00
Ben Roberts
68dbcc9ca3
testShouldDetectFieldChangesAndDeletions test
2017-11-17 14:29:47 -05:00
Ben Roberts
b2b5d6f080
findTypesThatChangedKind test
2017-11-17 13:04:01 -05:00
Ben Roberts
d9ce567cc8
findRemovedTypes test
2017-11-17 11:21:05 -05:00
Ben Roberts
4207adc098
change fns to static
2017-11-17 10:54:18 -05:00
Ben Roberts
6bdb7b7f80
improve docstrings
2017-11-16 17:44:08 -05:00
Ben Roberts
af60f1ee4d
finish mechanical conversions
2017-11-16 17:42:38 -05:00
Ben Roberts
a1325eeb3f
top level API functions, docstrings
2017-11-16 15:53:20 -05:00
Ben Roberts
55f6d6cf47
interfaces and enums
2017-11-16 15:25:25 -05:00
Ben Roberts
6e95b81aee
dangerous changes consts
2017-11-16 14:17:21 -05:00
Ben Roberts
e649ef307a
couple more functions
2017-11-16 14:15:39 -05:00
Ben Roberts
3811181f49
some functions converted over
2017-11-16 13:53:01 -05:00
Ben Roberts
7aebf2dbf7
initial porting
2017-11-15 16:12:56 -05:00
Vladimir Razuvaev
1487741f37
Preserve description for custom scalars ( #181 )
2017-10-14 00:45:23 +07:00
Vladimir Razuvaev
f7248dec76
Ability to override internal types (using types
option of Schema class) #174
2017-09-22 23:08:51 +07:00
Vladimir Razuvaev
c5efd1d65b
Additional checks for possible fragment spreads
2017-09-20 19:06:04 +07:00
Vladimir Razuvaev
1e34982bda
Additional tests for variable coercion + use printSafeJson vs printSafe for input variables
2017-09-20 18:40:45 +07:00
Vladimir Razuvaev
a1e06b2e61
Account for query offset in files for errors
2017-09-20 18:36:19 +07:00
Vladimir Razuvaev
6050af4e67
Add support for directives applied on IDL & Schema
2017-09-20 17:43:06 +07:00
Vladimir Razuvaev
5f5c8118c0
Fixed parseValue
of StringType and IDType: (it should return null on invalid value, not throw)
2017-09-20 16:38:02 +07:00
Vladimir Razuvaev
2023b427ae
Fixed failed integer test (only fails on some OSs and PHP versions)
2017-09-20 16:20:51 +07:00
Derek Lavigne
d22385cc93
Update query variable coercion to meet the rules outlined in the
...
specification.
The framework currently coerces query variables similar to the way it
treats output values, which means it attempts to coerce the value into
the field's corresponding data type regardless of the received value.
According to items 3f and 3g in section 6.1.2
(http://facebook.github.io/graphql/#sec-Validating-Requests ) of
Facebook's GraphQL specification query variables should be coerced
according to their type's input coercion rules laid out in section
3.1.1 (http://facebook.github.io/graphql/#sec-Scalars ). If the value
can not be coerced into the correct type according the the input
coercion rules for the type a query error should be thrown. This
ensures that client provided query variables were of the correct format
and will be a valid format and type by the time they are passed into an
implementing resolver.
This patch fixes the above issue by updating the way query variables
are sanitized during the process of parsing the query. It directly
follows the rules for scalar input coercion laid out by the
specification and throws query errors when a value that cannot be
coerced to the correct type is given. Tests for isValidPHPValue will
also be updated to ensure that it is doing the correct type checks on
Values::isValidPHPValue for the given type and value provided. A new
test case will also be added to test Values::getVariableValues and make
sure it is also enforcing the scalar input coercion rules and throwing
errors for invalid values.
2017-09-18 12:14:09 -04:00
Vladimir Razuvaev
6ff427d241
Server: do not raise an error when variables are passed as empty string ( #156 )
2017-08-30 23:26:45 +07:00
Vladimir Razuvaev
d95fb461ee
Server: fixed constructor screwed during rebasing + restored tests for the server
2017-08-21 01:18:23 +07:00
Vladimir Razuvaev
a1652468f0
Fixed minor error in docblock comment
2017-08-21 00:19:07 +07:00
Vladimir Razuvaev
6fdcfd9bb0
Merge branch 'master' of https://github.com/webonyx/graphql-php into v0.10
2017-08-20 23:16:51 +07:00
Vladimir Razuvaev
90602b31ba
Added link to docs for generic error about unique type instance ( #149 )
2017-08-20 22:28:17 +07:00
Vladimir Razuvaev
de791536ce
Docblocks improvements
2017-08-20 22:10:13 +07:00
Vladimir Razuvaev
d5e3d08d85
Minor Executor tweaks
2017-08-20 20:09:55 +07:00
Vladimir Razuvaev
085516bdda
Moved GraphQL\Language\AST\Node::fromArray
to GraphQL\Utils\AST::fromArray
2017-08-20 19:50:44 +07:00
Vladimir Razuvaev
bd444752f8
Documentation and docblock improvements
2017-08-20 16:00:44 +07:00
Vladimir Razuvaev
71343f2f62
Server: Extracted method for emitting response
2017-08-20 02:32:50 +07:00
Vladimir Razuvaev
1b4f983f3f
Improved docblock comments (suitable for reference docs generation)
2017-08-19 23:01:46 +07:00
Jeremiah VALERIE
1c143360ca
Add hooks to helps promise completion with custom backend
2017-08-18 16:18:48 +02:00
Vladimir Razuvaev
203fddfe4e
Abstract base class for validation rules
2017-08-18 20:56:04 +07:00
Vladimir Razuvaev
9499e5ae8e
Suppressing Config deprecation warning in tests
2017-08-18 18:07:23 +07:00
Vladimir Razuvaev
2bfce65484
Fixed Parser docblock comments
2017-08-18 02:55:22 +07:00
Vladimir Razuvaev
83cc9132a0
Server: minor improvements
2017-08-18 02:54:35 +07:00
Vladimir Razuvaev
d578b8a22f
Split sync and async facade methods
2017-08-18 01:49:10 +07:00
Vladimir Razuvaev
e52fe8c384
BuildSchema::build() now accepts DocumentNode as well
2017-08-17 20:33:36 +07:00
Vladimir Razuvaev
03629c1e3c
Refactored error formatting (debugging part)
2017-08-17 18:49:17 +07:00
Vladimir Razuvaev
1d38643538
Ability to re-throw resolver exceptions
2017-08-17 03:01:23 +07:00
Vladimir Razuvaev
51e877bfba
Improving docblock comments
2017-08-17 02:15:49 +07:00
Vladimir Razuvaev
b4d767bad6
Moved typeFromAST() to AST util
2017-08-17 02:14:55 +07:00
Vladimir Razuvaev
a50c9a4c1f
Renamed error category constants
2017-08-17 02:13:44 +07:00
Vladimir Razuvaev
4634f214ea
Revamping GraphQL facade methods
2017-08-17 02:12:37 +07:00
Vladimir Razuvaev
b56083b7de
Improved flexibility of error handling
2017-08-17 02:11:21 +07:00
Vladimir Razuvaev
1ee226465b
Server: added missing error message
2017-08-16 19:22:45 +07:00
Vladimir Razuvaev
f369d4e2d4
Reverted unnecessary breaking change
2017-08-15 23:39:07 +07:00
Vladimir Razuvaev
3971001f6d
Server: additional tests + related fixes
2017-08-15 20:59:48 +07:00
Vladimir Razuvaev
828c6b0fc3
Server: disable query batching by default; allow array as server config
2017-08-15 18:05:09 +07:00
Vladimir Razuvaev
9931cde6d4
Tests for lazy type loading during query execution + related changed
2017-08-15 01:49:56 +07:00
Vladimir Razuvaev
e4813c3a05
Additional checks and tests for situations when user-land code returns duplicate type instances
2017-08-14 23:52:17 +07:00
Vladimir Razuvaev
8817d54e83
Validate that type loader always returns the same type instance as referenced in other parts of the schema
2017-08-14 22:32:07 +07:00
Vladimir Razuvaev
b9d3a11785
Extracted lazy schema test; minor related refactoring
2017-08-14 20:41:08 +07:00
Vladimir Razuvaev
f47db61907
Fully load all schema types in constructor when type loader is not set
2017-08-14 19:44:16 +07:00
Vladimir Razuvaev
884a8967f3
Type loader tests
2017-08-14 19:42:01 +07:00
Vladimir Razuvaev
20f8cab943
Removed schema descriptor (as lazy loading of types can work without it now)
2017-08-14 01:42:02 +07:00
Vladimir Razuvaev
f9eb14869f
Removed callbacks in field types (previously deprecated in #35 )
2017-08-14 00:50:24 +07:00
Vladimir Razuvaev
6845b28a35
Deprecated GraphQL\Type\Definition\Config
( #148 )
2017-08-14 00:09:02 +07:00
Vladimir Razuvaev
34eae0b891
Schema validation + tests ( #148 )
2017-08-13 23:04:03 +07:00
Vladimir Razuvaev
d3580e959e
Moved Schema to GraphQL\Type namespace (but preserved BC)
2017-08-12 21:40:03 +07:00
Vladimir Razuvaev
f911fac7b1
Default error reporting now includes "category" key for every error
2017-08-08 02:02:07 +07:00
Vladimir Razuvaev
09070485c1
Added ability to decorate type configs in BuildSchema + made type creation lazy
2017-07-28 17:55:25 +07:00
Vladimir Razuvaev
3a8301f6c6
Allow types
schema option to be callable
2017-07-28 17:53:57 +07:00
Vladimir Razuvaev
6a20483b87
Server: Ability to use thunk for root value and context
2017-07-27 20:11:45 +07:00
Vladimir Razuvaev
e7838d2253
Do not output trace for trivial errors even in debug mode
2017-07-25 20:08:34 +07:00
Vladimir Razuvaev
3e6f2c9e83
Fixed minor bugs
2017-07-25 19:26:41 +07:00
Vladimir Razuvaev
1af902865b
AST: new NodeList
class for collections of nodes (vs array) to enable effective conversion of libgraphqlparser output to our AST tree
2017-07-21 22:29:59 +07:00
Vladimir Razuvaev
e04d3300a7
Server: send result for regular responses + prepare response for PSR7 request
2017-07-21 22:11:20 +07:00
Vladimir Razuvaev
b2ec265d4f
Server: ability to execute PSR7 request
2017-07-19 23:35:22 +07:00
Vladimir Razuvaev
87c812b221
Better located error handling
2017-07-19 20:08:42 +07:00
Vladimir Razuvaev
81986145fe
Server: moving things around to simplify
2017-07-19 19:55:22 +07:00
Vladimir Razuvaev
08a68d4857
Throwing GraphQL\Error\Error
vs GraphQL\Error\UserError
from type definitions
2017-07-19 19:39:10 +07:00
Vladimir Razuvaev
e6e531b88b
Server: throw only when there is a configuration or logic error (invariant violation)
2017-07-19 19:30:39 +07:00
Vladimir Razuvaev
38922dbbed
Default error formatter now returns "Internal server error" unless error is client-aware and safe to report directly to end-users
2017-07-18 20:57:30 +07:00
Vladimir Razuvaev
fbcd20814a
Scalar type serialize
method now throws InvariantViolation
and parseValue
throws UserError
2017-07-18 20:52:39 +07:00
Vladimir Razuvaev
8e3d1eb29b
Merge branch 'master' of https://github.com/webonyx/graphql-php into v0.10
2017-07-18 00:42:52 +07:00
Vladimir Razuvaev
8fe26a1a21
String and ID types should not try to convert non-scalar values to string ( #121 )
2017-07-18 00:25:45 +07:00
Vladimir Razuvaev
49208d758d
Server: use proper batching helper
2017-07-17 23:48:30 +07:00
Vladimir Razuvaev
919cf80240
Server: batched queries with shared deferreds (promises) #105
2017-07-17 20:31:26 +07:00