From 7249e2611a4ec63b804dffd081f8c8a6b49eb86b Mon Sep 17 00:00:00 2001 From: Mark Huot Date: Sun, 11 Nov 2018 07:59:45 -0500 Subject: [PATCH 1/2] Fix possessive its vs contraction it's --- src/Executor/Executor.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Executor/Executor.php b/src/Executor/Executor.php index 4804b95..876514c 100644 --- a/src/Executor/Executor.php +++ b/src/Executor/Executor.php @@ -1202,7 +1202,7 @@ class Executor if ($abstractType instanceof InterfaceType && $info->schema->getConfig()->typeLoader) { Warning::warnOnce( sprintf( - 'GraphQL Interface Type `%s` returned `null` from it`s `resolveType` function ' . + 'GraphQL Interface Type `%s` returned `null` from its `resolveType` function ' . 'for value: %s. Switching to slow resolution method using `isTypeOf` ' . 'of all possible implementations. It requires full schema scan and degrades query performance significantly. ' . ' Make sure your `resolveType` always returns valid implementation or throws.', From 4811cd198f944a3a751f2b08322ebf2935495c3b Mon Sep 17 00:00:00 2001 From: Mark Huot Date: Mon, 19 Nov 2018 09:13:57 -0500 Subject: [PATCH 2/2] Fixing test for possessive/contraction "its" change --- tests/Executor/ExecutorLazySchemaTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Executor/ExecutorLazySchemaTest.php b/tests/Executor/ExecutorLazySchemaTest.php index 7779715..245b95d 100644 --- a/tests/Executor/ExecutorLazySchemaTest.php +++ b/tests/Executor/ExecutorLazySchemaTest.php @@ -154,7 +154,7 @@ class ExecutorLazySchemaTest extends TestCase self::assertInstanceOf(Error::class, $result->errors[0]->getPrevious()); self::assertEquals( - 'GraphQL Interface Type `Pet` returned `null` from it`s `resolveType` function for value: instance of ' . + 'GraphQL Interface Type `Pet` returned `null` from its `resolveType` function for value: instance of ' . 'GraphQL\Tests\Executor\TestClasses\Dog. Switching to slow resolution method using `isTypeOf` of all possible ' . 'implementations. It requires full schema scan and degrades query performance significantly. ' . 'Make sure your `resolveType` always returns valid implementation or throws.',