RetailCRM-Mirror/graphql-php
1
0
Fork 0
mirror of https://github.com/retailcrm/graphql-php.git synced 2024-11-22 04:46:04 +03:00
Code Issues Projects Releases Wiki Activity

Return stdClass vs empty array for empty ObjectType values (see #59)

Browse Source
This commit is contained in:
vladar 2016-10-22 17:11:03 +07:00
parent d41687913a
commit a612b780c9
2 changed files with 86 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Executor/Executor.php
View File

@ -96,7 +96,7 @@ class Executor
$data = null;
}
return new ExecutionResult($data, $exeContext->errors);
return new ExecutionResult((array) $data, $exeContext->errors);
}
/**
@ -231,7 +231,11 @@ class Executor
$results[$responseName] = $result;
}
}
return $results;
// see #59
if ([] === $results) {
$results = new \stdClass();
}
return $results;
}
/**

80
tests/Executor/ExecutorTest.php
View File

@ -840,4 +840,84 @@ class ExecutorTest extends \PHPUnit_Framework_TestCase
$this->assertEquals($expected, $result->toArray());
}
/**
* @see https://github.com/webonyx/graphql-php/issues/59
*/
public function testSerializesToEmptyObjectVsEmptyArray()
{
$iface = null;
$a = new ObjectType([
'name' => 'A',
'fields' => [
'id' => Type::id()
],
'interfaces' => function() use (&$iface) {
return [$iface];
}
]);
$b = new ObjectType([
'name' => 'B',
'fields' => [
'id' => Type::id()
],
'interfaces' => function() use (&$iface) {
return [$iface];
}
]);
$iface = new InterfaceType([
'name' => 'Iface',
'fields' => [
'id' => Type::id()
],
'resolveType' => function($v) use ($a, $b) {
return $v['type'] === 'A' ? $a : $b;
}
]);
$schema = new Schema([
'query' => new ObjectType([
'name' => 'Query',
'fields' => [
'ab' => Type::listOf($iface)
]
]),
'types' => [$a, $b]
]);
$data = [
'ab' => [
['id' => 1, 'type' => 'A'],
['id' => 2, 'type' => 'A'],
['id' => 3, 'type' => 'B'],
['id' => 4, 'type' => 'B']
]
];
$query = Parser::parse('
{
ab {
... on A{
id
}
}
}
');
$result = Executor::execute($schema, $query, $data, null);
$this->assertEquals([
'data' => [
'ab' => [
['id' => '1'],
['id' => '2'],
new \stdClass(),
new \stdClass()
]
]
], $result->toArray());
}
}