RetailCRM-Mirror/graphql-php
1
0
Fork 0
mirror of https://github.com/retailcrm/graphql-php.git synced 2024-11-21 20:36:05 +03:00
Code Issues Projects Releases Wiki Activity

Resolve todo in Boolean coercion, add explanation, update test names to match reference implementation

Browse Source
This commit is contained in:
spawnia 2019-06-23 21:03:17 +02:00
parent 93ccd7351d
commit a34bb68d65
2 changed files with 25 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/Type/Definition/BooleanType.php
View File

@ -20,11 +20,14 @@ class BooleanType extends ScalarType
public $description = 'The `Boolean` scalar type represents `true` or `false`.'; public $description = 'The `Boolean` scalar type represents `true` or `false`.';
/** /**
* @param mixed $value * Coerce the given value to a boolean.
* *
* @return bool * The GraphQL spec leaves this up to the implementations, so we just do what
* PHP does natively to make this intuitive for developers.
*
* @param mixed $value
*/ */
public function serialize($value) public function serialize($value) : bool
{ {
return (bool) $value; return (bool) $value;
} }

34
tests/Type/ScalarSerializationTest.php
View File

@ -13,9 +13,9 @@ class ScalarSerializationTest extends TestCase
{ {
// Type System: Scalar coercion // Type System: Scalar coercion
/** /**
* @see it('serializes output int') * @see it('serializes output as Int')
*/ */
public function testSerializesOutputInt() : void public function testSerializesOutputAsInt() : void
{ {
$intType = Type::int(); $intType = Type::int();
@ -114,9 +114,9 @@ class ScalarSerializationTest extends TestCase
} }
/** /**
* @see it('serializes output float') * @see it('serializes output as Float')
*/ */
public function testSerializesOutputFloat() : void public function testSerializesOutputAsFloat() : void
{ {
$floatType = Type::float(); $floatType = Type::float();
@ -149,9 +149,9 @@ class ScalarSerializationTest extends TestCase
} }
/** /**
* @see it('serializes output strings') * @see it('serializes output as String')
*/ */
public function testSerializesOutputStrings() : void public function testSerializesOutputAsString() : void
{ {
$stringType = Type::string(); $stringType = Type::string();
@ -181,23 +181,27 @@ class ScalarSerializationTest extends TestCase
} }
/** /**
* @see it('serializes output boolean') * @see it('serializes output as Boolean')
*/ */
public function testSerializesOutputBoolean() : void public function testSerializesOutputAsBoolean() : void
{ {
$boolType = Type::boolean(); $boolType = Type::boolean();
self::assertTrue($boolType->serialize('string'));
self::assertFalse($boolType->serialize(''));
self::assertTrue($boolType->serialize('1'));
self::assertTrue($boolType->serialize(1));
self::assertFalse($boolType->serialize(0));
self::assertTrue($boolType->serialize(true)); self::assertTrue($boolType->serialize(true));
self::assertTrue($boolType->serialize(1));
self::assertTrue($boolType->serialize('1'));
self::assertTrue($boolType->serialize('string'));
self::assertFalse($boolType->serialize(false)); self::assertFalse($boolType->serialize(false));
// TODO: how should it behave on '0'? self::assertFalse($boolType->serialize(0));
self::assertFalse($boolType->serialize('0'));
self::assertFalse($boolType->serialize(''));
} }
public function testSerializesOutputID() : void /**
* @see it('serializes output as ID')
*/
public function testSerializesOutputAsID() : void
{ {
$idType = Type::id(); $idType = Type::id();