RetailCRM-Mirror/graphql-php
1
0
Fork 0
mirror of https://github.com/retailcrm/graphql-php.git synced 2025-02-06 07:49:24 +03:00
Code Issues Projects Releases Wiki Activity

Fix Bug in PossibleFragmentSpreads validator

Browse Source 
ref: graphql/graphql-js@7e147a8dd6
This commit is contained in:
Daniel Tschinder 2018-02-13 18:08:05 +01:00
parent 9387548aa1
commit 50cbfb4a44
2 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Validator/Rules/PossibleFragmentSpreads.php
View File

@ -61,7 +61,13 @@ class PossibleFragmentSpreads extends AbstractValidationRule
private function getFragmentType(ValidationContext $context, $name) private function getFragmentType(ValidationContext $context, $name)
{ {
$frag = $context->getFragment($name); $frag = $context->getFragment($name);
return $frag ? TypeInfo::typeFromAST($context->getSchema(), $frag->typeCondition) : null; if ($frag) {
$type = TypeInfo::typeFromAST($context->getSchema(), $frag->typeCondition);
if ($type instanceof CompositeType) {
return $type;
}
}
return null;
} }
private function doTypesOverlap(Schema $schema, CompositeType $fragType, CompositeType $parentType) private function doTypesOverlap(Schema $schema, CompositeType $fragType, CompositeType $parentType)

11
tests/Validator/PossibleFragmentSpreadsTest.php
View File

@ -128,6 +128,17 @@ class PossibleFragmentSpreadsTest extends TestCase
'); ');
} }
/**
* @it ignores incorrect type (caught by FragmentsOnCompositeTypes)
*/
public function testIgnoresIncorrectTypeCaughtByFragmentsOnCompositeTypes()
{
$this->expectPassesRule(new PossibleFragmentSpreads, '
fragment petFragment on Pet { ...badInADifferentWay }
fragment badInADifferentWay on String { name }
');
}
/** /**
* @it different object into object * @it different object into object
*/ */