RetailCRM-Mirror/graphql-php
1
0
Fork 0
mirror of https://github.com/retailcrm/graphql-php.git synced 2024-11-22 12:56:05 +03:00
Code Issues Projects Releases Wiki Activity

Add one more breaking change in 0.12

Browse Source
This commit is contained in:
Daniel Tschinder 2018-06-22 15:45:21 +02:00 committed by GitHub
parent e31947a452
commit 300b58093b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
UPGRADE.md
View File

@ -10,6 +10,23 @@ Exception inside `parseLiteral()`, `parseValue()` and `serialize()`.
Returning null from any of these methods will now be treated as valid result. Returning null from any of these methods will now be treated as valid result.
### Breaking: Custom scalar types parseLiteral() declaration changed
A new parameter was added to `parseLiteral()`, which also needs to be added to any custom scalar type extending from `ScalarType`
Before:
```php
public function parseLiteral($valueNode) {
//custom implementation
}
```
After:
```php
public function parseLiteral($valueNode, array $variables = null) {
//custom implementation
}
```
### Breaking: Descriptions in comments are not used as descriptions by default anymore ### Breaking: Descriptions in comments are not used as descriptions by default anymore
Descriptions now need to be inside Strings or BlockStrings in order to be picked up as Descriptions now need to be inside Strings or BlockStrings in order to be picked up as
description. If you want to keep the old behaviour you can supply the option `commentDescriptions` description. If you want to keep the old behaviour you can supply the option `commentDescriptions`