From afe28da475af1c44acf90e60dd4c4d43abac13fa Mon Sep 17 00:00:00 2001 From: David Mongeau-Petitpas Date: Sun, 9 Aug 2015 14:25:01 -0400 Subject: [PATCH 1/3] Check on ListOfType is on ArrayAccess instead of ArrayObject --- src/Executor/Executor.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Executor/Executor.php b/src/Executor/Executor.php index 377435a..c68f0e2 100644 --- a/src/Executor/Executor.php +++ b/src/Executor/Executor.php @@ -285,7 +285,7 @@ class Executor } /** - * Implements the logic to compute the key of a given field’s entry + * Implements the logic to compute the key of a given field�s entry */ private static function getFieldEntryKey(Field $node) { @@ -430,7 +430,7 @@ class Executor if ($fieldType instanceof ListOfType) { $itemType = $fieldType->getWrappedType(); Utils::invariant( - is_array($result) || $result instanceof \ArrayObject, + is_array($result) || $result instanceof \ArrayAccess, 'User Error: expected iterable, but did not find one.' ); From 7431f2dcc56cc402dd5e3869f550c8ae01094766 Mon Sep 17 00:00:00 2001 From: David Mongeau-Petitpas Date: Sun, 9 Aug 2015 14:26:36 -0400 Subject: [PATCH 2/3] Edit character bug --- src/Executor/Executor.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Executor/Executor.php b/src/Executor/Executor.php index c68f0e2..8f0b300 100644 --- a/src/Executor/Executor.php +++ b/src/Executor/Executor.php @@ -285,7 +285,7 @@ class Executor } /** - * Implements the logic to compute the key of a given field�s entry + * Implements the logic to compute the key of a given fields entry */ private static function getFieldEntryKey(Field $node) { From b3932c8fbedd6e576f01cf8e8a6f916c929d3452 Mon Sep 17 00:00:00 2001 From: David Mongeau-Petitpas Date: Sun, 9 Aug 2015 19:00:05 -0400 Subject: [PATCH 3/3] Updated listOfType validation to Traversable --- src/Executor/Executor.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Executor/Executor.php b/src/Executor/Executor.php index 8f0b300..bb7459b 100644 --- a/src/Executor/Executor.php +++ b/src/Executor/Executor.php @@ -430,7 +430,7 @@ class Executor if ($fieldType instanceof ListOfType) { $itemType = $fieldType->getWrappedType(); Utils::invariant( - is_array($result) || $result instanceof \ArrayAccess, + is_array($result) || $result instanceof \Traversable, 'User Error: expected iterable, but did not find one.' );