1
0
mirror of synced 2024-12-14 15:16:04 +03:00
doctrine2/tests/Doctrine/Tests/ORM/Query
Gordon Stratton 9e916a2893 Fix for invalid 'double-ON' SQL generation with entity inheritance type JOINED.
In SqlWalker::walkJoin(), SqlWalker::walkRangeVariableDeclaration() can be
called which may produce an 'ON' clause if the entity inheritance type is
JOINED. As walkJoin() may then produce another ON clause, this results in
invalid SQL (e.g. '... ON foo = bar ON (baz = quux) ...' when the inheritance
type is JOINED.

This adds a test and a fix for the problem, by checking for an inheritance type
of JOINED in walkJoin() and using AND instead of ON in the appropriate place.

It seems like this part of the code is begging to be refactored. This is my
first foray into Doctrine internals and can't see a way to do this without
stomping all over the rest of the code, but this section seems ripe for cleanup
by somebody who is familiar.
2012-11-05 01:19:25 -08:00
..
CustomTreeWalkersTest.php [DDC-2052] Add SqlWalker::setQueryComponent() to allow modification of the query component in a custom output walker 2012-10-06 11:16:16 +02:00
DeleteSqlGenerationTest.php DDC-980 - Fix Update and Delete statements reference of the root table when doing subselects. 2011-01-13 21:16:08 +01:00
ExprTest.php Added NOT LIKE expression 2012-10-25 12:58:19 +02:00
LanguageRecognitionTest.php added test case 2012-10-08 13:49:31 +02:00
LexerTest.php Remove all trailing whitespaces 2011-12-19 22:56:19 +01:00
ParameterTypeInfererTest.php Fix DDC-1977 2012-08-15 22:57:21 +02:00
ParserResultTest.php Fixed some warnings from phpunit. 2011-02-19 19:50:58 -02:00
QueryExpressionVisitorTest.php Remove builders from QueryExpressionVisitorTest constructor 2012-08-29 15:48:04 +04:00
QueryTest.php [DDC-1840] Implemented parameters as a collection. 2012-05-28 12:16:42 -04:00
SelectSqlGenerationTest.php Fix for invalid 'double-ON' SQL generation with entity inheritance type JOINED. 2012-11-05 01:19:25 -08:00
UpdateSqlGenerationTest.php Remove sql conversion from where clauses and update statements 2011-11-21 15:08:36 +01:00