Konstantin Kuklin
c308986a90
Fix insufficient variable check
...
To ensure that `AbstractQuery#setResultCacheProfile()` doesn't raise
errors when being called with `null`.
2017-12-17 03:21:52 +01:00
Maximilian Ruta
32c125def1
Fix syntax error when join with discriminator
2017-12-17 01:25:50 +01:00
Luís Cobucci
74ce8913fc
Upgrade phpstan to 0.9
...
Applying the necessary fixes.
2017-12-17 00:55:50 +01:00
Luís Cobucci
441c5d138c
Reduce complexity of LimitSubqueryWalker#walkSelectStatement()
...
Ensuring that the code follows our code standards.
2017-12-16 23:31:50 +01:00
Gabriel Caruso
d0d802309c
Clean elses
2017-12-14 05:55:54 -02:00
Guilherme Blanco
e149f89cfe
Merge pull request #6820 from plfort/#6819-pagination-optim
...
#6819 Optimize LimitSubqueryWalker
2017-12-10 19:56:31 -05:00
Oskar Stark
79e1be8c3d
fixed closing tag
2017-12-01 15:41:52 +01:00
JKapitein
ad0a8c53fa
Add Type::GUID to $typeAlias list in EntityGenerator
...
Right now, when generating entities, a column of type 'guid' will generate the following PHPDoc:
```
/**
* Get id
*
* @return guid
*/
public function getId() {...}
```
Since guid is not a valid PHP type, this throws a warning in PHPStorm, and I assume most IDEs.
Adding the type to the type alias list fixes the problem.
2017-11-28 00:11:32 +01:00
Luís Cobucci
bc7aeb9d11
Make entity generator create the correct options
...
The `EntityGenerator` was not creating the field options for all
supported values.
2017-11-26 20:05:52 +01:00
foaly-nr1
c0a505366f
Use the correct type for the exception message
...
Since the UoW checks each item of a *-to-many association to ensure
it has the correct type, we should never say that we expect an instance
of `Doctrine\Common\Collections\Collection` or an `array`.
2017-11-26 17:55:59 +01:00
Sasha Alex Romanenko
b3331b2237
Enforce sequence XSD requirement
...
Supply default values for allocationSize and initialValue optional parameters.
Related to: https://github.com/doctrine/doctrine2/issues/6682
2017-11-26 16:33:27 +01:00
Mathieu Duplouy
7c28a932ae
Add operator to walkComparison output
2017-11-26 14:03:54 +01:00
Jan Jakes
99b2e57606
Fix overwriting explicit cache namespace
2017-11-26 12:48:12 +01:00
Luís Cobucci
b8fd708139
Fix parameter name comparison in QueryBuilder#setParameter() with different types
2017-11-24 02:43:01 +01:00
Michael Moravec
6cb5a9c50a
Fix parameter name comparison in AbstractQuery#setParameter() with different types
2017-11-24 02:43:00 +01:00
Oskar Stark
6b5eb11458
Use SymfonyStyle for command output
2017-11-24 01:25:17 +01:00
Luís Cobucci
8a893068ce
Remove constants existence validation
...
These constants are available since PHP 5.4 and since we're requiring
PHP 7.1 there's no reason to require them.
I've also simplified the `array_map()` call since it's useless to
define a closure that simply calls a function.
2017-11-24 01:25:14 +01:00
Oskar Stark
214dc9896b
Use addOption()/addArgument() to configure commands
...
In order to simplify and standardise the definition of the commands.
2017-11-24 01:20:09 +01:00
Pierre-Louis FORT
4ab9413675
Test that orderByItem is string
2017-11-10 10:45:57 +01:00
Pierre-Louis FORT
91408a3a54
#6819 Optimize LimitSubqueryWalker when resultVariable are involved and they are not used in "order by"
2017-11-09 14:34:11 +01:00
Sébastien Lévêque
f277eef6ea
Add support second, minute, week, year on DATE_ADD and DATE_SUB
2017-10-29 21:48:40 +01:00
Luís Cobucci
8e16748ff8
Merge pull request #6734 from ossinkine/issue-6734
...
Add DateInterval type parameter
2017-10-11 13:13:09 +02:00
Luís Cobucci
9e9e5628f5
Merge pull request #6755 from BenMorel/patch-2
...
EntityManager::getReference() can return null
2017-10-09 20:05:46 +02:00
Marco Pivetta
3dd7eb5888
#6759 removing outdated comment as per @alcaeus' review
...
Ref: https://github.com/doctrine/doctrine2/pull/6760#discussion_r143347881
2017-10-08 10:57:33 +02:00
Marco Pivetta
dd12ba88ee
#6759 avoiding reuse of the $identifier variable when constructing an identifier from the owning side value
...
Fixes #6759
2017-10-07 12:54:36 +02:00
Benjamin Morel
fb7a96caf9
EntityManager::getReference() can return null
2017-10-05 00:27:11 +02:00
Konstantin Kuklin
2d88e45240
sync type of property em with constructor value
2017-10-04 03:43:20 +03:00
Gocha Ossinkine
4fdbdabae4
Add DateInterval type parameter
2017-09-28 13:15:40 +05:00
Guilherme Lopes
a7e13f89cc
#6723 Remove variable from UnitOfWork#createEntity()
2017-09-26 12:52:18 +02:00
Guilherme Lopes
df1250ee4b
Fix negation clause and also adding both conditions in the same if
2017-09-21 13:42:51 +02:00
Guilherme Lopes
8ecddc4fc1
Adding empty line between logic blocks
2017-09-21 10:13:19 +02:00
Guilherme Lopes
059cfd86df
Remove unnecessary else
2017-09-21 10:02:43 +02:00
Dariusz Ruminski
c7d6d62393
Use newer PHP syntax
2017-09-06 01:32:49 +02:00
Michael Gwynne
d0d1e557d1
Adding change to appease scrutinizer
2017-09-04 10:11:43 +01:00
Michael Gwynne
fd9f96c766
Updating _maxResults to allow for null
2017-09-04 09:26:11 +01:00
Marco Pivetta
12043cd845
#5796 minor CS fixes (imported symbols) and removing last PHP5 compliance bits
2017-09-02 13:47:58 +02:00
Marco Pivetta
a1c93bfd48
#5796 replacing Exception catching with Throwable catching, removing PHP5 compliance code
2017-09-02 13:44:12 +02:00
Benjamin Morel
874a5e3547
Catch Throwable in PHP 7
2017-09-02 13:41:53 +02:00
Marco Pivetta
caa008b61d
#6284 #6217 removing hacks around the ClassMetadata details - invalid fix that was actually fixing the symptom
2017-08-23 00:25:29 +02:00
Marco Pivetta
07b397f341
#6284 fixing actual issue, which comes from an extremely tricky L2 caching issue.
...
We are not hydrating some of the cached association data into entities due to keys missing in the cache association definition.
Since this is an extreme edge case that is just a mismatch between db and cache, a detailed explanation was provided in the fix snippet as well
2017-08-23 00:19:49 +02:00
Marco Pivetta
a8453dda89
#6284 removing the "WTF" part of the logic - an association cache entry should never ever reach metadata
2017-08-22 21:03:14 +02:00
Waleed Gadelkareem
309b286ed3
Add tests for #6217
2017-08-22 19:45:26 +02:00
Marco Pivetta
2be32f249c
#1521 DDC-2922 adapting UoW and exception implementation to the new specification
2017-08-22 09:57:57 +02:00
Marco Pivetta
2751c0fff2
#1521 DDC-2922 minor code cleanup - renaming internal private methods, variables, removing redundant if/else
2017-08-21 20:08:20 +02:00
Darien Hager
b456cffa2d
Move final cascade-persist-checking so that it covers not just normal flushes, but also flushes where specific entities are singled out.
2017-08-21 09:08:31 +02:00
Darien Hager
17b996da8c
Speculative fix: Defer any errors for missing cascade-persist until object graph has been better-explored
2017-08-21 09:08:31 +02:00
Marco Pivetta
44f2e22f14
#6303 #6304 documenting why collisions in field name hydration in STI/JTI require additional information and checks in the hydration process
2017-08-19 18:30:33 +02:00
Marco Pivetta
c503b81421
#6303 #6304 removing += operator usage on arrays (scary\!), CS (alignment)
2017-08-19 16:02:30 +02:00
Marco Pivetta
7e7921e32f
#6303 #6304 documenting why the loose comparison is required
2017-08-19 15:58:50 +02:00
fullbl
8cc29e84a0
Update AbstractHydrator.php
...
revert strict comparison in hydration (fails on some dates)
2017-08-19 15:56:59 +02:00
