Darien Hager
b456cffa2d
Move final cascade-persist-checking so that it covers not just normal flushes, but also flushes where specific entities are singled out.
2017-08-21 09:08:31 +02:00
Darien Hager
17b996da8c
Speculative fix: Defer any errors for missing cascade-persist until object graph has been better-explored
2017-08-21 09:08:31 +02:00
Darien Hager
92dc39bfb9
Add extra assertions to test to ensure that flush actually succeeded in saving all items
2017-08-21 09:08:31 +02:00
Darien Hager
997000352a
Add another test to demonstrate the bug doesn't appear if everything is flushed at once.
2017-08-21 09:08:31 +02:00
Darien Hager
6f8a80be79
Move failing unit test into ticket-specific case
2017-08-21 09:08:31 +02:00
Darien Hager
c4465abaa0
Initial failing test-case to demonstrate cascade-persist problem.
2017-08-21 09:08:12 +02:00
Marco Pivetta
ddccd42bb1
Merge pull request #6636 from Kwadz/annot-ref-update
...
Mention the nullable default value for @column
2017-08-20 08:17:41 +02:00
Richard
9eaf23a5e0
Mention the nullable default value for @column
...
Related to #6632
2017-08-20 05:57:00 +02:00
Marco Pivetta
a30d8d85ea
Merge branch 'fix/#6303-#6304-check-for-null-discriminator-before-hydrating-inheritance-rows'
...
Close #6303
Close #6304
ge aborts
2017-08-19 18:37:04 +02:00
Marco Pivetta
44f2e22f14
#6303 #6304 documenting why collisions in field name hydration in STI/JTI require additional information and checks in the hydration process
2017-08-19 18:30:33 +02:00
Marco Pivetta
4cbcdb761a
#6303 #6304 documenting that the discriminator map order is extremely important for this test
2017-08-19 18:25:44 +02:00
Marco Pivetta
b66643d52e
#6303 #6304 removing useless union type usage
2017-08-19 17:49:14 +02:00
Marco Pivetta
42d9162bd5
#6303 #6304 re-enabling disabled test code data
2017-08-19 17:47:12 +02:00
Marco Pivetta
8af68614fc
#6303 #6304 correcting type mapping. For simple_array, [] == null (which is bullshit), so we use array here
2017-08-19 17:45:26 +02:00
Marco Pivetta
764ab59882
#6303 #6304 making unnecessary visible fields private
2017-08-19 17:06:27 +02:00
Marco Pivetta
468496be1a
#6303 #6304 using strict types in the tests
2017-08-19 17:05:44 +02:00
Marco Pivetta
e18fb6607d
#6303 #6304 removing duplicate test details
2017-08-19 17:04:26 +02:00
Marco Pivetta
2ab363ab82
#6303 #6304 adding void hints where applicable
2017-08-19 16:53:41 +02:00
Marco Pivetta
0882b10213
#6303 #6304 simplified tests, removing references to contract naming
2017-08-19 16:51:31 +02:00
Marco Pivetta
328467c226
#6303 #6304 simplified tests, removing references to contract naming
2017-08-19 16:48:50 +02:00
Marco Pivetta
f6ce69fe29
#6303 #6304 minor CS fixes in the test code - alignment/formatting
2017-08-19 16:37:24 +02:00
Marco Pivetta
aaad25a061
#6303 #6304 reverting changes to the OrmFunctionalTestCase
2017-08-19 16:25:20 +02:00
Marco Pivetta
c503b81421
#6303 #6304 removing += operator usage on arrays (scary\!), CS (alignment)
2017-08-19 16:02:30 +02:00
Marco Pivetta
7e7921e32f
#6303 #6304 documenting why the loose comparison is required
2017-08-19 15:58:50 +02:00
fullbl
8cc29e84a0
Update AbstractHydrator.php
...
revert strict comparison in hydration (fails on some dates)
2017-08-19 15:56:59 +02:00
Full
db9c12f1af
comparison on discriminator value with !==
2017-08-19 15:56:59 +02:00
fullbl
82db643b4f
clarified what's the problem in a comment
2017-08-19 15:56:59 +02:00
Full
4c7286f57b
removed trailing spaces
2017-08-19 15:56:59 +02:00
Full
0072054020
moved all test models into test class
2017-08-19 15:56:59 +02:00
Full
0b8e468f06
fix wrong pharenthesis
2017-08-19 15:56:59 +02:00
Full
bf06b7dbbc
check if array is set before assigning
2017-08-19 15:56:59 +02:00
Full
ad3b9de4b8
use dataMap also in first test function
2017-08-19 15:56:59 +02:00
Full
6d40859228
added tests on empty values
2017-08-19 15:56:59 +02:00
Full
aac523d155
tests with custom inheritance tree
2017-08-19 15:56:59 +02:00
Marco Pivetta
671fd50725
Merge pull request #6572 from bitwombat/doc_changes
...
Add additional detail and clarifications on SELECT
2017-08-18 21:45:17 +02:00
Marco Pivetta
1a0bb82e1d
Merge pull request #6392 from Jean85/pr_1441_rebased
...
Correct DQL `INSTANCE OF` to filter all possible child classes
2017-08-18 21:35:54 +02:00
Marco Pivetta
a426808a16
Merge branch 'fix/#6633-#3788-avoid-xml-external-entity-loading-errors-in-xml-mapping-driver'
...
Close #6633
Close #3788
2017-08-18 21:12:37 +02:00
Marco Pivetta
492fb50744
#6633 #3788 documenting why simplexml_load_file() was not used
2017-08-18 21:08:14 +02:00
Alessandro Lai
c799c6da8b
Add new functional test to check usage of INSTANCEOF with multiple parameters
2017-08-18 14:49:56 +02:00
Aljosha Papsch
eb762dea23
XmlDriver: Avoid PHP bug #62577 by avoiding simplexml_load_file.
...
Doctrine is affected by PHP bug #62577 . simplexml_load_file is not
able to load files if libxml_disable_entity_loader(true) has been
called. simplexml_load_file fails with the message:
I/O warning : failed to load external entity "/my/mappings/my_entity.dcm.xml"
in /path-to/lib/Doctrine/ORM/Mapping/Driver/XmlDriver.php on line 711
This error occurs even if there are no external entities in the XML file.
Waiting for the PHP bug to be resolved is infeasible, because it is
unresolved since years. Therefore Doctrine needs to circumvent the bug
by replacing simplexml_load_file with simplexml_load_string while getting
the file contents itself. simplexml_load_string is not affected by the
PHP bug.
2017-08-18 14:23:43 +02:00
Alessandro Lai
19bc4991ae
Add more CS fixes
2017-08-18 12:35:51 +02:00
Alessandro Lai
9864a5a9b9
Add unit test for HierarchyDiscriminatorResolverTest
2017-08-18 12:11:09 +02:00
Alessandro Lai
5224a89549
Apply various and CS fixes as per review
2017-08-18 11:02:28 +02:00
Alessandro Lai
d4db126bb0
Remove code duplication of the getAllDiscriminators method
2017-08-18 10:17:52 +02:00
Marco Pivetta
60e29b40a0
Merge branch 'fix/#5579-fix-performance-of-single-entity-flush-with-notify-tracking-policy'
...
Close #5579
2017-08-18 09:30:43 +02:00
Marco Pivetta
496c22db0e
#5579 completely removing a changeset when cleaning up
2017-08-18 09:27:47 +02:00
Marco Pivetta
1bf8465f43
#5579 correcting assertion static/instance method usage
2017-08-18 09:25:47 +02:00
Marco Pivetta
ff15a2bc79
#5579 correcting visibility of clearEntityChangeSet, which should be reverted to public
2017-08-18 09:23:28 +02:00
Marco Pivetta
9d7be0f927
#5579 s/clear/cleanup
2017-08-18 09:22:23 +02:00
Marco Pivetta
2921f068b7
#5579 cleaning up postCommitClear implementation
2017-08-18 09:21:53 +02:00
