Marco Pivetta
894490c2a0
#6593 #5864 removing incorrect null
return value in API marked as string
2017-08-16 19:57:26 +02:00
Marco Pivetta
e1acba3ae4
#6593 #5864 reverted all public/protected API parameter and return type changes
...
That's still to be considered a BC break, since child classes are broken if incompatible.
Sorry @tPl0ch :-(
2017-08-16 19:53:32 +02:00
Thomas Ploch
e4006e533c
[FX] Use single quotes for XML root in XmlExporter
2017-08-16 12:26:33 +02:00
Thomas Ploch
b1e091b0e1
[FX] Looking up PHP internal functions from the root namespace is faster
2017-08-16 12:25:31 +02:00
Thomas Ploch
599865528e
[CS] Remove obsolete doc blocks #2
2017-08-16 12:24:37 +02:00
Thomas Ploch
fe88422e68
[CS] Remove obsolete doc blocks
2017-08-16 12:24:00 +02:00
Thomas Ploch
741819f060
Revert "Minor coding style fixes and more docblock removal"
...
This reverts commit ec3eed68ca0551edc33fb1dc94a604d84857a122.
2017-08-15 10:28:43 +02:00
Thomas Ploch
ec3eed68ca
Minor coding style fixes and more docblock removal
2017-08-15 10:17:20 +02:00
Thomas Ploch
b7ae5b4afb
Entity listeners are now processed by exporters
...
The current implementation of the exporters are not taking the entity
listeners into account. I have added test cases for most of the edge
cases I could think of and implemented the Exporter handling.
This PR originates from https://github.com/doctrine/doctrine2/pull/5864 ,
I was overwhelmed by the amount of conflicts I had to resolve so I
started anew on a clean master HEAD.
Squashed commits:
- Code review aftermath
- Add even more return type declarations
- Added `return null` to methods declared with nullable return types
- Removed unneeded docblocks when types are self-explanatory
2017-08-15 10:08:50 +02:00
Luís Cobucci
5109322f7d
Make explicit the design decisions of ConsoleRunner
2017-07-22 21:56:59 +02:00
Luís Cobucci
2b824ea9df
Update ConsoleRunner command list
...
Adding L2C commands and DBAL reserved words command.
2017-07-22 21:56:42 +02:00
Luís Cobucci
5389ad7261
Make LimitSubqueryOutputWalker a bit more readable
...
Also simplifying the REGEX to remove the ORDER BY type (ASC/DESC) with a
substr() since OrderByItem#type is always defined.
2017-07-22 20:34:18 +02:00
chihiro-adachi
60601a9323
fix query and tests
2017-07-22 19:28:28 +02:00
Martin Kirilov
854ff17ab9
Should fix MySQL 5.7 issues caused by ONLY_FULL_GROUP_BY
...
Should fix MySQL 5.7 issues caused by ONLY_FULL_GROUP_BY
2017-07-22 19:28:28 +02:00
Michael Moravec
74c48c201d
Push PHPStan to level 1
2017-06-30 00:27:50 +02:00
Marco Pivetta
41bcdb3268
Merge pull request #6494 from astepin/gh-6356
...
Add failing test for #6314 and PR #6356
2017-06-23 12:54:29 +02:00
Jáchym Toušek
fc609271e0
Fix CountOutputWalker for queries with GROUP BY
2017-06-22 07:09:20 +02:00
Sergey Fedotov
d13327eca2
Fix undefined index for discriminator column in SchemaTool
2017-06-21 06:27:15 +02:00
Guilliam Xavier
87e9879edd
Fix MetadataFilter not testing filters after first
2017-06-21 06:14:01 +02:00
Artem Stepin
799190d5e4
- fixed columnPrefix generator for the embedded annotation
2017-06-09 22:25:19 +02:00
Artem Stepin
351b6972a4
Merge branch 'original-pr-6356' into gh-6356
2017-06-09 21:58:57 +02:00
Artem Stepin
43009682a4
minor code work:
...
- method calls with incorrect case
- removed unused imports
- typos and some other minor code smells
- documentation update (wrong return types etc. )
2017-06-08 22:04:07 +02:00
Matthias Pigulla
5c1908d82f
Remove dead code
...
Hopefully this does not do anything...?
2017-05-09 19:21:49 +02:00
Adam Gąsowski
5507e0be29
Fix wrong variable name
...
Fix $fieldMapping to $embeddedClass in generateEmbeddedPropertyDocBlock
2017-03-23 19:12:40 +01:00
Marco Pivetta
6e6be3fdd9
Merge pull request #6164 from eyepin/patch-1
...
Update EntityGenerator.php
2016-12-12 08:30:16 +01:00
Luís Cobucci
512aa8a3c7
Use "::class" syntax on "lib" directory
2016-12-08 17:09:35 +01:00
Luís Cobucci
234989d069
Use short-array syntax on "lib" directory
2016-12-08 00:31:12 +01:00
eyepin
521588f498
Update EntityGenerator.php
...
orm:generate:entities genrates 2 blank lines
PSR2: All PHP files MUST end with a single blank line.
this worked for me
2016-12-07 13:13:21 +01:00
Marco Pivetta
dc7c6ed72c
Merge pull request #5897 from mikaelz/patch-1
...
Check for Xcache from INI setting
2016-11-26 06:48:55 +01:00
Marco Pivetta
0ed18fb062
#5914 removed unused conditional inside EntityGenerator
, replaced with array_filter()
instead
2016-11-26 06:44:53 +01:00
ReenExe
401300b295
decrease nested if
2016-11-26 06:40:56 +01:00
Marco Pivetta
a4f76bda34
#6068 corrected nullable field expression generator, made it private to avoid misuse
2016-11-26 06:26:53 +01:00
Marco Pivetta
1d2baedfd5
#6068 simplified variable docblock codegen for nullable instance properties
2016-11-26 06:22:25 +01:00
Marco Pivetta
3341781f52
#6068 inlined code generating expression
2016-11-26 06:20:12 +01:00
Javier Spagnoletti
1dfadef221
Removed surplus semicolon at EntityGenerator::generateFieldMappingPropertyDocBlock()
2016-11-26 06:12:31 +01:00
Javier Spagnoletti
087d081601
Fix CS
2016-11-26 06:12:31 +01:00
Javier Spagnoletti
d3c604567b
Update docblock generation for nullable fields
2016-11-26 06:12:31 +01:00
Marco Pivetta
3cd7b8c951
#5987 CS: spacing after !
(not) operator
2016-11-26 05:23:04 +01:00
Javier Spagnoletti
e2b198112e
[minor] Add missing type hints, add strictness for some checks, remove some useless calls
2016-11-26 05:18:46 +01:00
Vladimir Reznichenko
db375a22cc
Static Code Analysis with Php Inspections (EA Extended): revert unsets
2016-11-06 17:58:45 +01:00
Vladimir Reznichenko
0bf3d7f84c
Static Code Analysis with Php Inspections (EA Extended)
2016-11-06 14:22:47 +01:00
Jefersson Nathan
b8a18cd0a1
fix license header inconsistencies
2016-10-25 23:58:42 -03:00
Michal Zuber
7ef3e3a60c
Check for Xcache from INI setting
...
On a shared webhosting the Xcache module is loaded, but it can be disabled with .htaccess `php_flag xcache.cacher Off` which causes issues.
2016-06-22 08:50:36 +02:00
Thomas Ploch
ea788fb734
Exporters should only inspect joinColumns
for owning side in bi-directional OneToOne
...
rebased commits:
- Added test case for bi-directional OneToOne in YamlExporter
- Only inspect joinColumns for owning side in bi-directional OneToOne in YamlExporter
- Adding bi-directional test case without joinColumn to XmlExporter test
- Same testcase also applied to PhpExporter
- Fixing bi-directional issue in PhpExporter when inspecting joinColumns index
- Implemented @Ocramius suggestions
2016-06-08 13:24:43 +02:00
Mikhail Shamin
bf322b903d
Optimize imports. Remove full qualified class names
2016-05-11 01:55:12 +07:00
Steve Müller
f9217cf6f2
fix documentation of schema tool's "save mode"
...
fixes #5596
2016-01-08 15:37:19 +01:00
Jeroen Thora
6dcb97a20e
Fixed many small phpcs issues
2015-12-11 20:30:41 +01:00
Guilherme Blanco
04789dfec7
Merge pull request #1443 from meeuw/unsigned
...
Unsigned
2015-11-15 22:16:15 -05:00
vershnik
96398ba30f
remove indexes overruled by primary key
...
There can be unique indexes automatically created for join column.
If join column is also primary key we should keep only primary key on this column.
Oracle does not allow having both unique index and primary key on the same column, it is useless for mysql too.
(Previously it was done by DBAL, but now it allows duplicate indexes)
2015-11-16 02:49:41 +00:00
Guilherme Blanco
ada97d55ce
Merge pull request #1375 from webimpress/fix/DDC-3671
...
DDC-3671 prevent duplicate unique index
2015-11-07 11:44:02 -05:00