Marco Pivetta
09cbb9ff48
Merge pull request #5600 from billschaller/remove-dead-code-walk-case-expression
...
Remove dead code SQLWalker::walkCaseExpression
2017-01-15 23:52:38 +01:00
Luís Cobucci
234989d069
Use short-array syntax on "lib" directory
2016-12-08 00:31:12 +01:00
ReenExe
12465e08ad
agree with scrutinizer
2016-11-26 06:40:32 +01:00
Marco Pivetta
24da9061b9
#5987 inlined check for boolean 'true'
literal
2016-11-26 05:22:43 +01:00
Javier Spagnoletti
e2b198112e
[minor] Add missing type hints, add strictness for some checks, remove some useless calls
2016-11-26 05:18:46 +01:00
Bill Schaller
744c308337
Remove dead code SQLWalker::walkCaseExpression
2016-01-08 13:58:02 -05:00
Bill Schaller
55d4f515af
Fix issue were identifier operands in /,* arithmetic terms were not checked to see if they're query components
2016-01-08 12:53:05 -05:00
Jeroen Thora
6dcb97a20e
Fixed many small phpcs issues
2015-12-11 20:30:41 +01:00
Matthias Pigulla
b7bd42638d
Fix for DDC-3697 and DDC-3701
...
Also fix Lexer::match() so it does not accept T_WHERE when T_WITH is supposed to be matched. (DDC-3701)
2015-11-09 03:19:11 +00:00
Guilherme Blanco
843966ac50
General fixes across CS, type resolving, test fixes, etc
2015-11-07 03:55:05 +00:00
Andy Cook
26c295b06b
Added non-functional tests for row number over function subselect expression fix; syntax fixes.
2015-07-17 13:24:19 +01:00
Andy Cook
61488d955e
Fixed issue when paginator orders by a subselect expression on platforms supporting ROW_NUMBER OVER() function.
2015-07-16 11:20:22 +01:00
Benjamin Morel
517cb7e2a2
Honor convertToDatabaseValueSQL() in DQL query parameters
2015-03-18 00:24:41 +01:00
James Murray
d9cbe1a8b7
removed unnecessary fieldIdentificationVariable property check
2014-12-19 14:10:47 -05:00
James Murray
85eac7200d
Adding the ability to alias new object expressions
2014-10-28 17:34:57 -04:00
Marco Pivetta
b989175754
#615 - Removing unused assignment
2014-10-19 17:24:07 +02:00
Marco Pivetta
a4e9c235f8
#615 - assignment alignment
2014-10-19 17:08:33 +02:00
Mike Meier
fb5f76f025
rewrite tablePrefixAlias
2014-10-19 17:05:34 +02:00
Mike Meier
ebc996c820
Update SqlWalker.php
...
Always be sure that only a-z characters are used for table alias, otherwise use generic "t" for "table"
2014-10-19 17:05:34 +02:00
Marco Pivetta
b80149344d
Merge pull request #1073 from kamazee/add_passing_type_to_rsm_in_sql_walker
...
Add missing type mapping
2014-07-14 10:51:13 +02:00
Alexander Kurilo
38fcc66c16
Add missing type mapping
...
Fixes DDC-3192
Refs DDC-2494
This is essentially a fix from DDC-2494 applied to SQLWalker.
The issue: type was not converted to PHP value when the result is fetched by
executing DQL query rather than using entity manager's findX(). Similar issue
for BasicEntityPersister (which is used when em's findX is executed) was fixed
in DDC-2494, but SQLWalker made the issue valid for any custom query.
2014-07-14 11:22:08 +03:00
Daniel Sippel
45358bf5d0
possible fix for DDC-2021
2014-07-09 16:39:44 +02:00
Guilherme Blanco
6a8ee87268
Made DQL and EBNF in sync.
2014-04-20 20:27:57 +00:00
Guilherme Blanco
a3f95d919b
DDC-3075 Added support for subqueries in NEW operator.
2014-04-20 14:40:51 +00:00
Benjamin Eberlei
2aea3036b6
[DDC-3018] Fix string literals in new operator.
2014-03-23 15:16:09 +01:00
Guilherme Blanco
0dbd742588
Merge pull request #886 from Strate/bugfix/join-with-condition-placement-fix
...
[DDC-1256] Fix applying ON/WITH conditions to first join in Class Table Inheritance
2014-02-17 12:12:05 -05:00
Strate
324f200f1b
Merge branch 'master' into bugfix/join-with-condition-placement-fix
2014-02-10 08:22:11 +04:00
Benjamin Morel
08f6291350
Cleaned up further unused imports.
2014-02-09 23:45:22 +00:00
Steve Müller
a6c8ab8a5f
make lock mode usage consistent
2014-02-05 15:13:53 +01:00
Strate
04e6061584
Added an exception when invalid case.
...
Fixes after code review.
2014-01-20 20:06:53 +04:00
Strate
41ec5fd56d
Fix applying ON/WITH conditions to first join in Class Table Inheritance
...
Now we build nested joins for CTI when using ON/WITH clause.
2014-01-19 20:56:24 +04:00
Strate
b69481b639
Merge branch 'master' into bugfix/join-with-condition-placement-fix
2014-01-19 15:06:01 +04:00
Steve Müller
b9ff877f14
fix SQL generation on table lock hint capable platforms
2014-01-15 22:46:09 +01:00
Strate
c6810861ca
Fix applying ON/WITH conditions to first join in Class Table Inheritance
2013-12-22 21:02:14 +04:00
Fabio B. Silva
61bff7d5f6
Fix CS and update docs
2013-12-16 11:05:04 -05:00
Fabio B. Silva
3140593e9b
Second level cache
2013-12-16 11:05:04 -05:00
Vincent BOURDEIX
5506d7adce
Fixes a Fatal Error when using a subexpression in parenthesis
...
When some dql contains a subselect with expression in parenthesis, the
expression of the $simpleSelectExpression parameter given to
walkSimpleSelectExpression is an instance of AST\ParenthesisExpression.
Before this commit, this case defaulted to
$this->walkEntityIdentificationVariable($expr) where $expr is supposed
to be a string. A fatal error was then yielded.
2013-10-14 15:04:52 +02:00
flip111
228a501014
Made the code prettier :)
2013-10-01 16:53:53 +02:00
flip111
72ae7f5497
Changed GroupBy alias to real column name for all platforms and adjusted failing test accordingly. Has fallback in cases where real column name is not possible (example: Doctrine\Tests\ORM\Query\SelectSqlGenerationTest::testGroupBySupportsIdentificationVariable)
2013-09-30 11:08:42 +02:00
flip111
76fda9562c
Update SqlWalker.php fixed wrong GROUP BY clause on SQL Server platform
...
Without this patch a query would like like:
```
SELECT c0_.Country AS sclr0
FROM Continent c0_ WITH (NOLOCK)
WHERE c0_.Country = 38
GROUP BY sclr0
```
Using the column alias in the GROUP BY clause. However this is not allowed on SQL Server. References:
1. http://stackoverflow.com/a/3841804
2. http://technet.microsoft.com/en-us/library/ms189499.aspx (Logical Processing Order of the SELECT statement)
The correct query should be:
```
SELECT c0_.Country AS sclr0
FROM Continent c0_ WITH (NOLOCK)
WHERE c0_.Country = 38
GROUP BY c0_.Country
```
2013-09-26 14:11:56 +02:00
Guilherme Blanco
cc83ac6ce8
Centralize InputParameter SQL generation.
2013-08-19 00:33:45 -04:00
Guilherme Blanco
43fc8bafa7
DDC-1858 Added missing support to ResultVariable in LikeExpression.
2013-08-18 23:52:32 -04:00
Guilherme Blanco
f674445486
Fixed DDC-2235.
2013-08-16 00:07:06 -04:00
Guilherme Blanco
7f1c1d2b4a
Fixed DDC-2506 by manually updating code. Closes PR #708 .
2013-08-13 01:07:34 -04:00
Guilherme Blanco
d9c1782a4f
Properly fixed DDC-1858. Added support for ResultVariable in NullComparisons while using HavingClause.
2013-08-03 17:38:55 -04:00
Guilherme Blanco
6ef48561ba
Merge pull request #688 from sellingsource/master
...
Implement QuoteStrategy on SqlWalker walkRangeVariableDeclaration
2013-06-12 12:03:24 -07:00
Fabio B. Silva
710d0d1109
Fix DDC-1995
2013-06-07 17:24:05 -04:00
John Brown
4ef043fc3b
updating sql walker to use quote strategy in joins
2013-06-07 08:56:58 -07:00
John Brown
afb9c829e2
updating sql walker to use quote strategy in joins
2013-06-07 08:49:49 -07:00
John Brown
77b905eaa8
Implement QuoteStrategy on SqlWalker walkRangeVariableDeclaration
...
Based on:
http://www.doctrine-project.org/jira/browse/DDC-1845
cb72219b11
2013-06-06 15:08:22 -07:00