Thomas Ploch
599865528e
[CS] Remove obsolete doc blocks #2
2017-08-16 12:24:37 +02:00
Thomas Ploch
fe88422e68
[CS] Remove obsolete doc blocks
2017-08-16 12:24:00 +02:00
Thomas Ploch
741819f060
Revert "Minor coding style fixes and more docblock removal"
...
This reverts commit ec3eed68ca0551edc33fb1dc94a604d84857a122.
2017-08-15 10:28:43 +02:00
Thomas Ploch
ec3eed68ca
Minor coding style fixes and more docblock removal
2017-08-15 10:17:20 +02:00
Thomas Ploch
b7ae5b4afb
Entity listeners are now processed by exporters
...
The current implementation of the exporters are not taking the entity
listeners into account. I have added test cases for most of the edge
cases I could think of and implemented the Exporter handling.
This PR originates from https://github.com/doctrine/doctrine2/pull/5864 ,
I was overwhelmed by the amount of conflicts I had to resolve so I
started anew on a clean master HEAD.
Squashed commits:
- Code review aftermath
- Add even more return type declarations
- Added `return null` to methods declared with nullable return types
- Removed unneeded docblocks when types are self-explanatory
2017-08-15 10:08:50 +02:00
Marco Pivetta
a0c0d3bf2a
Revert "Merge branch 'fix/#6499-#6533-fix-commit-order-calculation-consider-all-join-column-fields'"
...
This reverts commit 2a58645cb5870f0ab61e918c7165c248d225dbac, reversing
changes made to 6d428c90e24c914c1e5d817d74646f3b94757c43.
2017-08-11 22:29:45 +02:00
Marco Pivetta
1ede3c514f
#6499 #6533 simplifying nullable column check - null coalesce operator makes it *SOMEWHAT* more readable (no miracles)
2017-08-11 22:13:20 +02:00
Gabe van der Weijde
db2530d6fd
-- Proposed fix due to logic error.
2017-08-11 21:51:17 +02:00
Marco Pivetta
9ad91ddc1c
#6464 #6475 using PHP 7.1 void and string return hints where available
2017-08-11 21:45:23 +02:00
Stefan Siegl
025ed1147b
#6464 code review updates
2017-08-11 21:36:33 +02:00
Stefan Siegl
99fdbf550d
generate nested join sql for CTIs, closes #6464
2017-08-11 21:36:33 +02:00
Marco Pivetta
c2dd274c42
#6613 #6614 #6616 adding void return type
2017-08-11 21:27:09 +02:00
Marco Pivetta
004ac51869
#6613 #6614 #6616 minor performance optimisations around the new restoreNewObjectsInDirtyCollection implementation
2017-08-11 21:14:05 +02:00
Marco Pivetta
a2ca6bbfaf
#6613 #6614 #6616 ensuring that the collection is marked as non-dirty if all new items are contained in the initialized ones
2017-08-11 21:09:34 +02:00
Marco Pivetta
d44e6e1a9e
#6613 #6614 ensuring that only newly added items that weren't loaded are restored in the dirty state of the collection
2017-08-11 15:13:39 +02:00
Alfredo Costa
8952176c73
Add message to NonUniqueResultException
2017-08-06 12:07:47 +02:00
Martin Georgiev
30088fe529
Fix double spacing in exception's message
2017-08-03 11:52:06 +01:00
Luís Cobucci
eba8fec1fb
Move identifier types extraction to a method
2017-07-22 22:39:47 +02:00
Alessandro Frangioni
60a2628f9d
Iteration simplified
2017-07-22 22:26:31 +02:00
Alessandro Frangioni
4ef0a238bf
Inferring id's field types
2017-07-22 22:26:31 +02:00
Alessandro Frangioni
af3591fbca
Fixes #5804
2017-07-22 22:26:31 +02:00
Luís Cobucci
5109322f7d
Make explicit the design decisions of ConsoleRunner
2017-07-22 21:56:59 +02:00
Luís Cobucci
2b824ea9df
Update ConsoleRunner command list
...
Adding L2C commands and DBAL reserved words command.
2017-07-22 21:56:42 +02:00
Luís Cobucci
5389ad7261
Make LimitSubqueryOutputWalker a bit more readable
...
Also simplifying the REGEX to remove the ORDER BY type (ASC/DESC) with a
substr() since OrderByItem#type is always defined.
2017-07-22 20:34:18 +02:00
chihiro-adachi
60601a9323
fix query and tests
2017-07-22 19:28:28 +02:00
Martin Kirilov
854ff17ab9
Should fix MySQL 5.7 issues caused by ONLY_FULL_GROUP_BY
...
Should fix MySQL 5.7 issues caused by ONLY_FULL_GROUP_BY
2017-07-22 19:28:28 +02:00
Andreas Braun
260cc6e3e0
Fix return of removeElement on collections
...
Fixes #5745
2017-07-13 08:16:00 +02:00
Michael Moravec
74c48c201d
Push PHPStan to level 1
2017-06-30 00:27:50 +02:00
Ondrej Mirtes
1231861b09
Initial PHPStan integration (level 0)
2017-06-30 00:27:49 +02:00
Marco Pivetta
388afb46d0
Merge pull request #6245 from lcobucci/l2c-use-getMultiple
...
Use `getMultiple()` to fetch associations as well in L2 cache fetch operations
2017-06-24 09:17:55 +02:00
Marco Pivetta
5d98247178
Merge pull request #5756 from whyte624/master
...
s/__tostring()/__toString() in Expr\OrderBy
2017-06-24 04:12:55 +02:00
Marco Pivetta
aba486ea2d
#1515 removing redundant assignment, short array notation
2017-06-24 03:27:12 +02:00
Emiel Nijpels
9eb2d6139e
DDC-3146 remove event listener from event listener in abstract hydrator in cleanup function
2017-06-24 03:22:12 +02:00
Marco Pivetta
41bcdb3268
Merge pull request #6494 from astepin/gh-6356
...
Add failing test for #6314 and PR #6356
2017-06-23 12:54:29 +02:00
Jáchym Toušek
fc609271e0
Fix CountOutputWalker for queries with GROUP BY
2017-06-22 07:09:20 +02:00
Marco Pivetta
b21cb3e2a0
#6325 adding IDE hints, type hints, replacing double quotes with single quotes
2017-06-21 08:16:24 +02:00
Tomasz Darmetko
633a442046
Add path expresion to QueryException::associationPathInverseSideNotSupported()
2017-06-21 08:12:04 +02:00
Sergey Fedotov
d13327eca2
Fix undefined index for discriminator column in SchemaTool
2017-06-21 06:27:15 +02:00
Guilliam Xavier
87e9879edd
Fix MetadataFilter not testing filters after first
2017-06-21 06:14:01 +02:00
Marco Pivetta
d2be4a2b48
#6167 #6168 - clarifying on the reasoning why query is used instead of fetchColumn
2017-06-21 05:44:58 +02:00
Michał Kurzeja
edffb4d449
#6167 - fixed tests and added info why query is used in SequenceGenerator
2017-06-21 05:42:26 +02:00
Michał Kurzeja
60b6073643
Fixes #6167 - nextval issue on master-slave PostgreSQL setup
2017-06-21 05:42:26 +02:00
Marco Pivetta
a7dcdd8d48
Documenting thrown exception type, spacing #6162
2017-06-21 05:36:13 +02:00
SimonHeimberg
f5d4db7d9c
Report that FROM and JOIN do not support Subqueries
2017-06-21 05:31:25 +02:00
Mathew Davies
747c1857d6
Make the new aggregate function definitions final.
2017-06-20 07:27:32 +02:00
Mathew Davies
3e3751cfd9
Remove aggregate function conditional in SqlWalker.
2017-06-20 07:27:27 +02:00
Mathew Davies
966f9a84c2
phpDoc and type hint changes.
2017-06-20 07:27:26 +02:00
Mathew Davies
e4847534a4
Remove @throws in Configuration where necessary.
2017-06-20 07:27:25 +02:00
Mathew Davies
866418e40f
No longer treat aggregate functions as a special case.
2017-06-20 07:27:24 +02:00
Mathew Davies
e4ff7a35a8
Write a test case for a custom function override.
2017-06-20 07:27:22 +02:00
