Marco Pivetta
12043cd845
#5796 minor CS fixes (imported symbols) and removing last PHP5 compliance bits
2017-09-02 13:47:58 +02:00
Marco Pivetta
a1c93bfd48
#5796 replacing Exception catching with Throwable catching, removing PHP5 compliance code
2017-09-02 13:44:12 +02:00
Benjamin Morel
874a5e3547
Catch Throwable in PHP 7
2017-09-02 13:41:53 +02:00
Marco Pivetta
caa008b61d
#6284 #6217 removing hacks around the ClassMetadata details - invalid fix that was actually fixing the symptom
2017-08-23 00:25:29 +02:00
Marco Pivetta
07b397f341
#6284 fixing actual issue, which comes from an extremely tricky L2 caching issue.
...
We are not hydrating some of the cached association data into entities due to keys missing in the cache association definition.
Since this is an extreme edge case that is just a mismatch between db and cache, a detailed explanation was provided in the fix snippet as well
2017-08-23 00:19:49 +02:00
Marco Pivetta
a8453dda89
#6284 removing the "WTF" part of the logic - an association cache entry should never ever reach metadata
2017-08-22 21:03:14 +02:00
Waleed Gadelkareem
309b286ed3
Add tests for #6217
2017-08-22 19:45:26 +02:00
Marco Pivetta
2be32f249c
#1521 DDC-2922 adapting UoW and exception implementation to the new specification
2017-08-22 09:57:57 +02:00
Marco Pivetta
2751c0fff2
#1521 DDC-2922 minor code cleanup - renaming internal private methods, variables, removing redundant if/else
2017-08-21 20:08:20 +02:00
Darien Hager
b456cffa2d
Move final cascade-persist-checking so that it covers not just normal flushes, but also flushes where specific entities are singled out.
2017-08-21 09:08:31 +02:00
Darien Hager
17b996da8c
Speculative fix: Defer any errors for missing cascade-persist until object graph has been better-explored
2017-08-21 09:08:31 +02:00
Marco Pivetta
44f2e22f14
#6303 #6304 documenting why collisions in field name hydration in STI/JTI require additional information and checks in the hydration process
2017-08-19 18:30:33 +02:00
Marco Pivetta
c503b81421
#6303 #6304 removing += operator usage on arrays (scary\!), CS (alignment)
2017-08-19 16:02:30 +02:00
Marco Pivetta
7e7921e32f
#6303 #6304 documenting why the loose comparison is required
2017-08-19 15:58:50 +02:00
fullbl
8cc29e84a0
Update AbstractHydrator.php
...
revert strict comparison in hydration (fails on some dates)
2017-08-19 15:56:59 +02:00
Full
db9c12f1af
comparison on discriminator value with !==
2017-08-19 15:56:59 +02:00
Full
4c7286f57b
removed trailing spaces
2017-08-19 15:56:59 +02:00
Full
0b8e468f06
fix wrong pharenthesis
2017-08-19 15:56:59 +02:00
Full
bf06b7dbbc
check if array is set before assigning
2017-08-19 15:56:59 +02:00
Full
ad3b9de4b8
use dataMap also in first test function
2017-08-19 15:56:59 +02:00
Full
6d40859228
added tests on empty values
2017-08-19 15:56:59 +02:00
Marco Pivetta
1a0bb82e1d
Merge pull request #6392 from Jean85/pr_1441_rebased
...
Correct DQL `INSTANCE OF` to filter all possible child classes
2017-08-18 21:35:54 +02:00
Marco Pivetta
492fb50744
#6633 #3788 documenting why simplexml_load_file() was not used
2017-08-18 21:08:14 +02:00
Aljosha Papsch
eb762dea23
XmlDriver: Avoid PHP bug #62577 by avoiding simplexml_load_file.
...
Doctrine is affected by PHP bug #62577 . simplexml_load_file is not
able to load files if libxml_disable_entity_loader(true) has been
called. simplexml_load_file fails with the message:
I/O warning : failed to load external entity "/my/mappings/my_entity.dcm.xml"
in /path-to/lib/Doctrine/ORM/Mapping/Driver/XmlDriver.php on line 711
This error occurs even if there are no external entities in the XML file.
Waiting for the PHP bug to be resolved is infeasible, because it is
unresolved since years. Therefore Doctrine needs to circumvent the bug
by replacing simplexml_load_file with simplexml_load_string while getting
the file contents itself. simplexml_load_string is not affected by the
PHP bug.
2017-08-18 14:23:43 +02:00
Alessandro Lai
19bc4991ae
Add more CS fixes
2017-08-18 12:35:51 +02:00
Alessandro Lai
5224a89549
Apply various and CS fixes as per review
2017-08-18 11:02:28 +02:00
Alessandro Lai
d4db126bb0
Remove code duplication of the getAllDiscriminators method
2017-08-18 10:17:52 +02:00
Marco Pivetta
496c22db0e
#5579 completely removing a changeset when cleaning up
2017-08-18 09:27:47 +02:00
Marco Pivetta
ff15a2bc79
#5579 correcting visibility of clearEntityChangeSet, which should be reverted to public
2017-08-18 09:23:28 +02:00
Marco Pivetta
9d7be0f927
#5579 s/clear/cleanup
2017-08-18 09:22:23 +02:00
Marco Pivetta
2921f068b7
#5579 cleaning up postCommitClear implementation
2017-08-18 09:21:53 +02:00
xhuberty
866a424963
Fix issue when using notify tracking policy with multiple flush on entity
2017-08-18 09:07:40 +02:00
Marco Pivetta
94640aca88
Merge pull request #6441 from sensorario/remove-loosely-comparison
...
Verify that the `fileLockRegionDirectory` passed to the `DefaultCacheFactory` cannot be empty
2017-08-18 04:38:20 +02:00
Marco Pivetta
fda770700a
Merge pull request #6579 from Nek-/patch-1
...
Add string type as possible parameter for between
2017-08-18 04:33:04 +02:00
Marco Pivetta
bb994b9e70
Removing reference to deprecated YAML component constant that is ignored after symfony 3.4
2017-08-16 20:20:22 +02:00
Marco Pivetta
76e2155fb3
Merge branch 'feature/#6593-#5864-export-metadata-should-contain-entity-listeners'
...
Close #6593
Close #5864
ge aborts
2017-08-16 19:58:23 +02:00
Marco Pivetta
894490c2a0
#6593 #5864 removing incorrect null return value in API marked as string
2017-08-16 19:57:26 +02:00
Marco Pivetta
e1acba3ae4
#6593 #5864 reverted all public/protected API parameter and return type changes
...
That's still to be considered a BC break, since child classes are broken if incompatible.
Sorry @tPl0ch :-(
2017-08-16 19:53:32 +02:00
Marco Pivetta
71218b66b9
#6626 #6625 minor CS fixes (removed useless assignments)
2017-08-16 15:23:20 +02:00
Issei.M
9e837dc53c
Skip embeddable classes proxy generation
2017-08-16 15:23:20 +02:00
Marco Pivetta
ff3c89d8b1
#6623 minor code cleanups (removing useless assignments, array callback syntax)
2017-08-16 15:10:27 +02:00
Thomas Ploch
e4006e533c
[FX] Use single quotes for XML root in XmlExporter
2017-08-16 12:26:33 +02:00
Thomas Ploch
b1e091b0e1
[FX] Looking up PHP internal functions from the root namespace is faster
2017-08-16 12:25:31 +02:00
Thomas Ploch
599865528e
[CS] Remove obsolete doc blocks #2
2017-08-16 12:24:37 +02:00
Thomas Ploch
fe88422e68
[CS] Remove obsolete doc blocks
2017-08-16 12:24:00 +02:00
Thomas Ploch
741819f060
Revert "Minor coding style fixes and more docblock removal"
...
This reverts commit ec3eed68ca0551edc33fb1dc94a604d84857a122.
2017-08-15 10:28:43 +02:00
Thomas Ploch
ec3eed68ca
Minor coding style fixes and more docblock removal
2017-08-15 10:17:20 +02:00
Thomas Ploch
b7ae5b4afb
Entity listeners are now processed by exporters
...
The current implementation of the exporters are not taking the entity
listeners into account. I have added test cases for most of the edge
cases I could think of and implemented the Exporter handling.
This PR originates from https://github.com/doctrine/doctrine2/pull/5864 ,
I was overwhelmed by the amount of conflicts I had to resolve so I
started anew on a clean master HEAD.
Squashed commits:
- Code review aftermath
- Add even more return type declarations
- Added `return null` to methods declared with nullable return types
- Removed unneeded docblocks when types are self-explanatory
2017-08-15 10:08:50 +02:00
Nikolas Tsiongas
f0ed4e87b5
fix AbstractHydrator addEventListener on hydrateAll()
...
# Conflicts:
# tests/Doctrine/Tests/ORM/Functional/Ticket/DDC3146Test.php
2017-08-14 00:45:50 +02:00
Marco Pivetta
a0c0d3bf2a
Revert "Merge branch 'fix/#6499-#6533-fix-commit-order-calculation-consider-all-join-column-fields'"
...
This reverts commit 2a58645cb5870f0ab61e918c7165c248d225dbac, reversing
changes made to 6d428c90e24c914c1e5d817d74646f3b94757c43.
2017-08-11 22:29:45 +02:00
