Marco Pivetta
f6ce69fe29
#6303 #6304 minor CS fixes in the test code - alignment/formatting
2017-08-19 16:37:24 +02:00
Marco Pivetta
aaad25a061
#6303 #6304 reverting changes to the OrmFunctionalTestCase
2017-08-19 16:25:20 +02:00
Marco Pivetta
c503b81421
#6303 #6304 removing += operator usage on arrays (scary\!), CS (alignment)
2017-08-19 16:02:30 +02:00
Marco Pivetta
7e7921e32f
#6303 #6304 documenting why the loose comparison is required
2017-08-19 15:58:50 +02:00
fullbl
8cc29e84a0
Update AbstractHydrator.php
...
revert strict comparison in hydration (fails on some dates)
2017-08-19 15:56:59 +02:00
Full
db9c12f1af
comparison on discriminator value with !==
2017-08-19 15:56:59 +02:00
fullbl
82db643b4f
clarified what's the problem in a comment
2017-08-19 15:56:59 +02:00
Full
4c7286f57b
removed trailing spaces
2017-08-19 15:56:59 +02:00
Full
0072054020
moved all test models into test class
2017-08-19 15:56:59 +02:00
Full
0b8e468f06
fix wrong pharenthesis
2017-08-19 15:56:59 +02:00
Full
bf06b7dbbc
check if array is set before assigning
2017-08-19 15:56:59 +02:00
Full
ad3b9de4b8
use dataMap also in first test function
2017-08-19 15:56:59 +02:00
Full
6d40859228
added tests on empty values
2017-08-19 15:56:59 +02:00
Full
aac523d155
tests with custom inheritance tree
2017-08-19 15:56:59 +02:00
Marco Pivetta
671fd50725
Merge pull request #6572 from bitwombat/doc_changes
...
Add additional detail and clarifications on SELECT
2017-08-18 21:45:17 +02:00
Marco Pivetta
1a0bb82e1d
Merge pull request #6392 from Jean85/pr_1441_rebased
...
Correct DQL `INSTANCE OF` to filter all possible child classes
2017-08-18 21:35:54 +02:00
Marco Pivetta
a426808a16
Merge branch 'fix/#6633-#3788-avoid-xml-external-entity-loading-errors-in-xml-mapping-driver'
...
Close #6633
Close #3788
2017-08-18 21:12:37 +02:00
Marco Pivetta
492fb50744
#6633 #3788 documenting why simplexml_load_file() was not used
2017-08-18 21:08:14 +02:00
Alessandro Lai
c799c6da8b
Add new functional test to check usage of INSTANCEOF with multiple parameters
2017-08-18 14:49:56 +02:00
Aljosha Papsch
eb762dea23
XmlDriver: Avoid PHP bug #62577 by avoiding simplexml_load_file.
...
Doctrine is affected by PHP bug #62577 . simplexml_load_file is not
able to load files if libxml_disable_entity_loader(true) has been
called. simplexml_load_file fails with the message:
I/O warning : failed to load external entity "/my/mappings/my_entity.dcm.xml"
in /path-to/lib/Doctrine/ORM/Mapping/Driver/XmlDriver.php on line 711
This error occurs even if there are no external entities in the XML file.
Waiting for the PHP bug to be resolved is infeasible, because it is
unresolved since years. Therefore Doctrine needs to circumvent the bug
by replacing simplexml_load_file with simplexml_load_string while getting
the file contents itself. simplexml_load_string is not affected by the
PHP bug.
2017-08-18 14:23:43 +02:00
Alessandro Lai
19bc4991ae
Add more CS fixes
2017-08-18 12:35:51 +02:00
Alessandro Lai
9864a5a9b9
Add unit test for HierarchyDiscriminatorResolverTest
2017-08-18 12:11:09 +02:00
Alessandro Lai
5224a89549
Apply various and CS fixes as per review
2017-08-18 11:02:28 +02:00
Alessandro Lai
d4db126bb0
Remove code duplication of the getAllDiscriminators method
2017-08-18 10:17:52 +02:00
Marco Pivetta
60e29b40a0
Merge branch 'fix/#5579-fix-performance-of-single-entity-flush-with-notify-tracking-policy'
...
Close #5579
2017-08-18 09:30:43 +02:00
Marco Pivetta
496c22db0e
#5579 completely removing a changeset when cleaning up
2017-08-18 09:27:47 +02:00
Marco Pivetta
1bf8465f43
#5579 correcting assertion static/instance method usage
2017-08-18 09:25:47 +02:00
Marco Pivetta
ff15a2bc79
#5579 correcting visibility of clearEntityChangeSet, which should be reverted to public
2017-08-18 09:23:28 +02:00
Marco Pivetta
9d7be0f927
#5579 s/clear/cleanup
2017-08-18 09:22:23 +02:00
Marco Pivetta
2921f068b7
#5579 cleaning up postCommitClear implementation
2017-08-18 09:21:53 +02:00
Marco Pivetta
9707701d10
#5579 isolating multi-entity-commit and single-entity-commit scenarios for the tracking policy changeset clearing
2017-08-18 09:15:48 +02:00
Marco Pivetta
df1577db0c
#5579 cleaning up test case, adding assertions critical to the understanding of the code
2017-08-18 09:13:56 +02:00
xhuberty
866a424963
Fix issue when using notify tracking policy with multiple flush on entity
2017-08-18 09:07:40 +02:00
Greg Bell
74c83f3cec
Fix format and content as-per discussion in PR
2017-08-18 15:20:17 +10:00
Marco Pivetta
5770459bfc
#6441 moving expected exception annotations into explicit method calls
2017-08-18 04:44:17 +02:00
Marco Pivetta
94640aca88
Merge pull request #6441 from sensorario/remove-loosely-comparison
...
Verify that the `fileLockRegionDirectory` passed to the `DefaultCacheFactory` cannot be empty
2017-08-18 04:38:20 +02:00
Marco Pivetta
fda770700a
Merge pull request #6579 from Nek-/patch-1
...
Add string type as possible parameter for between
2017-08-18 04:33:04 +02:00
Marco Pivetta
da109c36b7
Merge pull request #6630 from doctrine/fix/remove-reliance-on-yaml-deprecated-constants
...
Remove reliance on Symfony\Component\Yaml deprecated constants
2017-08-16 20:52:18 +02:00
Marco Pivetta
40515472c1
Bumping ORM YAML dependency to 3.4+, explicitly forbidding compatibility with older YAML component versions
2017-08-16 20:21:26 +02:00
Marco Pivetta
bb994b9e70
Removing reference to deprecated YAML component constant that is ignored after symfony 3.4
2017-08-16 20:20:22 +02:00
Marco Pivetta
76e2155fb3
Merge branch 'feature/#6593-#5864-export-metadata-should-contain-entity-listeners'
...
Close #6593
Close #5864
ge aborts
2017-08-16 19:58:23 +02:00
Marco Pivetta
894490c2a0
#6593 #5864 removing incorrect null return value in API marked as string
2017-08-16 19:57:26 +02:00
Marco Pivetta
e1acba3ae4
#6593 #5864 reverted all public/protected API parameter and return type changes
...
That's still to be considered a BC break, since child classes are broken if incompatible.
Sorry @tPl0ch :-(
2017-08-16 19:53:32 +02:00
Marco Pivetta
9005c5afdd
Merge branch 'fix/#6626-skip-proxy-generation-for-embeddable-classes'
...
Close #6626
Close #6625
2017-08-16 15:23:46 +02:00
Marco Pivetta
71218b66b9
#6626 #6625 minor CS fixes (removed useless assignments)
2017-08-16 15:23:20 +02:00
Issei.M
0bc91f8733
Replace double quote with single quote
2017-08-16 15:23:20 +02:00
Issei.M
de6d932e8c
Fix CS / Add annotation
2017-08-16 15:23:20 +02:00
Issei.M
9e837dc53c
Skip embeddable classes proxy generation
2017-08-16 15:23:20 +02:00
Marco Pivetta
57a9509dec
Merge branch 'fix/#6623-#1515-ensure-abstracthydrator-hydrateall-cleans-up-on-unit-of-work-clear'
...
Close #6623
2017-08-16 15:10:38 +02:00
Marco Pivetta
ff3c89d8b1
#6623 minor code cleanups (removing useless assignments, array callback syntax)
2017-08-16 15:10:27 +02:00
