Marco Pivetta
492fb50744
#6633 #3788 documenting why simplexml_load_file() was not used
2017-08-18 21:08:14 +02:00
Aljosha Papsch
eb762dea23
XmlDriver: Avoid PHP bug #62577 by avoiding simplexml_load_file.
...
Doctrine is affected by PHP bug #62577 . simplexml_load_file is not
able to load files if libxml_disable_entity_loader(true) has been
called. simplexml_load_file fails with the message:
I/O warning : failed to load external entity "/my/mappings/my_entity.dcm.xml"
in /path-to/lib/Doctrine/ORM/Mapping/Driver/XmlDriver.php on line 711
This error occurs even if there are no external entities in the XML file.
Waiting for the PHP bug to be resolved is infeasible, because it is
unresolved since years. Therefore Doctrine needs to circumvent the bug
by replacing simplexml_load_file with simplexml_load_string while getting
the file contents itself. simplexml_load_string is not affected by the
PHP bug.
2017-08-18 14:23:43 +02:00
Alessandro Lai
19bc4991ae
Add more CS fixes
2017-08-18 12:35:51 +02:00
Alessandro Lai
5224a89549
Apply various and CS fixes as per review
2017-08-18 11:02:28 +02:00
Alessandro Lai
d4db126bb0
Remove code duplication of the getAllDiscriminators method
2017-08-18 10:17:52 +02:00
Marco Pivetta
496c22db0e
#5579 completely removing a changeset when cleaning up
2017-08-18 09:27:47 +02:00
Marco Pivetta
ff15a2bc79
#5579 correcting visibility of clearEntityChangeSet, which should be reverted to public
2017-08-18 09:23:28 +02:00
Marco Pivetta
9d7be0f927
#5579 s/clear/cleanup
2017-08-18 09:22:23 +02:00
Marco Pivetta
2921f068b7
#5579 cleaning up postCommitClear implementation
2017-08-18 09:21:53 +02:00
xhuberty
866a424963
Fix issue when using notify tracking policy with multiple flush on entity
2017-08-18 09:07:40 +02:00
Marco Pivetta
94640aca88
Merge pull request #6441 from sensorario/remove-loosely-comparison
...
Verify that the `fileLockRegionDirectory` passed to the `DefaultCacheFactory` cannot be empty
2017-08-18 04:38:20 +02:00
Marco Pivetta
fda770700a
Merge pull request #6579 from Nek-/patch-1
...
Add string type as possible parameter for between
2017-08-18 04:33:04 +02:00
Marco Pivetta
bb994b9e70
Removing reference to deprecated YAML component constant that is ignored after symfony 3.4
2017-08-16 20:20:22 +02:00
Marco Pivetta
76e2155fb3
Merge branch 'feature/#6593-#5864-export-metadata-should-contain-entity-listeners'
...
Close #6593
Close #5864
ge aborts
2017-08-16 19:58:23 +02:00
Marco Pivetta
894490c2a0
#6593 #5864 removing incorrect null return value in API marked as string
2017-08-16 19:57:26 +02:00
Marco Pivetta
e1acba3ae4
#6593 #5864 reverted all public/protected API parameter and return type changes
...
That's still to be considered a BC break, since child classes are broken if incompatible.
Sorry @tPl0ch :-(
2017-08-16 19:53:32 +02:00
Marco Pivetta
71218b66b9
#6626 #6625 minor CS fixes (removed useless assignments)
2017-08-16 15:23:20 +02:00
Issei.M
9e837dc53c
Skip embeddable classes proxy generation
2017-08-16 15:23:20 +02:00
Marco Pivetta
ff3c89d8b1
#6623 minor code cleanups (removing useless assignments, array callback syntax)
2017-08-16 15:10:27 +02:00
Thomas Ploch
e4006e533c
[FX] Use single quotes for XML root in XmlExporter
2017-08-16 12:26:33 +02:00
Thomas Ploch
b1e091b0e1
[FX] Looking up PHP internal functions from the root namespace is faster
2017-08-16 12:25:31 +02:00
Thomas Ploch
599865528e
[CS] Remove obsolete doc blocks #2
2017-08-16 12:24:37 +02:00
Thomas Ploch
fe88422e68
[CS] Remove obsolete doc blocks
2017-08-16 12:24:00 +02:00
Thomas Ploch
741819f060
Revert "Minor coding style fixes and more docblock removal"
...
This reverts commit ec3eed68ca0551edc33fb1dc94a604d84857a122.
2017-08-15 10:28:43 +02:00
Thomas Ploch
ec3eed68ca
Minor coding style fixes and more docblock removal
2017-08-15 10:17:20 +02:00
Thomas Ploch
b7ae5b4afb
Entity listeners are now processed by exporters
...
The current implementation of the exporters are not taking the entity
listeners into account. I have added test cases for most of the edge
cases I could think of and implemented the Exporter handling.
This PR originates from https://github.com/doctrine/doctrine2/pull/5864 ,
I was overwhelmed by the amount of conflicts I had to resolve so I
started anew on a clean master HEAD.
Squashed commits:
- Code review aftermath
- Add even more return type declarations
- Added `return null` to methods declared with nullable return types
- Removed unneeded docblocks when types are self-explanatory
2017-08-15 10:08:50 +02:00
Nikolas Tsiongas
f0ed4e87b5
fix AbstractHydrator addEventListener on hydrateAll()
...
# Conflicts:
# tests/Doctrine/Tests/ORM/Functional/Ticket/DDC3146Test.php
2017-08-14 00:45:50 +02:00
Marco Pivetta
a0c0d3bf2a
Revert "Merge branch 'fix/#6499-#6533-fix-commit-order-calculation-consider-all-join-column-fields'"
...
This reverts commit 2a58645cb5870f0ab61e918c7165c248d225dbac, reversing
changes made to 6d428c90e24c914c1e5d817d74646f3b94757c43.
2017-08-11 22:29:45 +02:00
Marco Pivetta
1ede3c514f
#6499 #6533 simplifying nullable column check - null coalesce operator makes it *SOMEWHAT* more readable (no miracles)
2017-08-11 22:13:20 +02:00
Gabe van der Weijde
db2530d6fd
-- Proposed fix due to logic error.
2017-08-11 21:51:17 +02:00
Marco Pivetta
9ad91ddc1c
#6464 #6475 using PHP 7.1 void and string return hints where available
2017-08-11 21:45:23 +02:00
Stefan Siegl
025ed1147b
#6464 code review updates
2017-08-11 21:36:33 +02:00
Stefan Siegl
99fdbf550d
generate nested join sql for CTIs, closes #6464
2017-08-11 21:36:33 +02:00
Marco Pivetta
c2dd274c42
#6613 #6614 #6616 adding void return type
2017-08-11 21:27:09 +02:00
Marco Pivetta
004ac51869
#6613 #6614 #6616 minor performance optimisations around the new restoreNewObjectsInDirtyCollection implementation
2017-08-11 21:14:05 +02:00
Marco Pivetta
a2ca6bbfaf
#6613 #6614 #6616 ensuring that the collection is marked as non-dirty if all new items are contained in the initialized ones
2017-08-11 21:09:34 +02:00
Marco Pivetta
d44e6e1a9e
#6613 #6614 ensuring that only newly added items that weren't loaded are restored in the dirty state of the collection
2017-08-11 15:13:39 +02:00
Alfredo Costa
8952176c73
Add message to NonUniqueResultException
2017-08-06 12:07:47 +02:00
Martin Georgiev
30088fe529
Fix double spacing in exception's message
2017-08-03 11:52:06 +01:00
Maxime Veber
03d33ec900
Add string type as possible parameter for between
...
People may want to enter a date, or simply the parameter name. Linter may report an error while it's a good usage.
2017-07-24 14:23:16 +02:00
Luís Cobucci
eba8fec1fb
Move identifier types extraction to a method
2017-07-22 22:39:47 +02:00
Alessandro Frangioni
60a2628f9d
Iteration simplified
2017-07-22 22:26:31 +02:00
Alessandro Frangioni
4ef0a238bf
Inferring id's field types
2017-07-22 22:26:31 +02:00
Alessandro Frangioni
af3591fbca
Fixes #5804
2017-07-22 22:26:31 +02:00
Luís Cobucci
5109322f7d
Make explicit the design decisions of ConsoleRunner
2017-07-22 21:56:59 +02:00
Luís Cobucci
2b824ea9df
Update ConsoleRunner command list
...
Adding L2C commands and DBAL reserved words command.
2017-07-22 21:56:42 +02:00
Luís Cobucci
5389ad7261
Make LimitSubqueryOutputWalker a bit more readable
...
Also simplifying the REGEX to remove the ORDER BY type (ASC/DESC) with a
substr() since OrderByItem#type is always defined.
2017-07-22 20:34:18 +02:00
chihiro-adachi
60601a9323
fix query and tests
2017-07-22 19:28:28 +02:00
Martin Kirilov
854ff17ab9
Should fix MySQL 5.7 issues caused by ONLY_FULL_GROUP_BY
...
Should fix MySQL 5.7 issues caused by ONLY_FULL_GROUP_BY
2017-07-22 19:28:28 +02:00
Andreas Braun
260cc6e3e0
Fix return of removeElement on collections
...
Fixes #5745
2017-07-13 08:16:00 +02:00
