diff --git a/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php b/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php index a562d28f3..aa6e038be 100644 --- a/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php +++ b/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php @@ -774,9 +774,13 @@ class ClassMetadataInfo implements ClassMetadata // If targetEntity is unqualified, assume it is in the same namespace as // the sourceEntity. $mapping['sourceEntity'] = $this->name; - if (isset($mapping['targetEntity']) && strpos($mapping['targetEntity'], '\\') === false - && strlen($this->namespace) > 0) { - $mapping['targetEntity'] = $this->namespace . '\\' . $mapping['targetEntity']; + + if (isset($mapping['targetEntity'])) { + if (strlen($this->namespace) > 0 && strpos($mapping['targetEntity'], '\\') === false) { + $mapping['targetEntity'] = $this->namespace . '\\' . $mapping['targetEntity']; + } + + $mapping['targetEntity'] = ltrim($mapping['targetEntity'], '\\'); } // Complete id mapping @@ -1625,11 +1629,13 @@ class ClassMetadataInfo implements ClassMetadata public function setDiscriminatorMap(array $map) { foreach ($map as $value => $className) { - if (strpos($className, '\\') === false && strlen($this->namespace)) { + if (strlen($this->namespace) > 0 && strpos($className, '\\') === false) { $className = $this->namespace . '\\' . $className; } + $className = ltrim($className, '\\'); $this->discriminatorMap[$value] = $className; + if ($this->name == $className) { $this->discriminatorValue = $value; } else { diff --git a/lib/Doctrine/ORM/Query.php b/lib/Doctrine/ORM/Query.php index 820711d55..9d5ad8cb3 100644 --- a/lib/Doctrine/ORM/Query.php +++ b/lib/Doctrine/ORM/Query.php @@ -238,50 +238,85 @@ final class Query extends AbstractQuery throw QueryException::invalidParameterNumber(); } - $sqlParams = $types = array(); - - foreach ($this->_params as $key => $value) { - if ( ! isset($paramMappings[$key])) { - throw QueryException::unknownParameter($key); - } - if (isset($this->_paramTypes[$key])) { - foreach ($paramMappings[$key] as $position) { - $types[$position] = $this->_paramTypes[$key]; - } - } - - if (is_object($value) && $this->_em->getMetadataFactory()->hasMetadataFor(get_class($value))) { - if ($this->_em->getUnitOfWork()->getEntityState($value) == UnitOfWork::STATE_MANAGED) { - $idValues = $this->_em->getUnitOfWork()->getEntityIdentifier($value); - } else { - $class = $this->_em->getClassMetadata(get_class($value)); - $idValues = $class->getIdentifierValues($value); - } - $sqlPositions = $paramMappings[$key]; - $cSqlPos = count($sqlPositions); - $cIdValues = count($idValues); - $idValues = array_values($idValues); - for ($i = 0; $i < $cSqlPos; $i++) { - $sqlParams[$sqlPositions[$i]] = $idValues[ ($i % $cIdValues) ]; - } - } else { - foreach ($paramMappings[$key] as $position) { - $sqlParams[$position] = $value; - } - } - } - - if ($sqlParams) { - ksort($sqlParams); - $sqlParams = array_values($sqlParams); - } - + list($sqlParams, $types) = $this->processParameterMappings($paramMappings); + if ($this->_resultSetMapping === null) { $this->_resultSetMapping = $this->_parserResult->getResultSetMapping(); } return $executor->execute($this->_em->getConnection(), $sqlParams, $types); } + + /** + * Processes query parameter mappings + * + * @param array $paramMappings + * @return array + */ + private function processParameterMappings($paramMappings) + { + $sqlParams = $types = array(); + + foreach ($this->_params as $key => $value) { + if ( ! isset($paramMappings[$key])) { + throw QueryException::unknownParameter($key); + } + + if (isset($this->_paramTypes[$key])) { + foreach ($paramMappings[$key] as $position) { + $types[$position] = $this->_paramTypes[$key]; + } + } + + $sqlPositions = $paramMappings[$key]; + $value = array_values($this->processParameterValue($value)); + $countValue = count($value); + + for ($i = 0, $l = count($sqlPositions); $i < $l; $i++) { + $sqlParams[$sqlPositions[$i]] = $value[($i % $countValue)]; + } + } + + if ($sqlParams) { + ksort($sqlParams); + $sqlParams = array_values($sqlParams); + } + + return array($sqlParams, $types); + } + + /** + * Process an individual parameter value + * + * @param mixed $value + * @return array + */ + private function processParameterValue($value) + { + switch (true) { + case is_array($value): + for ($i = 0, $l = count($value); $i < $l; $i++) { + $paramValue = $this->processParameterValue($value[$i]); + + // TODO: What about Entities that have composite primary key? + $value[$i] = is_array($paramValue) ? $paramValue[key($paramValue)] : $paramValue; + } + + return array($value); + + case is_object($value) && $this->_em->getMetadataFactory()->hasMetadataFor(get_class($value)): + if ($this->_em->getUnitOfWork()->getEntityState($value) === UnitOfWork::STATE_MANAGED) { + return array_values($this->_em->getUnitOfWork()->getEntityIdentifier($value)); + } + + $class = $this->_em->getClassMetadata(get_class($value)); + + return array_values($class->getIdentifierValues($value)); + + default: + return array($value); + } + } /** * Defines a cache driver to be used for caching queries. diff --git a/lib/Doctrine/ORM/Tools/Export/Driver/YamlExporter.php b/lib/Doctrine/ORM/Tools/Export/Driver/YamlExporter.php index 36e272246..03074bb0c 100644 --- a/lib/Doctrine/ORM/Tools/Export/Driver/YamlExporter.php +++ b/lib/Doctrine/ORM/Tools/Export/Driver/YamlExporter.php @@ -81,6 +81,10 @@ class YamlExporter extends AbstractExporter $array['indexes'] = $metadata->table['indexes']; } + if ($metadata->customRepositoryClassName) { + $array['repositoryClass'] = $metadata->customRepositoryClassName; + } + if (isset($metadata->table['uniqueConstraints'])) { $array['uniqueConstraints'] = $metadata->table['uniqueConstraints']; } diff --git a/tests/Doctrine/Tests/ORM/Functional/QueryTest.php b/tests/Doctrine/Tests/ORM/Functional/QueryTest.php index 82180a4ed..993ce1642 100644 --- a/tests/Doctrine/Tests/ORM/Functional/QueryTest.php +++ b/tests/Doctrine/Tests/ORM/Functional/QueryTest.php @@ -501,4 +501,36 @@ class QueryTest extends \Doctrine\Tests\OrmFunctionalTestCase $this->assertEquals(0, count($users)); } + + public function testQueryWithArrayOfEntitiesAsParameter() + { + $userA = new CmsUser; + $userA->name = 'Benjamin'; + $userA->username = 'beberlei'; + $userA->status = 'developer'; + $this->_em->persist($userA); + + $userB = new CmsUser; + $userB->name = 'Roman'; + $userB->username = 'romanb'; + $userB->status = 'developer'; + $this->_em->persist($userB); + + $userC = new CmsUser; + $userC->name = 'Jonathan'; + $userC->username = 'jwage'; + $userC->status = 'developer'; + $this->_em->persist($userC); + + $this->_em->flush(); + $this->_em->clear(); + + $query = $this->_em->createQuery("SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u WHERE u IN (?0) OR u.username = ?1"); + $query->setParameter(0, array($userA, $userC)); + $query->setParameter(1, 'beberlei'); + + $users = $query->execute(); + + $this->assertEquals(2, count($users)); + } } \ No newline at end of file