From 2e81fbfd64a18ad025b68ebf7498788be3f16e7e Mon Sep 17 00:00:00 2001 From: Andreas Hucks Date: Tue, 14 Feb 2012 19:07:51 +0100 Subject: [PATCH 1/3] added type hint --- lib/Doctrine/ORM/Proxy/ProxyFactory.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Doctrine/ORM/Proxy/ProxyFactory.php b/lib/Doctrine/ORM/Proxy/ProxyFactory.php index ed5d1560c..7e01ad7c2 100644 --- a/lib/Doctrine/ORM/Proxy/ProxyFactory.php +++ b/lib/Doctrine/ORM/Proxy/ProxyFactory.php @@ -143,7 +143,7 @@ class ProxyFactory * @param $proxyClassName * @param $file The path of the file to write to. */ - private function _generateProxyClass($class, $fileName, $file) + private function _generateProxyClass(ClassMetadata $class, $fileName, $file) { $methods = $this->_generateMethods($class); $sleepImpl = $this->_generateSleep($class); From 3419c65efee24788e603820deeb6c66aba7e0bc6 Mon Sep 17 00:00:00 2001 From: Andreas Hucks Date: Tue, 14 Feb 2012 19:08:44 +0100 Subject: [PATCH 2/3] fixed docblock --- lib/Doctrine/ORM/Proxy/ProxyFactory.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/Doctrine/ORM/Proxy/ProxyFactory.php b/lib/Doctrine/ORM/Proxy/ProxyFactory.php index 7e01ad7c2..bb8de3d19 100644 --- a/lib/Doctrine/ORM/Proxy/ProxyFactory.php +++ b/lib/Doctrine/ORM/Proxy/ProxyFactory.php @@ -139,9 +139,9 @@ class ProxyFactory /** * Generates a proxy class file. * - * @param $class - * @param $proxyClassName - * @param $file The path of the file to write to. + * @param ClassMetadata $class Metadata for the original class + * @param string $fileName Filename (full path) for the generated class + * @param string $file The proxy class template data */ private function _generateProxyClass(ClassMetadata $class, $fileName, $file) { From 1d927541e2a2406b3360ec5370b525ec32bfa94f Mon Sep 17 00:00:00 2001 From: Andreas Hucks Date: Tue, 14 Feb 2012 19:12:20 +0100 Subject: [PATCH 3/3] added type hint --- lib/Doctrine/ORM/Proxy/ProxyFactory.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Doctrine/ORM/Proxy/ProxyFactory.php b/lib/Doctrine/ORM/Proxy/ProxyFactory.php index bb8de3d19..50bf18a7c 100644 --- a/lib/Doctrine/ORM/Proxy/ProxyFactory.php +++ b/lib/Doctrine/ORM/Proxy/ProxyFactory.php @@ -272,7 +272,7 @@ class ProxyFactory * @param ClassMetadata $class * @return bool */ - private function isShortIdentifierGetter($method, $class) + private function isShortIdentifierGetter($method, ClassMetadata $class) { $identifier = lcfirst(substr($method->getName(), 3)); $cheapCheck = (