Merge and modify juokazs Sqlsrv changes

lib/Doctrine/ORM/Persisters/BasicEntityPersister.php

@@ -844,8 +844,8 @@ class BasicEntityPersister
         }
 
         return 'SELECT ' . $this->_getSelectColumnListSQL() 
-             . ' FROM ' . $this->_class->getQuotedTableName($this->_platform) . ' '
+             . $this->_platform->appendLockHint(' FROM ' . $this->_class->getQuotedTableName($this->_platform) . ' '
-             . $this->_getSQLTableAlias($this->_class->name)
+             . $this->_getSQLTableAlias($this->_class->name), $lockMode)
              . $joinSql
              . ($conditionSql ? ' WHERE ' . $conditionSql : '')
              . $orderBySql 
@@ -1082,7 +1082,7 @@ class BasicEntityPersister
         }
 
         $sql = 'SELECT 1 '
-             . $this->getLockTablesSql()
+             . $this->_platform->appendLockHint($this->getLockTablesSql(), $lockMode)
              . ($conditionSql ? ' WHERE ' . $conditionSql : '') . ' ' . $lockSql;
         $params = array_values($criteria);
         $this->_conn->executeQuery($sql, $params);

lib/Doctrine/ORM/Query/AST/Functions/LengthFunction.php

@@ -41,8 +41,9 @@ class LengthFunction extends FunctionNode
      */
     public function getSql(\Doctrine\ORM\Query\SqlWalker $sqlWalker)
     {
-        //TODO: Use platform to get SQL
+        return $sqlWalker->getConnection()->getDatabasePlatform()->getLengthExpression(
-        return 'LENGTH(' . $sqlWalker->walkStringPrimary($this->stringPrimary) . ')';
+               $sqlWalker->walkSimpleArithmeticExpression($this->stringPrimary)
+        );
     }
 
     /**

lib/Doctrine/ORM/Query/AST/Functions/LowerFunction.php

@@ -41,8 +41,9 @@ class LowerFunction extends FunctionNode
      */
     public function getSql(\Doctrine\ORM\Query\SqlWalker $sqlWalker)
     {
-        //TODO: Use platform to get SQL
+        return $sqlWalker->getConnection()->getDatabasePlatform()->getLowerExpression(
-        return 'LOWER(' . $sqlWalker->walkStringPrimary($this->stringPrimary) . ')';
+               $sqlWalker->walkSimpleArithmeticExpression($this->stringPrimary)
+        );
     }
 
     /**

lib/Doctrine/ORM/Query/AST/Functions/ModFunction.php

@@ -42,12 +42,10 @@ class ModFunction extends FunctionNode
      */
     public function getSql(\Doctrine\ORM\Query\SqlWalker $sqlWalker)
     {
-        //TODO: Use platform to get SQL
+        return $sqlWalker->getConnection()->getDatabasePlatform()->getModExpression(
-        return 'MOD(' 
+               $sqlWalker->walkSimpleArithmeticExpression($this->firstSimpleArithmeticExpression),
-             . $sqlWalker->walkSimpleArithmeticExpression($this->firstSimpleArithmeticExpression)
+               $sqlWalker->walkSimpleArithmeticExpression($this->secondSimpleArithmeticExpression)
-             . ', ' 
+        );
-             . $sqlWalker->walkSimpleArithmeticExpression($this->secondSimpleArithmeticExpression) 
-             . ')';
     }
 
     /**

lib/Doctrine/ORM/Query/AST/Functions/UpperFunction.php

@@ -41,8 +41,9 @@ class UpperFunction extends FunctionNode
      */
     public function getSql(\Doctrine\ORM\Query\SqlWalker $sqlWalker)
     {
-        //TODO: Use platform to get SQL
+        return $sqlWalker->getConnection()->getDatabasePlatform()->getUpperExpression(
-        return 'UPPER(' . $sqlWalker->walkStringPrimary($this->stringPrimary) . ')';
+               $sqlWalker->walkSimpleArithmeticExpression($this->stringPrimary)
+        );
     }
 
     /**

lib/Doctrine/ORM/Tools/SchemaTool.php

@@ -185,6 +185,8 @@ class SchemaTool
                     $idMapping = $class->fieldMappings[$class->identifier[0]];
                     $this->_gatherColumn($class, $idMapping, $table);
                     $columnName = $class->getQuotedColumnName($class->identifier[0], $this->_platform);
+                    // TODO: This seems rather hackish, can we optimize it?
+                    $table->getColumn($class->identifier[0])->setAutoincrement(false);
 
                     $pkColumns[] = $columnName;
                     // TODO: REMOVE

tests/Doctrine/Tests/Models/DirectoryTree/File.php

@@ -43,4 +43,4 @@ class File extends AbstractContentItem
     {
         $this->extension = $ext;
     }
-}
+}

tests/Doctrine/Tests/ORM/Functional/Ticket/DDC809Test.php

@@ -66,7 +66,6 @@ class DDC809Variant
     /**
      * @Column(name="variant_id", type="integer")
      * @Id
-     * @GeneratedValue(strategy="AUTO")
      */
     protected $variantId;
 
@@ -98,7 +97,6 @@ class DDC809SpecificationValue
     /**
      * @Column(name="specification_value_id", type="integer")
      * @Id
-     * @GeneratedValue(strategy="AUTO")
      */
     protected $specificationValueId;
 

tests/Doctrine/Tests/ORM/Query/SelectSqlGenerationTest.php

@@ -874,4 +874,4 @@ class MyAbsFunction extends \Doctrine\ORM\Query\AST\Functions\FunctionNode
         
         $parser->match(\Doctrine\ORM\Query\Lexer::T_CLOSE_PARENTHESIS);
     }
-}
+}