RetailCRM-Mirror/doctrine2
1
0
Fork 0
mirror of synced 2025-02-13 10:49:25 +03:00
Code Issues Projects Releases Wiki Activity

DDC-4022 deduplication of internal UnitOfWork methods

Browse Source 
the methods UnitOfWork#afterTransactionRolledBack() and UnitOfWork#afterTransactionComplete do almost the same, so it can be abstracted into another private method.
This commit is contained in:
Maximilian Bosch 2015-11-30 16:22:11 +01:00 committed by Ma27
parent 3c3b7364ba
commit c337f8f5c7
1 changed files with 17 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
lib/Doctrine/ORM/UnitOfWork.php
View File

@ -3259,21 +3259,9 @@ class UnitOfWork implements PropertyChangedListener
*/ */
private function afterTransactionComplete() private function afterTransactionComplete()
{ {
if ( ! $this->hasCache) { $this->doAfterTransaction(function (CachedPersister $persister) {
return;
}
foreach ($this->persisters as $persister) {
if ($persister instanceof CachedPersister) {
$persister->afterTransactionComplete(); $persister->afterTransactionComplete();
} });
}
foreach ($this->collectionPersisters as $persister) {
if ($persister instanceof CachedPersister) {
$persister->afterTransactionComplete();
}
}
} }
/** /**
@ -3281,19 +3269,23 @@ class UnitOfWork implements PropertyChangedListener
*/ */
private function afterTransactionRolledBack() private function afterTransactionRolledBack()
{ {
if ( ! $this->hasCache) { $this->doAfterTransaction(function (CachedPersister $persister) {
$persister->afterTransactionRolledBack();
});
}
/**
* Performs an action after the transaction.
*/
private function doAfterTransaction(callable $callback)
{
if (!$this->hasCache) {
return; return;
} }
foreach ($this->persisters as $persister) { foreach (array_merge($this->persisters, $this->collectionPersisters) as $persister) {
if ($persister instanceof CachedPersister) { if ($persister instanceof CachedPersister) {
$persister->afterTransactionRolledBack(); call_user_func($callback, $persister);
}
}
foreach ($this->collectionPersisters as $persister) {
if ($persister instanceof CachedPersister) {
$persister->afterTransactionRolledBack();
} }
} }
} }