1
0
mirror of synced 2025-02-02 21:41:45 +03:00

#6613 #6614 #6616 adding void return type

This commit is contained in:
Marco Pivetta 2017-08-11 21:27:09 +02:00
parent 004ac51869
commit c2dd274c42
No known key found for this signature in database
GPG Key ID: 4167D3337FD9D629

View File

@ -710,14 +710,12 @@ final class PersistentCollection extends AbstractLazyCollection implements Selec
/**
* @param object[] $newObjects
*
* @return void
*
* Note: the only reason why this entire looping/complexity is performed via `spl_object_hash`
* is because we want to prevent using `array_udiff()`, which is likely to cause very
* high overhead (complexity of O(n^2)). `array_diff_key()` performs the operation in
* core, which is faster than using a callback for comparisons
*/
private function restoreNewObjectsInDirtyCollection(array $newObjects)
private function restoreNewObjectsInDirtyCollection(array $newObjects) : void
{
$loadedObjects = $this->collection->toArray();
$newObjectsByOid = \array_combine(\array_map('spl_object_hash', $newObjects), $newObjects);