diff --git a/lib/Doctrine/ORM/UnitOfWork.php b/lib/Doctrine/ORM/UnitOfWork.php index 3aefcc6c5..fb41899e0 100644 --- a/lib/Doctrine/ORM/UnitOfWork.php +++ b/lib/Doctrine/ORM/UnitOfWork.php @@ -658,7 +658,7 @@ class UnitOfWork implements PropertyChangedListener if ($changeSet) { if (isset($this->_entityChangeSets[$oid])) { - $this->_entityChangeSets[$oid] = $changeSet + $this->_entityChangeSets[$oid]; + $this->_entityChangeSets[$oid] = array_merge($this->_entityChangeSets[$oid], $changeSet); } $this->_originalEntityData[$oid] = $actualData; } diff --git a/tests/Doctrine/Tests/ORM/Functional/Ticket/DDC656Test.php b/tests/Doctrine/Tests/ORM/Functional/Ticket/DDC656Test.php new file mode 100644 index 000000000..bd8ce5357 --- /dev/null +++ b/tests/Doctrine/Tests/ORM/Functional/Ticket/DDC656Test.php @@ -0,0 +1,82 @@ +_schemaTool->createSchema(array( + $this->_em->getClassMetadata(__NAMESPACE__ . '\DDC656Entity') + )); + } catch(\Exception $e) { + + } + } + + public function testRecomputeSingleEntityChangeSet_PreservesFieldOrder() + { + $entity = new DDC656Entity(); + $entity->setName('test1'); + $entity->setType('type1'); + $this->_em->persist($entity); + + $this->_em->getUnitOfWork()->computeChangeSet($this->_em->getClassMetadata(get_class($entity)), $entity); + $data1 = $this->_em->getUnitOfWork()->getEntityChangeset($entity); + $entity->setType('type2'); + $this->_em->getUnitOfWork()->recomputeSingleEntityChangeSet($this->_em->getClassMetadata(get_class($entity)), $entity); + $data2 = $this->_em->getUnitOfWork()->getEntityChangeset($entity); + + $this->assertEquals(array_keys($data1), array_keys($data2)); + + $this->_em->flush(); + $this->_em->clear(); + + $persistedEntity = $this->_em->find(get_class($entity), $entity->specificationId); + $this->assertEquals('type2', $persistedEntity->getType()); + $this->assertEquals('test1', $persistedEntity->getName()); + } +} + +/** + * @Entity + */ +class DDC656Entity +{ + /** + * @Column(type="string") + */ + public $name; + + /** + * @Column(type="string") + */ + public $type; + + /** + * @Id @Column(type="integer") @GeneratedValue + */ + public $specificationId; + + public function getName() { + return $this->name; + } + + public function setName($name) { + $this->name = $name; + } + + public function getType() { + return $this->type; + } + + public function setType($type) { + $this->type = $type; + } +} \ No newline at end of file