From ac67a10d4c2a488d67e93d0029d554b110887be6 Mon Sep 17 00:00:00 2001 From: Marco Pivetta Date: Fri, 5 Dec 2014 18:02:12 +0100 Subject: [PATCH] DDC-3434 - adding note on why restoring 'HIDDEN' selected fields is relevant --- .../ORM/Tools/Pagination/LimitSubqueryOutputWalker.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/Doctrine/ORM/Tools/Pagination/LimitSubqueryOutputWalker.php b/lib/Doctrine/ORM/Tools/Pagination/LimitSubqueryOutputWalker.php index 9b1753b51..338920b2e 100644 --- a/lib/Doctrine/ORM/Tools/Pagination/LimitSubqueryOutputWalker.php +++ b/lib/Doctrine/ORM/Tools/Pagination/LimitSubqueryOutputWalker.php @@ -93,7 +93,8 @@ class LimitSubqueryOutputWalker extends SqlWalker public function walkSelectStatement(SelectStatement $AST) { // Set every select expression as visible(hidden = false) to - // make $AST to have scalar mappings properly + // make $AST have scalar mappings properly - this is relevant for referencing selected + // fields from outside the subquery, for example in the ORDER BY segment $hiddens = array(); foreach ($AST->selectClause->selectExpressions as $idx => $expr) {