diff --git a/lib/Doctrine/ORM/Tools/Pagination/LimitSubqueryOutputWalker.php b/lib/Doctrine/ORM/Tools/Pagination/LimitSubqueryOutputWalker.php index 2ee5f9056..6598cf2b1 100644 --- a/lib/Doctrine/ORM/Tools/Pagination/LimitSubqueryOutputWalker.php +++ b/lib/Doctrine/ORM/Tools/Pagination/LimitSubqueryOutputWalker.php @@ -100,9 +100,9 @@ class LimitSubqueryOutputWalker extends SqlWalker $hiddens[$idx] = $expr->hiddenAliasResultVariable; $expr->hiddenAliasResultVariable = false; } - + $innerSql = parent::walkSelectStatement($AST); - + // Restore hiddens foreach ($AST->selectClause->selectExpressions as $idx => $expr) { $expr->hiddenAliasResultVariable = $hiddens[$idx]; @@ -160,11 +160,8 @@ class LimitSubqueryOutputWalker extends SqlWalker $sql = sprintf('SELECT DISTINCT %s FROM (%s) dctrn_result', implode(', ', $sqlIdentifier), $innerSql); - if ($this->platform instanceof PostgreSqlPlatform || - $this->platform instanceof OraclePlatform) { - //http://www.doctrine-project.org/jira/browse/DDC-1958 - $this->preserveSqlOrdering($AST, $sqlIdentifier, $innerSql, $sql); - } + // http://www.doctrine-project.org/jira/browse/DDC-1958 + $sql = $this->preserveSqlOrdering($AST, $sqlIdentifier, $innerSql, $sql); // Apply the limit and offset. $sql = $this->platform->modifyLimitQuery( @@ -181,7 +178,7 @@ class LimitSubqueryOutputWalker extends SqlWalker return $sql; } - + /** * Generates new SQL for Postgresql or Oracle if necessary. * @@ -192,7 +189,7 @@ class LimitSubqueryOutputWalker extends SqlWalker * * @return void */ - public function preserveSqlOrdering(SelectStatement $AST, array $sqlIdentifier, $innerSql, &$sql) + public function preserveSqlOrdering(SelectStatement $AST, array $sqlIdentifier, $innerSql, $sql) { // For every order by, find out the SQL alias by inspecting the ResultSetMapping. $sqlOrderColumns = array(); @@ -215,11 +212,6 @@ class LimitSubqueryOutputWalker extends SqlWalker $sqlOrderColumns = array_diff($sqlOrderColumns, $sqlIdentifier); } - // We don't need orderBy in inner query. - // However at least on 5.4.6 I'm getting a segmentation fault and thus we don't clear it for now. - /*$AST->orderByClause = null; - $innerSql = parent::walkSelectStatement($AST);*/ - if (count($orderBy)) { $sql = sprintf( 'SELECT DISTINCT %s FROM (%s) dctrn_result ORDER BY %s', @@ -228,5 +220,7 @@ class LimitSubqueryOutputWalker extends SqlWalker implode(', ', $orderBy) ); } + + return $sql; } }