diff --git a/lib/Doctrine/ORM/Query/SqlWalker.php b/lib/Doctrine/ORM/Query/SqlWalker.php index 92cb3d757..0fb389de0 100644 --- a/lib/Doctrine/ORM/Query/SqlWalker.php +++ b/lib/Doctrine/ORM/Query/SqlWalker.php @@ -2272,7 +2272,9 @@ class SqlWalker implements TreeWalker public function walkArithmeticFactor($factor) { if (is_string($factor)) { - return $factor; + return (isset($this->queryComponents[$factor])) + ? $this->walkResultVariable($this->queryComponents[$factor]['token']['value']) + : $factor; } // Phase 2 AST optimization: Skip processing of ArithmeticFactor diff --git a/tests/Doctrine/Tests/ORM/Query/SelectSqlGenerationTest.php b/tests/Doctrine/Tests/ORM/Query/SelectSqlGenerationTest.php index 6166a81ad..1aabaa78b 100644 --- a/tests/Doctrine/Tests/ORM/Query/SelectSqlGenerationTest.php +++ b/tests/Doctrine/Tests/ORM/Query/SelectSqlGenerationTest.php @@ -2271,6 +2271,27 @@ class SelectSqlGenerationTest extends \Doctrine\Tests\OrmTestCase 'SELECT COUNT(c0_.name) AS sclr_0 FROM cms_users c0_ HAVING sclr_0 IS NULL' ); } + + /** + * GitHub issue #4764: https://github.com/doctrine/doctrine2/issues/4764 + * @group DDC-3907 + * @dataProvider mathematicOperatorsProvider + */ + public function testHavingRegressionUsingVariableWithMathOperatorsExpression($operator) + { + $this->assertSqlGeneration( + 'SELECT COUNT(u.name) AS countName FROM Doctrine\Tests\Models\CMS\CmsUser u HAVING 1 ' . $operator . ' countName > 0', + 'SELECT COUNT(c0_.name) AS sclr_0 FROM cms_users c0_ HAVING 1 ' . $operator . ' sclr_0 > 0' + ); + } + + /** + * @return array + */ + public function mathematicOperatorsProvider() + { + return [['+'], ['-'], ['*'], ['/']]; + } } class MyAbsFunction extends \Doctrine\ORM\Query\AST\Functions\FunctionNode