Merge pull request #6121 from kalessil/sca

Static Code Analysis with Php Inspections (EA Extended)

lib/Doctrine/ORM/Cache/DefaultCache.php

@@ -314,7 +314,7 @@ class DefaultCache implements Cache
     private function buildCollectionCacheKey(ClassMetadata $metadata, $association, $ownerIdentifier)
     {
         if ( ! is_array($ownerIdentifier)) {
-            $ownerIdentifier = $this->toIdentifierArray($metadata, $ownerIdentifier);;
+            $ownerIdentifier = $this->toIdentifierArray($metadata, $ownerIdentifier);
         }
 
         return new CollectionCacheKey($metadata->rootEntityName, $association, $ownerIdentifier);

lib/Doctrine/ORM/Cache/Lock.php

@@ -53,6 +53,6 @@ class Lock
      */
     public static function createLockRead()
     {
-        return new self(uniqid(time()));
+        return new self(uniqid(time(), true));
     }
 }

lib/Doctrine/ORM/Mapping/Driver/DatabaseDriver.php

@@ -227,7 +227,7 @@ class DatabaseDriver implements MappingDriver
                     $fkCols = $myFk->getForeignColumns();
                     $cols = $myFk->getColumns();
 
-                    for ($i = 0; $i < count($cols); $i++) {
+                    for ($i = 0, $colsCount = count($cols); $i < $colsCount; $i++) {
                         $associationMapping['joinTable']['joinColumns'][] = array(
                             'name' => $cols[$i],
                             'referencedColumnName' => $fkCols[$i],
@@ -237,7 +237,7 @@ class DatabaseDriver implements MappingDriver
                     $fkCols = $otherFk->getForeignColumns();
                     $cols = $otherFk->getColumns();
 
-                    for ($i = 0; $i < count($cols); $i++) {
+                    for ($i = 0, $colsCount = count($cols); $i < $colsCount; $i++) {
                         $associationMapping['joinTable']['inverseJoinColumns'][] = array(
                             'name' => $cols[$i],
                             'referencedColumnName' => $fkCols[$i],
@@ -465,7 +465,7 @@ class DatabaseDriver implements MappingDriver
                 $associationMapping['id'] = true;
             }
 
-            for ($i = 0; $i < count($fkColumns); $i++) {
+            for ($i = 0, $fkColumnsCount = count($fkColumns); $i < $fkColumnsCount; $i++) {
                 $associationMapping['joinColumns'][] = array(
                     'name'                 => $fkColumns[$i],
                     'referencedColumnName' => $fkForeignColumns[$i],

lib/Doctrine/ORM/Query/ParameterTypeInferer.php

@@ -45,7 +45,7 @@ class ParameterTypeInferer
      */
     public static function inferType($value)
     {
-        if (is_integer($value)) {
+        if (is_int($value)) {
             return Type::INTEGER;
         }
 
@@ -58,7 +58,7 @@ class ParameterTypeInferer
         }
 
         if (is_array($value)) {
-            return is_integer(current($value))
+            return is_int(current($value))
                 ? Connection::PARAM_INT_ARRAY
                 : Connection::PARAM_STR_ARRAY;
         }

lib/Doctrine/ORM/Query/TreeWalkerChainIterator.php

@@ -119,7 +119,7 @@ class TreeWalkerChainIterator implements \Iterator, \ArrayAccess
      */
     public function offsetSet($offset, $value)
     {
-        if (is_null($offset)) {
+        if (null === $offset) {
             $this->walkers[] = $value;
         } else {
             $this->walkers[$offset] = $value;

lib/Doctrine/ORM/QueryBuilder.php

@@ -1458,7 +1458,7 @@ class QueryBuilder
      */
     public function resetDQLParts($parts = null)
     {
-        if (is_null($parts)) {
+        if (null === $parts) {
             $parts = array_keys($this->_dqlParts);
         }
 

lib/Doctrine/ORM/Tools/Console/Command/ValidateSchemaCommand.php

@@ -87,7 +87,7 @@ EOT
                 $output->writeln('');
             }
 
-            $exit += 1;
+            ++$exit;
         } else {
             $output->writeln('<info>[Mapping]  OK - The mapping files are correct.</info>');
         }

lib/Doctrine/ORM/Tools/DebugUnitOfWorkListener.php

@@ -78,7 +78,7 @@ class DebugUnitOfWorkListener
         $uow = $em->getUnitOfWork();
         $identityMap = $uow->getIdentityMap();
 
-        $fh = fopen($this->file, "x+");
+        $fh = fopen($this->file, 'xb+');
         if (count($identityMap) == 0) {
             fwrite($fh, "Flush Operation [".$this->context."] - Empty identity map.\n");
 

lib/Doctrine/ORM/Tools/EntityGenerator.php

@@ -808,7 +808,7 @@ public function __construct(<params>)
         $inNamespace = false;
         $inClass = false;
 
-        for ($i = 0; $i < count($tokens); $i++) {
+        for ($i = 0, $tokensCount = count($tokens); $i < $tokensCount; $i++) {
             $token = $tokens[$i];
             if (in_array($token[0], array(T_WHITESPACE, T_COMMENT, T_DOC_COMMENT))) {
                 continue;