RetailCRM-Mirror/doctrine2
1
0
Fork 0
mirror of synced 2025-02-10 17:29:27 +03:00
Code Issues Projects Releases Wiki Activity

#1521 DDC-2922 verifying that persistence operations will resume normally after a crash due to invalid new values detected on associations

Browse Source
This commit is contained in:
Marco Pivetta 2017-08-22 08:49:42 +02:00
parent 2751c0fff2
commit 89fbb6a060
No known key found for this signature in database
GPG Key ID: 4167D3337FD9D629
1 changed files with 41 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
tests/Doctrine/Tests/ORM/UnitOfWorkTest.php
View File

@ -663,7 +663,6 @@ class UnitOfWorkTest extends OrmTestCase
$this->assertCount(1, $persister3->getInserts()); $this->assertCount(1, $persister3->getInserts());
} }
/** /**
* This test exhibits the bug describe in the ticket, where an object that * This test exhibits the bug describe in the ticket, where an object that
* ought to be reachable causes errors. * ought to be reachable causes errors.
@ -714,6 +713,47 @@ class UnitOfWorkTest extends OrmTestCase
self::assertCount(1, $persister2->getInserts()); self::assertCount(1, $persister2->getInserts());
self::assertCount(1, $persister3->getInserts()); self::assertCount(1, $persister3->getInserts());
} }
/**
* This test exhibits the bug describe in the ticket, where an object that
* ought to be reachable causes errors.
*
* @group DDC-2922
* @group #1521
*/
public function testPreviousDetectedIllegalNewNonCascadedEntitiesAreCleanedUpOnSubsequentCommits()
{
$persister1 = new EntityPersisterMock($this->_emMock, $this->_emMock->getClassMetadata(CascadePersistedEntity::class));
$persister2 = new EntityPersisterMock($this->_emMock, $this->_emMock->getClassMetadata(EntityWithNonCascadingAssociation::class));
$this->_unitOfWork->setEntityPersister(CascadePersistedEntity::class, $persister1);
$this->_unitOfWork->setEntityPersister(EntityWithNonCascadingAssociation::class, $persister2);
$cascadePersisted = new CascadePersistedEntity();
$nonCascading = new EntityWithNonCascadingAssociation();
// We explicitly cause the ORM to detect a non-persisted new entity in the association graph:
$nonCascading->nonCascaded = $cascadePersisted;
$this->_unitOfWork->persist($nonCascading);
try {
$this->_unitOfWork->commit();
self::fail('An exception was supposed to be raised');
} catch (ORMInvalidArgumentException $ignored) {
self::assertEmpty($persister1->getInserts());
self::assertEmpty($persister2->getInserts());
}
$this->_unitOfWork->persist($cascadePersisted);
$this->_unitOfWork->persist($nonCascading);
$this->_unitOfWork->commit();
// Persistence operations should just recover normally:
self::assertCount(1, $persister1->getInserts());
self::assertCount(1, $persister2->getInserts());
}
} }
/** /**