From 8579baf28cdfacb1043b4a15c0fd3abbf7830452 Mon Sep 17 00:00:00 2001 From: Marco Pivetta Date: Thu, 15 Jan 2015 03:05:27 +0100 Subject: [PATCH] #1130 DDC-3300 - minor refactoring (`else` removal, spacing) --- .../ORM/Mapping/ClassMetadataInfo.php | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php b/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php index b88261a4d..c3c8d8c83 100644 --- a/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php +++ b/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php @@ -2745,15 +2745,18 @@ class ClassMetadataInfo implements ClassMetadata $className = ltrim($className, '\\'); $this->discriminatorMap[$name] = $className; - if ($this->name == $className) { + if ($this->name === $className) { $this->discriminatorValue = $name; - } else { - if ( ! class_exists($className) && ! interface_exists($className)) { - throw MappingException::invalidClassInDiscriminatorMap($className, $this->name); - } - if (is_subclass_of($className, $this->name) && ! in_array($className, $this->subClasses)) { - $this->subClasses[] = $className; - } + + return; + } + + if ( ! (class_exists($className) || interface_exists($className))) { + throw MappingException::invalidClassInDiscriminatorMap($className, $this->name); + } + + if (is_subclass_of($className, $this->name) && ! in_array($className, $this->subClasses)) { + $this->subClasses[] = $className; } }