RetailCRM-Mirror/doctrine2
1
0
Fork 0
mirror of synced 2025-03-05 20:36:15 +03:00
Code Issues Projects Releases Wiki Activity

#1188 - assertCount instead of assertEquals

Browse Source
This commit is contained in:
Marco Pivetta 2014-11-27 17:57:42 +01:00
parent 2f57c4fef9
commit 78770f9da8
1 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
tests/Doctrine/Tests/ORM/Functional/PaginationTest.php
View File

@ -154,7 +154,6 @@ class PaginationTest extends \Doctrine\Tests\OrmFunctionalTestCase
public function testCountQueryStripsParametersInSelect() public function testCountQueryStripsParametersInSelect()
{ {
/** @var $query Query */
$query = $this->_em->createQuery( $query = $this->_em->createQuery(
'SELECT u, (CASE WHEN u.id < :vipMaxId THEN 1 ELSE 0 END) AS hidden promotedFirst 'SELECT u, (CASE WHEN u.id < :vipMaxId THEN 1 ELSE 0 END) AS hidden promotedFirst
FROM Doctrine\\Tests\\Models\\CMS\\CmsUser u FROM Doctrine\\Tests\\Models\\CMS\\CmsUser u
@ -170,20 +169,17 @@ class PaginationTest extends \Doctrine\Tests\OrmFunctionalTestCase
$getCountQuery->setAccessible(true); $getCountQuery->setAccessible(true);
$countQuery = $getCountQuery->invoke($paginator); $this->assertCount(2, $getCountQuery->invoke($paginator)->getParameters());
$this->assertCount(3, $paginator);
$this->assertEquals(2, count($countQuery->getParameters()));
$this->assertEquals(3, $paginator->count());
$query->setHint(Query::HINT_CUSTOM_OUTPUT_WALKER, 'Doctrine\ORM\Query\SqlWalker'); $query->setHint(Query::HINT_CUSTOM_OUTPUT_WALKER, 'Doctrine\ORM\Query\SqlWalker');
$paginator = new Paginator($query); $paginator = new Paginator($query);
$countQuery = $getCountQuery->invoke($paginator); // if select part of query is replaced with count(...) paginator should remove
// parameters from query object not used in new query.
//if select part of query is replaced with count(...) paginator should remove parameters from query object not used in new query. $this->assertCount(1, $getCountQuery->invoke($paginator)->getParameters());
$this->assertEquals(1, count($countQuery->getParameters())); $this->assertCount(3, $paginator);
$this->assertEquals(3, $paginator->count());
} }
public function populate() public function populate()