1
0
mirror of synced 2025-02-03 05:49:25 +03:00

change switch/case to if/else

This commit is contained in:
Peter Gribanov 2016-06-08 10:29:39 +03:00
parent 3bc61d5f5e
commit 741da7806c

View File

@ -22,6 +22,7 @@ namespace Doctrine\ORM;
use Exception; use Exception;
use Doctrine\Common\EventManager; use Doctrine\Common\EventManager;
use Doctrine\DBAL\Connection; use Doctrine\DBAL\Connection;
use Doctrine\DBAL\DriverManager;
use Doctrine\DBAL\LockMode; use Doctrine\DBAL\LockMode;
use Doctrine\ORM\Query\ResultSetMapping; use Doctrine\ORM\Query\ResultSetMapping;
use Doctrine\ORM\Proxy\ProxyFactory; use Doctrine\ORM\Proxy\ProxyFactory;
@ -420,14 +421,14 @@ use Doctrine\Common\Util\ClassUtils;
return null; return null;
} }
switch (true) { switch ($lockMode) {
case LockMode::OPTIMISTIC === $lockMode: case LockMode::OPTIMISTIC:
$this->lock($entity, $lockMode, $lockVersion); $this->lock($entity, $lockMode, $lockVersion);
break; break;
case LockMode::NONE === $lockMode: case LockMode::NONE:
case LockMode::PESSIMISTIC_READ === $lockMode: case LockMode::PESSIMISTIC_READ:
case LockMode::PESSIMISTIC_WRITE === $lockMode: case LockMode::PESSIMISTIC_WRITE:
$persister = $unitOfWork->getEntityPersister($class->name); $persister = $unitOfWork->getEntityPersister($class->name);
$persister->refresh($sortedId, $entity, $lockMode); $persister->refresh($sortedId, $entity, $lockMode);
break; break;
@ -438,8 +439,8 @@ use Doctrine\Common\Util\ClassUtils;
$persister = $unitOfWork->getEntityPersister($class->name); $persister = $unitOfWork->getEntityPersister($class->name);
switch (true) { switch ($lockMode) {
case LockMode::OPTIMISTIC === $lockMode: case LockMode::OPTIMISTIC:
if ( ! $class->isVersioned) { if ( ! $class->isVersioned) {
throw OptimisticLockException::notVersioned($class->name); throw OptimisticLockException::notVersioned($class->name);
} }
@ -450,8 +451,8 @@ use Doctrine\Common\Util\ClassUtils;
return $entity; return $entity;
case LockMode::PESSIMISTIC_READ === $lockMode: case LockMode::PESSIMISTIC_READ:
case LockMode::PESSIMISTIC_WRITE === $lockMode: case LockMode::PESSIMISTIC_WRITE:
if ( ! $this->getConnection()->isTransactionActive()) { if ( ! $this->getConnection()->isTransactionActive()) {
throw TransactionRequiredException::transactionRequired(); throw TransactionRequiredException::transactionRequired();
} }
@ -835,20 +836,15 @@ use Doctrine\Common\Util\ClassUtils;
throw ORMException::missingMappingDriverImpl(); throw ORMException::missingMappingDriverImpl();
} }
switch (true) { if (is_array($conn)) {
case (is_array($conn)): $conn = DriverManager::getConnection(
$conn = \Doctrine\DBAL\DriverManager::getConnection(
$conn, $config, ($eventManager ?: new EventManager()) $conn, $config, ($eventManager ?: new EventManager())
); );
break; } elseif ($conn instanceof Connection) {
case ($conn instanceof Connection):
if ($eventManager !== null && $conn->getEventManager() !== $eventManager) { if ($eventManager !== null && $conn->getEventManager() !== $eventManager) {
throw ORMException::mismatchedEventManager(); throw ORMException::mismatchedEventManager();
} }
break; } else {
default:
throw new \InvalidArgumentException("Invalid argument: " . $conn); throw new \InvalidArgumentException("Invalid argument: " . $conn);
} }