From 7164e28138892e655d926945416f32d46fe5b6de Mon Sep 17 00:00:00 2001
From: Marco Pivetta <ocramius@gmail.com>
Date: Wed, 14 Jan 2015 19:16:42 +0100
Subject: [PATCH] #881 DDC-2825 - renaming table/schema name for clarity and to
 avoid collisions

---
 .../Tests/Models/DDC2825/ExplicitSchemaAndTable.php      | 9 ++-------
 .../Tests/Models/DDC2825/SchemaAndTableInTableName.php   | 7 ++-----
 .../Tests/ORM/Mapping/AbstractMappingDriverTest.php      | 8 ++++----
 ...trine.Tests.Models.DDC2825.ExplicitSchemaAndTable.php | 4 ++--
 ...ne.Tests.Models.DDC2825.SchemaAndTableInTableName.php | 2 +-
 ...e.Tests.Models.DDC2825.ExplicitSchemaAndTable.dcm.xml | 2 +-
 ...ests.Models.DDC2825.SchemaAndTableInTableName.dcm.xml | 2 +-
 ...e.Tests.Models.DDC2825.ExplicitSchemaAndTable.dcm.yml | 4 ++--
 ...ests.Models.DDC2825.SchemaAndTableInTableName.dcm.yml | 2 +-
 9 files changed, 16 insertions(+), 24 deletions(-)

diff --git a/tests/Doctrine/Tests/Models/DDC2825/ExplicitSchemaAndTable.php b/tests/Doctrine/Tests/Models/DDC2825/ExplicitSchemaAndTable.php
index fea220c1b..60b5d5625 100644
--- a/tests/Doctrine/Tests/Models/DDC2825/ExplicitSchemaAndTable.php
+++ b/tests/Doctrine/Tests/Models/DDC2825/ExplicitSchemaAndTable.php
@@ -2,16 +2,11 @@
 
 namespace Doctrine\Tests\Models\DDC2825;
 
-/**
- * @Entity
- * @Table(name="mytable", schema="myschema")
- */
+/** @Entity @Table(name="explicit_table", schema="explicit_schema") */
 class ExplicitSchemaAndTable
 {
     const CLASSNAME = __CLASS__;
 
-    /**
-     * @Id @Column()
-     */
+    /** @Id @Column(type="integer") @GeneratedValue(strategy="AUTO") */
     public $id;
 }
diff --git a/tests/Doctrine/Tests/Models/DDC2825/SchemaAndTableInTableName.php b/tests/Doctrine/Tests/Models/DDC2825/SchemaAndTableInTableName.php
index e049befac..bd22c2b23 100644
--- a/tests/Doctrine/Tests/Models/DDC2825/SchemaAndTableInTableName.php
+++ b/tests/Doctrine/Tests/Models/DDC2825/SchemaAndTableInTableName.php
@@ -6,15 +6,12 @@ namespace Doctrine\Tests\Models\DDC2825;
  * Quoted column name to check that sequence names are
  * correctly handled
  *
- * @Entity
- * @Table(name="myschema.mytable")
+ * @Entity @Table(name="implicit_schema.implicit_table")
  */
 class SchemaAndTableInTableName
 {
     const CLASSNAME = __CLASS__;
 
-    /**
-     * @Id @Column()
-     */
+    /** @Id @Column(type="integer") @GeneratedValue(strategy="AUTO") */
     public $id;
 }
\ No newline at end of file
diff --git a/tests/Doctrine/Tests/ORM/Mapping/AbstractMappingDriverTest.php b/tests/Doctrine/Tests/ORM/Mapping/AbstractMappingDriverTest.php
index 871f0c153..8a619dcf0 100644
--- a/tests/Doctrine/Tests/ORM/Mapping/AbstractMappingDriverTest.php
+++ b/tests/Doctrine/Tests/ORM/Mapping/AbstractMappingDriverTest.php
@@ -944,8 +944,8 @@ abstract class AbstractMappingDriverTest extends \Doctrine\Tests\OrmTestCase
         /* @var $metadata \Doctrine\ORM\Mapping\ClassMetadata */
         $metadata = $this->createClassMetadataFactory()->getMetadataFor(ExplicitSchemaAndTable::CLASSNAME);
 
-        $this->assertSame('myschema', $metadata->getSchemaName());
-        $this->assertSame('mytable', $metadata->getTableName());
+        $this->assertSame('explicit_schema', $metadata->getSchemaName());
+        $this->assertSame('explicit_table', $metadata->getTableName());
     }
 
     /**
@@ -957,8 +957,8 @@ abstract class AbstractMappingDriverTest extends \Doctrine\Tests\OrmTestCase
         /* @var $metadata \Doctrine\ORM\Mapping\ClassMetadata */
         $metadata = $this->createClassMetadataFactory()->getMetadataFor(SchemaAndTableInTableName::CLASSNAME);
 
-        $this->assertSame('myschema', $metadata->getSchemaName());
-        $this->assertSame('mytable', $metadata->getTableName());
+        $this->assertSame('implicit_schema', $metadata->getSchemaName());
+        $this->assertSame('implicit_table', $metadata->getTableName());
     }
 }
 
diff --git a/tests/Doctrine/Tests/ORM/Mapping/php/Doctrine.Tests.Models.DDC2825.ExplicitSchemaAndTable.php b/tests/Doctrine/Tests/ORM/Mapping/php/Doctrine.Tests.Models.DDC2825.ExplicitSchemaAndTable.php
index 27f555944..4a163c9bd 100644
--- a/tests/Doctrine/Tests/ORM/Mapping/php/Doctrine.Tests.Models.DDC2825.ExplicitSchemaAndTable.php
+++ b/tests/Doctrine/Tests/ORM/Mapping/php/Doctrine.Tests.Models.DDC2825.ExplicitSchemaAndTable.php
@@ -5,8 +5,8 @@ use Doctrine\ORM\Mapping\ClassMetadata;
 /* @var $metadata ClassMetadata */
 
 $metadata->setPrimaryTable(array(
-    'name'   => 'mytable',
-    'schema' => 'myschema',
+    'name'   => 'explicit_table',
+    'schema' => 'explicit_schema',
 ));
 
 $metadata->mapField(array(
diff --git a/tests/Doctrine/Tests/ORM/Mapping/php/Doctrine.Tests.Models.DDC2825.SchemaAndTableInTableName.php b/tests/Doctrine/Tests/ORM/Mapping/php/Doctrine.Tests.Models.DDC2825.SchemaAndTableInTableName.php
index 75ca602b5..045a97858 100644
--- a/tests/Doctrine/Tests/ORM/Mapping/php/Doctrine.Tests.Models.DDC2825.SchemaAndTableInTableName.php
+++ b/tests/Doctrine/Tests/ORM/Mapping/php/Doctrine.Tests.Models.DDC2825.SchemaAndTableInTableName.php
@@ -5,7 +5,7 @@ use Doctrine\ORM\Mapping\ClassMetadata;
 /* @var $metadata ClassMetadata */
 
 $metadata->setPrimaryTable(array(
-    'name' => 'myschema.mytable',
+    'name' => 'implicit_schema.implicit_table',
 ));
 
 $metadata->mapField(array(
diff --git a/tests/Doctrine/Tests/ORM/Mapping/xml/Doctrine.Tests.Models.DDC2825.ExplicitSchemaAndTable.dcm.xml b/tests/Doctrine/Tests/ORM/Mapping/xml/Doctrine.Tests.Models.DDC2825.ExplicitSchemaAndTable.dcm.xml
index 938380072..11bb55706 100644
--- a/tests/Doctrine/Tests/ORM/Mapping/xml/Doctrine.Tests.Models.DDC2825.ExplicitSchemaAndTable.dcm.xml
+++ b/tests/Doctrine/Tests/ORM/Mapping/xml/Doctrine.Tests.Models.DDC2825.ExplicitSchemaAndTable.dcm.xml
@@ -5,7 +5,7 @@
         xsi:schemaLocation="http://doctrine-project.org/schemas/orm/doctrine-mapping
                             https://raw.github.com/doctrine/doctrine2/master/doctrine-mapping.xsd"
 >
-    <entity name="Doctrine\Tests\Models\DDC2825\ExplicitSchemaAndTable" table="mytable" schema="myschema">
+    <entity name="Doctrine\Tests\Models\DDC2825\ExplicitSchemaAndTable" table="explicit_table" schema="explicit_schema">
         <id name="id" column="id">
             <generator strategy="AUTO"/>
         </id>
diff --git a/tests/Doctrine/Tests/ORM/Mapping/xml/Doctrine.Tests.Models.DDC2825.SchemaAndTableInTableName.dcm.xml b/tests/Doctrine/Tests/ORM/Mapping/xml/Doctrine.Tests.Models.DDC2825.SchemaAndTableInTableName.dcm.xml
index 0f6be73f0..3a89dd973 100644
--- a/tests/Doctrine/Tests/ORM/Mapping/xml/Doctrine.Tests.Models.DDC2825.SchemaAndTableInTableName.dcm.xml
+++ b/tests/Doctrine/Tests/ORM/Mapping/xml/Doctrine.Tests.Models.DDC2825.SchemaAndTableInTableName.dcm.xml
@@ -5,7 +5,7 @@
         xsi:schemaLocation="http://doctrine-project.org/schemas/orm/doctrine-mapping
                             https://raw.github.com/doctrine/doctrine2/master/doctrine-mapping.xsd"
 >
-    <entity name="Doctrine\Tests\Models\DDC2825\SchemaAndTableInTableName" table="myschema.mytable">
+    <entity name="Doctrine\Tests\Models\DDC2825\SchemaAndTableInTableName" table="implicit_schema.implicit_table">
         <id name="id" column="id">
             <generator strategy="AUTO"/>
         </id>
diff --git a/tests/Doctrine/Tests/ORM/Mapping/yaml/Doctrine.Tests.Models.DDC2825.ExplicitSchemaAndTable.dcm.yml b/tests/Doctrine/Tests/ORM/Mapping/yaml/Doctrine.Tests.Models.DDC2825.ExplicitSchemaAndTable.dcm.yml
index 7675a6e5d..f28adbb61 100644
--- a/tests/Doctrine/Tests/ORM/Mapping/yaml/Doctrine.Tests.Models.DDC2825.ExplicitSchemaAndTable.dcm.yml
+++ b/tests/Doctrine/Tests/ORM/Mapping/yaml/Doctrine.Tests.Models.DDC2825.ExplicitSchemaAndTable.dcm.yml
@@ -1,7 +1,7 @@
 Doctrine\Tests\Models\DDC2825\ExplicitSchemaAndTable:
   type: entity
-  table: mytable
-  schema: myschema
+  table: explicit_table
+  schema: explicit_schema
   id:
     id:
       generator:
diff --git a/tests/Doctrine/Tests/ORM/Mapping/yaml/Doctrine.Tests.Models.DDC2825.SchemaAndTableInTableName.dcm.yml b/tests/Doctrine/Tests/ORM/Mapping/yaml/Doctrine.Tests.Models.DDC2825.SchemaAndTableInTableName.dcm.yml
index a63173daa..bf072816c 100644
--- a/tests/Doctrine/Tests/ORM/Mapping/yaml/Doctrine.Tests.Models.DDC2825.SchemaAndTableInTableName.dcm.yml
+++ b/tests/Doctrine/Tests/ORM/Mapping/yaml/Doctrine.Tests.Models.DDC2825.SchemaAndTableInTableName.dcm.yml
@@ -1,6 +1,6 @@
 Doctrine\Tests\Models\DDC2825\SchemaAndTableInTableName:
   type: entity
-  table: myschema.mytable
+  table: implicit_schema.implicit_table
   id:
     id:
       generator: