Fixes #5755, uses '->getReflectionProperties()' instead of '->getReflectionClass()->getProperties()' to ensure all fields are copied, and adds test to confirm behaviour
This commit is contained in:
parent
22105058fa
commit
67e205b36a
@ -196,7 +196,7 @@ class ProxyFactory extends AbstractProxyFactory
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
foreach ($class->getReflectionClass()->getProperties() as $property) {
|
foreach ($class->getReflectionProperties() as $property) {
|
||||||
if ( ! $class->hasField($property->name) && ! $class->hasAssociation($property->name)) {
|
if ( ! $class->hasField($property->name) && ! $class->hasAssociation($property->name)) {
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
@ -3,16 +3,17 @@
|
|||||||
namespace Doctrine\Tests\ORM\Proxy;
|
namespace Doctrine\Tests\ORM\Proxy;
|
||||||
|
|
||||||
use Doctrine\Common\Persistence\Mapping\RuntimeReflectionService;
|
use Doctrine\Common\Persistence\Mapping\RuntimeReflectionService;
|
||||||
|
use Doctrine\Common\Proxy\AbstractProxyFactory;
|
||||||
use Doctrine\ORM\EntityNotFoundException;
|
use Doctrine\ORM\EntityNotFoundException;
|
||||||
use Doctrine\ORM\Mapping\ClassMetadata;
|
use Doctrine\ORM\Mapping\ClassMetadata;
|
||||||
use Doctrine\ORM\Persisters\Entity\BasicEntityPersister;
|
use Doctrine\ORM\Persisters\Entity\BasicEntityPersister;
|
||||||
use Doctrine\ORM\Proxy\ProxyFactory;
|
use Doctrine\ORM\Proxy\ProxyFactory;
|
||||||
use Doctrine\Tests\Mocks\ConnectionMock;
|
use Doctrine\Tests\Mocks\ConnectionMock;
|
||||||
|
use Doctrine\Tests\Mocks\DriverMock;
|
||||||
use Doctrine\Tests\Mocks\EntityManagerMock;
|
use Doctrine\Tests\Mocks\EntityManagerMock;
|
||||||
use Doctrine\Tests\Mocks\UnitOfWorkMock;
|
use Doctrine\Tests\Mocks\UnitOfWorkMock;
|
||||||
use Doctrine\Tests\Mocks\DriverMock;
|
|
||||||
use Doctrine\Common\Proxy\AbstractProxyFactory;
|
|
||||||
use Doctrine\Tests\OrmTestCase;
|
use Doctrine\Tests\OrmTestCase;
|
||||||
|
use Doctrine\Tests\Models\Company\CompanyEmployee;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Test the proxy generator. Its work is generating on-the-fly subclasses of a given model, which implement the Proxy pattern.
|
* Test the proxy generator. Its work is generating on-the-fly subclasses of a given model, which implement the Proxy pattern.
|
||||||
@ -139,6 +140,45 @@ class ProxyFactoryTest extends OrmTestCase
|
|||||||
$this->assertInstanceOf('Closure', $proxy->__getInitializer(), 'The initializer wasn\'t removed');
|
$this->assertInstanceOf('Closure', $proxy->__getInitializer(), 'The initializer wasn\'t removed');
|
||||||
$this->assertInstanceOf('Closure', $proxy->__getCloner(), 'The cloner wasn\'t removed');
|
$this->assertInstanceOf('Closure', $proxy->__getCloner(), 'The cloner wasn\'t removed');
|
||||||
}
|
}
|
||||||
|
|
||||||
|
public function testProxyClonesParentFields()
|
||||||
|
{
|
||||||
|
$companyEmployee = new CompanyEmployee();
|
||||||
|
$companyEmployee->setSalary(1000); // A property on the CompanyEmployee
|
||||||
|
$companyEmployee->setName("Bob"); // A property on the parent class, CompanyPerson
|
||||||
|
|
||||||
|
// Set the id of the CompanyEmployee (which is in the parent CompanyPerson)
|
||||||
|
$class = new \ReflectionClass('Doctrine\Tests\Models\Company\CompanyPerson');
|
||||||
|
|
||||||
|
$property = $class->getProperty('id');
|
||||||
|
$property->setAccessible(true);
|
||||||
|
|
||||||
|
$property->setValue($companyEmployee, 42);
|
||||||
|
|
||||||
|
$classMetaData = $this->emMock->getClassMetadata('Doctrine\Tests\Models\Company\CompanyEmployee');
|
||||||
|
|
||||||
|
$persister = $this->getMock('Doctrine\ORM\Persisters\Entity\BasicEntityPersister', array('load', 'getClassMetadata'), array(), '', false);
|
||||||
|
$this->uowMock->setEntityPersister('Doctrine\Tests\Models\Company\CompanyEmployee', $persister);
|
||||||
|
|
||||||
|
/* @var $proxy \Doctrine\Common\Proxy\Proxy */
|
||||||
|
$proxy = $this->proxyFactory->getProxy('Doctrine\Tests\Models\Company\CompanyEmployee', array('id' => 42));
|
||||||
|
|
||||||
|
$persister
|
||||||
|
->expects($this->atLeastOnce())
|
||||||
|
->method('load')
|
||||||
|
->will($this->returnValue($companyEmployee));
|
||||||
|
|
||||||
|
$persister
|
||||||
|
->expects($this->atLeastOnce())
|
||||||
|
->method('getClassMetadata')
|
||||||
|
->will($this->returnValue($classMetaData));
|
||||||
|
|
||||||
|
$cloned = clone $proxy;
|
||||||
|
|
||||||
|
$this->assertEquals(42, $cloned->getId(), "Expected the Id to be cloned");
|
||||||
|
$this->assertEquals(1000, $cloned->getSalary(), "Expect properties on the CompanyEmployee class to be cloned");
|
||||||
|
$this->assertEquals("Bob", $cloned->getName(), "Expect properties on the CompanyPerson class to be cloned");
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
abstract class AbstractClass
|
abstract class AbstractClass
|
||||||
|
Loading…
x
Reference in New Issue
Block a user